From 69678f59fca5bfb6154d7dc80986e3573fb4c1e0 Mon Sep 17 00:00:00 2001
From: Dhruv Parmar <83108871+dhruvjsx@users.noreply.github.com>
Date: Mon, 7 Apr 2025 21:31:02 +0530
Subject: [PATCH] MInor: Fixed PR Comments (#20655)

* fixed Memerbs page || table|| bot column

* Minor:added cursor pointer

* Minor:added cursor pointer

* fixed comments

* fixed comments

* fixed comments
---
 .../Bot/BotListV1/BotListV1.component.tsx      |  8 +++-----
 .../Settings/Bot/BotListV1/bot-list-v1.less    | 18 ++++++++++++++++++
 .../DomainSelectableList.component.tsx         | 12 ++++--------
 .../DomainSelectableTree.interface.ts          |  2 +-
 .../resources/ui/src/constants/constants.ts    |  1 -
 .../generated/api/services/createApiService.ts |  4 ++++
 .../generated/entity/services/apiService.ts    |  4 ++++
 .../ingestionPipelines/ingestionPipeline.ts    |  4 ++++
 8 files changed, 38 insertions(+), 15 deletions(-)
 create mode 100644 openmetadata-ui/src/main/resources/ui/src/components/Settings/Bot/BotListV1/bot-list-v1.less

diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Settings/Bot/BotListV1/BotListV1.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/Settings/Bot/BotListV1/BotListV1.component.tsx
index 48782ef2d44..92846f3c1b5 100644
--- a/openmetadata-ui/src/main/resources/ui/src/components/Settings/Bot/BotListV1/BotListV1.component.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/components/Settings/Bot/BotListV1/BotListV1.component.tsx
@@ -20,7 +20,6 @@ import React, { useCallback, useEffect, useMemo, useState } from 'react';
 import { useTranslation } from 'react-i18next';
 import { Link } from 'react-router-dom';
 import { ReactComponent as IconDelete } from '../../../../assets/svg/ic-delete.svg';
-import { LINK_COLOR } from '../../../../constants/constants';
 import { BOTS_DOCS } from '../../../../constants/docs.constants';
 import { GlobalSettingsMenuCategory } from '../../../../constants/GlobalSettings.constants';
 import { PAGE_HEADERS } from '../../../../constants/PageHeaders.constant';
@@ -52,8 +51,8 @@ import Table from '../../../common/Table/Table';
 import TitleBreadcrumb from '../../../common/TitleBreadcrumb/TitleBreadcrumb.component';
 import { TitleBreadcrumbProps } from '../../../common/TitleBreadcrumb/TitleBreadcrumb.interface';
 import PageHeader from '../../../PageHeader/PageHeader.component';
+import './bot-list-v1.less';
 import { BotListV1Props } from './BotListV1.interfaces';
-
 const BotListV1 = ({
   showDeleted,
   handleAddBotClick,
@@ -130,8 +129,7 @@ const BotListV1 = ({
             <Link data-testid={`bot-link-${name}`} to={getBotsPath(fqn)}>
               <Typography.Text
                 className="text-ellipsis bot-link"
-                ellipsis={{ tooltip: true }}
-                style={{ color: LINK_COLOR }}>
+                ellipsis={{ tooltip: true }}>
                 {stringToHTML(highlightSearchText(name, searchTerm))}
               </Typography.Text>
             </Link>
@@ -315,7 +313,7 @@ const BotListV1 = ({
           onSearch={handleSearch}
         />
       </Col>
-      <Col span={24}>
+      <Col className="bot-list-v1-container" span={24}>
         <Table
           columns={columns}
           customPaginationProps={{
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Settings/Bot/BotListV1/bot-list-v1.less b/openmetadata-ui/src/main/resources/ui/src/components/Settings/Bot/BotListV1/bot-list-v1.less
new file mode 100644
index 00000000000..077dd8b0eea
--- /dev/null
+++ b/openmetadata-ui/src/main/resources/ui/src/components/Settings/Bot/BotListV1/bot-list-v1.less
@@ -0,0 +1,18 @@
+/*
+ *  Copyright 2025 Collate.
+ *  Licensed under the Apache License, Version 2.0 (the "License");
+ *  you may not use this file except in compliance with the License.
+ *  You may obtain a copy of the License at
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *  Unless required by applicable law or agreed to in writing, software
+ *  distributed under the License is distributed on an "AS IS" BASIS,
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *  See the License for the specific language governing permissions and
+ *  limitations under the License.
+ */
+@import (reference) url('../../../../styles/variables.less');
+.bot-list-v1-container {
+  .bot-link {
+    color: @blue-17;
+  }
+}
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/common/DomainSelectableList/DomainSelectableList.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/common/DomainSelectableList/DomainSelectableList.component.tsx
index e30a4f5a3d5..5021ab74ae3 100644
--- a/openmetadata-ui/src/main/resources/ui/src/components/common/DomainSelectableList/DomainSelectableList.component.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/components/common/DomainSelectableList/DomainSelectableList.component.tsx
@@ -95,14 +95,10 @@ const DomainSelectableList = ({
     [onUpdate, multiple]
   );
 
-  const handleCancel = useCallback(
-    (e) => {
-      e.stopPropagation();
-      setPopupVisible(false);
-      onCancel?.();
-    },
-    [onCancel]
-  );
+  const handleCancel = useCallback(() => {
+    setPopupVisible(false);
+    onCancel?.();
+  }, [onCancel]);
 
   const popoverContent = useMemo(() => {
     return (
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/common/DomainSelectableTree/DomainSelectableTree.interface.ts b/openmetadata-ui/src/main/resources/ui/src/components/common/DomainSelectableTree/DomainSelectableTree.interface.ts
index 6e3efd19270..954e32ab311 100644
--- a/openmetadata-ui/src/main/resources/ui/src/components/common/DomainSelectableTree/DomainSelectableTree.interface.ts
+++ b/openmetadata-ui/src/main/resources/ui/src/components/common/DomainSelectableTree/DomainSelectableTree.interface.ts
@@ -17,7 +17,7 @@ export interface DomainSelectableTreeProps {
   value?: string[]; // array of fqn
   onSubmit: (option: EntityReference[]) => Promise<void>;
   visible: boolean;
-  onCancel: (event?: React.SyntheticEvent) => void;
+  onCancel: () => void;
   isMultiple?: boolean;
   initialDomains?: EntityReference[];
   dropdownRef?: React.RefObject<HTMLDivElement>;
diff --git a/openmetadata-ui/src/main/resources/ui/src/constants/constants.ts b/openmetadata-ui/src/main/resources/ui/src/constants/constants.ts
index e168a6476a8..c1962eeb8a2 100644
--- a/openmetadata-ui/src/main/resources/ui/src/constants/constants.ts
+++ b/openmetadata-ui/src/main/resources/ui/src/constants/constants.ts
@@ -35,7 +35,6 @@ export const BORDER_COLOR = '#0000001a';
 export const BLACK_COLOR = '#000000';
 export const WHITE_COLOR = '#ffffff';
 export const LIGHT_GREEN_COLOR = '#4CAF50';
-export const LINK_COLOR = '#0968da';
 
 export const DEFAULT_CHART_OPACITY = 1;
 export const HOVER_CHART_OPACITY = 0.3;
diff --git a/openmetadata-ui/src/main/resources/ui/src/generated/api/services/createApiService.ts b/openmetadata-ui/src/main/resources/ui/src/generated/api/services/createApiService.ts
index 785af1dde1e..fc07f18bcf6 100644
--- a/openmetadata-ui/src/main/resources/ui/src/generated/api/services/createApiService.ts
+++ b/openmetadata-ui/src/main/resources/ui/src/generated/api/services/createApiService.ts
@@ -66,6 +66,10 @@ export interface RESTConnection {
      * Regex to only fetch api collections with names matching the pattern.
      */
     apiCollectionFilterPattern?: FilterPattern;
+    /**
+     * Documentation URL for the schema.
+     */
+    docURL?: string;
     /**
      * Open API Schema URL.
      */
diff --git a/openmetadata-ui/src/main/resources/ui/src/generated/entity/services/apiService.ts b/openmetadata-ui/src/main/resources/ui/src/generated/entity/services/apiService.ts
index 856ecb480f5..4964d22a8af 100644
--- a/openmetadata-ui/src/main/resources/ui/src/generated/entity/services/apiService.ts
+++ b/openmetadata-ui/src/main/resources/ui/src/generated/entity/services/apiService.ts
@@ -180,6 +180,10 @@ export interface RESTConnection {
      * Regex to only fetch api collections with names matching the pattern.
      */
     apiCollectionFilterPattern?: FilterPattern;
+    /**
+     * Documentation URL for the schema.
+     */
+    docURL?: string;
     /**
      * Open API Schema URL.
      */
diff --git a/openmetadata-ui/src/main/resources/ui/src/generated/entity/services/ingestionPipelines/ingestionPipeline.ts b/openmetadata-ui/src/main/resources/ui/src/generated/entity/services/ingestionPipelines/ingestionPipeline.ts
index e3fae5514f9..7d1401e8e0a 100644
--- a/openmetadata-ui/src/main/resources/ui/src/generated/entity/services/ingestionPipelines/ingestionPipeline.ts
+++ b/openmetadata-ui/src/main/resources/ui/src/generated/entity/services/ingestionPipelines/ingestionPipeline.ts
@@ -2598,6 +2598,10 @@ export interface ConfigClass {
      * Regex to only fetch api collections with names matching the pattern.
      */
     apiCollectionFilterPattern?: FilterPattern;
+    /**
+     * Documentation URL for the schema.
+     */
+    docURL?: string;
     /**
      * Open API Schema URL.
      */