From 6b10adc40f44814090206fcfaa0a8fb66c47ba7e Mon Sep 17 00:00:00 2001 From: Mayur Singal <39544459+ulixius9@users.noreply.github.com> Date: Sun, 17 Jul 2022 23:06:24 +0530 Subject: [PATCH] Bigquery View Lineage Fix (#6129) --- ingestion/src/metadata/ingestion/source/database/bigquery.py | 3 ++- ingestion/src/metadata/utils/sql_lineage.py | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/ingestion/src/metadata/ingestion/source/database/bigquery.py b/ingestion/src/metadata/ingestion/source/database/bigquery.py index 532628849ba..948003526e5 100644 --- a/ingestion/src/metadata/ingestion/source/database/bigquery.py +++ b/ingestion/src/metadata/ingestion/source/database/bigquery.py @@ -29,6 +29,7 @@ from metadata.generated.schema.api.tags.createTag import CreateTagRequest from metadata.generated.schema.api.tags.createTagCategory import ( CreateTagCategoryRequest, ) +from metadata.generated.schema.entity.data.table import TableType from metadata.generated.schema.entity.services.connections.database.bigQueryConnection import ( BigQueryConnection, ) @@ -181,7 +182,7 @@ class BigquerySource(CommonDbSourceService): def get_view_definition( self, table_type: str, table_name: str, schema_name: str, inspector: Inspector ) -> Optional[str]: - if table_type == "View": + if table_type == TableType.View: view_definition = "" try: view_definition = inspector.get_view_definition( diff --git a/ingestion/src/metadata/utils/sql_lineage.py b/ingestion/src/metadata/utils/sql_lineage.py index 1fc1099c8f9..b89489b0780 100644 --- a/ingestion/src/metadata/utils/sql_lineage.py +++ b/ingestion/src/metadata/utils/sql_lineage.py @@ -314,6 +314,7 @@ def get_lineage_by_query( ) except Exception as err: logger.debug(str(err)) + logger.debug(f"Query : {query}") logger.warning(f"Ingesting lineage failed") @@ -349,6 +350,6 @@ def get_lineage_via_table_entity( query=query, ) or [] except Exception as e: - logger.error("Failed to create view lineage") + logger.warn("Failed to create view lineage") logger.debug(f"Query : {query}") logger.debug(traceback.format_exc())