yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2026-01-06 12:36:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

Profiler & Data Quality UI feedback & improvement #7090 part 3 (#7123)

Browse Source
This commit is contained in:
Shailesh Parmar 2022-09-01 21:49:43 +05:30 committed by GitHub
parent 55793877af
commit 6b61c43a0a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 18 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
openmetadata-ui/src/main/resources/ui/src/components/AddDataQualityTest/AddDataQualityTestV1.tsx
View File

@ -97,7 +97,7 @@ const AddDataQualityTestV1: React.FC<AddDataQualityTestProps> = ({ table }) => {
},
{
name: getEntityName(table),
url: getTableTabPath(fullyQualifiedName),
url: getTableTabPath(entityTypeFQN, 'profiler'),
},
];
@ -105,7 +105,7 @@ const AddDataQualityTestV1: React.FC<AddDataQualityTestProps> = ({ table }) => {
const colVal = [
{
name: getNameFromFQN(entityTypeFQN),
url: getTableTabPath(fullyQualifiedName),
url: getTableTabPath(entityTypeFQN, 'profiler'),
},
{
name: 'Add Column Test',

2
openmetadata-ui/src/main/resources/ui/src/components/AddDataQualityTest/components/SelectTestSuite.tsx
View File

@ -70,7 +70,7 @@ const SelectTestSuite: React.FC<SelectTestSuiteProps> = ({
};
const handleCancelClick = () => {
history.push(getTableTabPath(entityTypeFQN));
history.push(getTableTabPath(entityTypeFQN, 'profiler'));
};
const handleFormSubmit: FormProps['onFinish'] = (value) => {

2
openmetadata-ui/src/main/resources/ui/src/components/AddDataQualityTest/rightPanelData.ts
View File

@ -15,7 +15,7 @@
export const TEST_FORM_DATA = [
{
title: 'Select/Create Test Suite',
body: 'To create a Table or Column level test for an entity, start by selecting the Test Suite. Select an existing test suite or create a new test suite.',
body: 'A Test Suite is a container consisting of multiple but related test cases. With a Test Suite, you can easily deploy a pipeline to execute the Test Cases. Start by selecting an existing test suite or create a new test suite to create a table or column level test for an entity.',
},
{
title: 'Create Test Case',

18
openmetadata-ui/src/main/resources/ui/src/components/ProfilerDashboard/ProfilerDashboard.tsx
View File

@ -55,6 +55,7 @@ import {
} from '../../utils/TableUtils';
import { showErrorToast } from '../../utils/ToastUtils';
import EntityPageInfo from '../common/entityPageInfo/EntityPageInfo';
import { TitleBreadcrumbProps } from '../common/title-breadcrumb/title-breadcrumb.interface';
import PageLayout from '../containers/PageLayout';
import DataQualityTab from './component/DataQualityTab';
import ProfilerTab from './component/ProfilerTab';
@ -129,7 +130,7 @@ const ProfilerDashboard: React.FC<ProfilerDashboardProps> = ({
const fqn = table.fullyQualifiedName || '';
const columnName = getNameFromFQN(entityTypeFQN);
return [
const data: TitleBreadcrumbProps['titleLinks'] = [
{
name: getEntityName(table.service),
url: serviceName
@ -152,14 +153,21 @@ const ProfilerDashboard: React.FC<ProfilerDashboardProps> = ({
},
{
name: getEntityName(table),
url: getTableTabPath(table.fullyQualifiedName || ''),
url: isColumnView
? getTableTabPath(table.fullyQualifiedName || '', 'profiler')
: '',
},
{
];
if (isColumnView) {
data.push({
name: columnName,
url: '',
activeTitle: true,
},
];
});
}
return data;
}, [table]);
const extraInfo: Array<ExtraInfo> = useMemo(() => {

4
openmetadata-ui/src/main/resources/ui/src/components/TableProfiler/Component/ColumnProfileTable.tsx
View File

@ -27,7 +27,6 @@ import {
} from '../../../constants/profiler.constant';
import { ProfilerDashboardType } from '../../../enums/table.enum';
import { Column, ColumnProfile } from '../../../generated/entity/data/table';
import { formatNumberWithComma } from '../../../utils/CommonUtils';
import { updateTestResults } from '../../../utils/DataQualityAndProfilerUtils';
import {
getAddDataQualityTableTestPath,
@ -123,8 +122,7 @@ const ColumnProfileTable: FC<ColumnProfileTableProps> = ({
title: 'Value Count',
dataIndex: 'profile',
key: 'valuesCount',
render: (profile: ColumnProfile) =>
formatNumberWithComma(profile?.valuesCount || 0),
render: (profile: ColumnProfile) => profile?.valuesCount || 0,
},
{
title: 'Test',