yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-08-26 01:46:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ui): pagination with search on service page (#18211)

Browse Source
This commit is contained in:
Chirag Madlani 2024-10-10 18:10:17 +05:30 committed by GitHub
parent 3dc9abef45
commit 6b830f98bb
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 24 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
openmetadata-ui/src/main/resources/ui/src/components/Settings/Services/Services.tsx
View File

@ -23,6 +23,7 @@ import { Link, useHistory } from 'react-router-dom';
import {
DISABLED,
getServiceDetailsPath,
INITIAL_PAGING_VALUE,
pagingObject,
} from '../../../constants/constants';
import { CONNECTORS_DOCS } from '../../../constants/docs.constants';
@ -194,15 +195,27 @@ const Services = ({ serviceName }: ServicesProps) => {
[searchIndex, serviceName, deleted]
);
const handleServicePageChange = ({
cursorType,
const handleServicePageChange = useCallback(
({ cursorType, currentPage }: PagingHandlerParams) => {
if (searchTerm) {
handlePageChange(currentPage);
getServiceDetails({
currentPage,
}: PagingHandlerParams) => {
if (cursorType) {
search: searchTerm,
limit: pageSize,
filters: serviceTypeFilter?.length
? `(${serviceTypeFilter
.map((type) => `serviceType:${type}`)
.join(' ')})`
: undefined,
});
} else if (cursorType) {
handlePageChange(currentPage);
getServiceDetails({ [cursorType]: paging[cursorType] });
}
handlePageChange(currentPage);
};
},
[getServiceDetails, searchTerm, serviceTypeFilter, paging, pageSize]
);
const addServicePermission = useMemo(
() =>
@ -414,6 +427,7 @@ const Services = ({ serviceName }: ServicesProps) => {
const handleServiceSearch = useCallback(
async (search: string) => {
handlePageChange(INITIAL_PAGING_VALUE);
setSearchTerm(search);
},
[getServiceDetails]
@ -511,6 +525,7 @@ const Services = ({ serviceName }: ServicesProps) => {
{showPagination && (
<NextPrevious
currentPage={currentPage}
isNumberBased={!isEmpty(searchTerm)}
pageSize={pageSize}
paging={paging}
pagingHandler={handleServicePageChange}