yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-11-10 15:59:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

cast to bigint to avoid overflow when summing (#8655)

Browse Source 
* cast to bigint to avoid overflow when summing

fixes #8430

* Update ingestion/src/metadata/orm_profiler/orm/functions/sum.py

Co-authored-by: Pere Miquel Brull <peremiquelbrull@gmail.com>
This commit is contained in:
Sam Firke 2022-11-11 00:33:38 -05:00 committed by GitHub
parent 86c3ae30f1
commit 6ba5f7ec90
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
ingestion/src/metadata/orm_profiler/orm/functions/sum.py
View File

@ -31,9 +31,9 @@ class SumFn(GenericFunction):
@compiles(SumFn) @compiles(SumFn)
def _(element, compiler, **kw): def _(element, compiler, **kw):
"""Handle case for empty table. If empty, clickhouse returns NaN""" """Cast to BIGINT to address overflow error from summing 32-bit int in most database dialects, #8430"""
proc = compiler.process(element.clauses, **kw) proc = compiler.process(element.clauses, **kw)
return f"SUM({proc})" return f"SUM(CAST({proc} AS BIGINT))"
@compiles(SumFn, Dialects.BigQuery) @compiles(SumFn, Dialects.BigQuery)
@ -41,3 +41,11 @@ def _(element, compiler, **kw):
"""Handle case where column type is INTEGER but SUM returns a NUMBER""" """Handle case where column type is INTEGER but SUM returns a NUMBER"""
proc = compiler.process(element.clauses, **kw) proc = compiler.process(element.clauses, **kw)
return f"SUM(CAST({proc} AS NUMERIC))" return f"SUM(CAST({proc} AS NUMERIC))"
@compiles(SumFn, Dialects.Snowflake)
@compiles(SumFn, Dialects.Vertica)
def _(element, compiler, **kw):
"""These database types have all int types as alias for int64 so don't need a cast"""
proc = compiler.process(element.clauses, **kw)
return f"SUM({proc})"