yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-08-22 07:58:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix #3929 UI : On Tab change reset entity thread data to avoid data duplication (#3930)

Browse Source
This commit is contained in:
Sachin Chaurasiya 2022-04-08 12:20:40 +05:30 committed by GitHub
parent b45ed2c8de
commit 6de2096f84
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
9 changed files with 12 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
openmetadata-ui/src/main/resources/ui/src/components/DashboardDetails/DashboardDetails.component.tsx
View File

@ -624,7 +624,7 @@ const DashboardDetails = ({
)}
{activeTab === 2 && (
<div
className="tw-py-4 tw-px-7 tw-grid tw-grid-cols-3 entity-feed-list tw-bg-body-main tw--mx-7 tw--my-4"
className="tw-py-4 tw-px-7 tw-grid tw-grid-cols-3 entity-feed-list tw--mx-7 tw--my-4"
id="activityfeed">
<div />
<ActivityFeedList
@ -634,7 +634,6 @@ const DashboardDetails = ({
deletePostHandler={deletePostHandler}
entityName={entityName}
feedList={entityThread}
isLoading={isentityThreadLoading}
postFeedHandler={postFeedHandler}
/>
<div />

2
openmetadata-ui/src/main/resources/ui/src/components/DatasetDetails/DatasetDetails.component.tsx
View File

@ -649,7 +649,7 @@ const DatasetDetails: React.FC<DatasetDetailsProps> = ({
)}
{activeTab === 2 && (
<div
className="tw-py-4 tw-px-7 tw-grid tw-grid-cols-3 entity-feed-list tw-bg-body-main tw--mx-7 tw--my-4"
className="tw-py-4 tw-px-7 tw-grid tw-grid-cols-3 entity-feed-list tw--mx-7 tw--my-4"
id="activityfeed">
<div />
<ActivityFeedList

3
openmetadata-ui/src/main/resources/ui/src/components/PipelineDetails/PipelineDetails.component.tsx
View File

@ -535,7 +535,7 @@ const PipelineDetails = ({
)}
{activeTab === 2 && (
<div
className="tw-py-4 tw-px-7 tw-grid tw-grid-cols-3 entity-feed-list tw-bg-body-main tw--mx-7 tw--my-4"
className="tw-py-4 tw-px-7 tw-grid tw-grid-cols-3 entity-feed-list tw--mx-7 tw--my-4"
id="activityfeed">
<div />
<ActivityFeedList
@ -545,7 +545,6 @@ const PipelineDetails = ({
deletePostHandler={deletePostHandler}
entityName={entityName}
feedList={entityThread}
isLoading={isentityThreadLoading}
postFeedHandler={postFeedHandler}
/>
<div />

3
openmetadata-ui/src/main/resources/ui/src/components/TopicDetails/TopicDetails.component.tsx
View File

@ -402,7 +402,7 @@ const TopicDetails: React.FC<TopicDetailsProps> = ({
)}
{activeTab === 2 && (
<div
className="tw-py-4 tw-px-7 tw-grid tw-grid-cols-3 entity-feed-list tw-bg-body-main tw--mx-7 tw--my-4 "
className="tw-py-4 tw-px-7 tw-grid tw-grid-cols-3 entity-feed-list tw--mx-7 tw--my-4 "
id="activityfeed">
<div />
<ActivityFeedList
@ -412,7 +412,6 @@ const TopicDetails: React.FC<TopicDetailsProps> = ({
deletePostHandler={deletePostHandler}
entityName={entityName}
feedList={entityThread}
isLoading={isentityThreadLoading}
postFeedHandler={postFeedHandler}
/>
<div />

1
openmetadata-ui/src/main/resources/ui/src/pages/DashboardDetailsPage/DashboardDetailsPage.component.tsx
View File

@ -743,6 +743,7 @@ const DashboardDetailsPage = () => {
if (dashboardDetailsTabs[activeTab - 1].path !== tab) {
setActiveTab(getCurrentDashboardTab(tab));
}
setEntityThread([]);
}, [tab]);
return (

1
openmetadata-ui/src/main/resources/ui/src/pages/DatasetDetailsPage/DatasetDetailsPage.component.tsx
View File

@ -463,6 +463,7 @@ const DatasetDetailsPage: FunctionComponent = () => {
if (datasetTableTabs[activeTab - 1].path !== tab) {
setActiveTab(getCurrentDatasetTab(tab));
}
setEntityThread([]);
}, [tab]);
useEffect(() => {

1
openmetadata-ui/src/main/resources/ui/src/pages/PipelineDetails/PipelineDetailsPage.component.tsx
View File

@ -669,6 +669,7 @@ const PipelineDetailsPage = () => {
if (pipelineDetailsTabs[activeTab - 1].path !== tab) {
setActiveTab(getCurrentPipelineTab(tab));
}
setEntityThread([]);
}, [tab]);
return (

2
openmetadata-ui/src/main/resources/ui/src/pages/TopicDetails/TopicDetailsPage.component.tsx
View File

@ -507,6 +507,8 @@ const TopicDetailsPage: FunctionComponent = () => {
}
if (TabSpecificField.ACTIVITY_FEED === tab) {
fetchActivityFeed();
} else {
setEntityThread([]);
}
}, [tab]);

4
openmetadata-ui/src/main/resources/ui/src/pages/database-details/index.tsx
View File

@ -597,6 +597,8 @@ const DatabaseDetails: FunctionComponent = () => {
useEffect(() => {
if (TabSpecificField.ACTIVITY_FEED === tab) {
fetchActivityFeed();
} else {
setEntityThread([]);
}
}, [tab]);
@ -786,7 +788,7 @@ const DatabaseDetails: FunctionComponent = () => {
)}
{activeTab === 2 && (
<div
className="tw-py-4 tw-px-7 tw-grid tw-grid-cols-3 entity-feed-list tw-bg-body-main tw--mx-7 tw--my-4"
className="tw-py-4 tw-px-7 tw-grid tw-grid-cols-3 entity-feed-list tw--mx-7 tw--my-4"
id="activityfeed">
<div />
<ActivityFeedList