From 6de2096f841f23eecb08119cc7b9527a6ee6782d Mon Sep 17 00:00:00 2001 From: Sachin Chaurasiya Date: Fri, 8 Apr 2022 12:20:40 +0530 Subject: [PATCH] Fix #3929 UI : On Tab change reset entity thread data to avoid data duplication (#3930) --- .../DashboardDetails/DashboardDetails.component.tsx | 3 +-- .../components/DatasetDetails/DatasetDetails.component.tsx | 2 +- .../components/PipelineDetails/PipelineDetails.component.tsx | 3 +-- .../ui/src/components/TopicDetails/TopicDetails.component.tsx | 3 +-- .../DashboardDetailsPage/DashboardDetailsPage.component.tsx | 1 + .../pages/DatasetDetailsPage/DatasetDetailsPage.component.tsx | 1 + .../pages/PipelineDetails/PipelineDetailsPage.component.tsx | 1 + .../ui/src/pages/TopicDetails/TopicDetailsPage.component.tsx | 2 ++ .../main/resources/ui/src/pages/database-details/index.tsx | 4 +++- 9 files changed, 12 insertions(+), 8 deletions(-) diff --git a/openmetadata-ui/src/main/resources/ui/src/components/DashboardDetails/DashboardDetails.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/DashboardDetails/DashboardDetails.component.tsx index d1e363b1e72..d5c1e1aab91 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/DashboardDetails/DashboardDetails.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/DashboardDetails/DashboardDetails.component.tsx @@ -624,7 +624,7 @@ const DashboardDetails = ({ )} {activeTab === 2 && (
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/DatasetDetails/DatasetDetails.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/DatasetDetails/DatasetDetails.component.tsx index 90c56b116ae..03aa4e05f10 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/DatasetDetails/DatasetDetails.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/DatasetDetails/DatasetDetails.component.tsx @@ -649,7 +649,7 @@ const DatasetDetails: React.FC = ({ )} {activeTab === 2 && (
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/TopicDetails/TopicDetails.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/TopicDetails/TopicDetails.component.tsx index 2a0088b1769..28562211868 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/TopicDetails/TopicDetails.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/TopicDetails/TopicDetails.component.tsx @@ -402,7 +402,7 @@ const TopicDetails: React.FC = ({ )} {activeTab === 2 && (
= ({ deletePostHandler={deletePostHandler} entityName={entityName} feedList={entityThread} - isLoading={isentityThreadLoading} postFeedHandler={postFeedHandler} />
diff --git a/openmetadata-ui/src/main/resources/ui/src/pages/DashboardDetailsPage/DashboardDetailsPage.component.tsx b/openmetadata-ui/src/main/resources/ui/src/pages/DashboardDetailsPage/DashboardDetailsPage.component.tsx index 86d0187ee10..f15a85ae733 100644 --- a/openmetadata-ui/src/main/resources/ui/src/pages/DashboardDetailsPage/DashboardDetailsPage.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/pages/DashboardDetailsPage/DashboardDetailsPage.component.tsx @@ -743,6 +743,7 @@ const DashboardDetailsPage = () => { if (dashboardDetailsTabs[activeTab - 1].path !== tab) { setActiveTab(getCurrentDashboardTab(tab)); } + setEntityThread([]); }, [tab]); return ( diff --git a/openmetadata-ui/src/main/resources/ui/src/pages/DatasetDetailsPage/DatasetDetailsPage.component.tsx b/openmetadata-ui/src/main/resources/ui/src/pages/DatasetDetailsPage/DatasetDetailsPage.component.tsx index 5c4c4303fbd..c9159b1b98d 100644 --- a/openmetadata-ui/src/main/resources/ui/src/pages/DatasetDetailsPage/DatasetDetailsPage.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/pages/DatasetDetailsPage/DatasetDetailsPage.component.tsx @@ -463,6 +463,7 @@ const DatasetDetailsPage: FunctionComponent = () => { if (datasetTableTabs[activeTab - 1].path !== tab) { setActiveTab(getCurrentDatasetTab(tab)); } + setEntityThread([]); }, [tab]); useEffect(() => { diff --git a/openmetadata-ui/src/main/resources/ui/src/pages/PipelineDetails/PipelineDetailsPage.component.tsx b/openmetadata-ui/src/main/resources/ui/src/pages/PipelineDetails/PipelineDetailsPage.component.tsx index 3f3e45cb940..d4f1a59eedf 100644 --- a/openmetadata-ui/src/main/resources/ui/src/pages/PipelineDetails/PipelineDetailsPage.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/pages/PipelineDetails/PipelineDetailsPage.component.tsx @@ -669,6 +669,7 @@ const PipelineDetailsPage = () => { if (pipelineDetailsTabs[activeTab - 1].path !== tab) { setActiveTab(getCurrentPipelineTab(tab)); } + setEntityThread([]); }, [tab]); return ( diff --git a/openmetadata-ui/src/main/resources/ui/src/pages/TopicDetails/TopicDetailsPage.component.tsx b/openmetadata-ui/src/main/resources/ui/src/pages/TopicDetails/TopicDetailsPage.component.tsx index 813dce0a99e..ffa5eeb664f 100644 --- a/openmetadata-ui/src/main/resources/ui/src/pages/TopicDetails/TopicDetailsPage.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/pages/TopicDetails/TopicDetailsPage.component.tsx @@ -507,6 +507,8 @@ const TopicDetailsPage: FunctionComponent = () => { } if (TabSpecificField.ACTIVITY_FEED === tab) { fetchActivityFeed(); + } else { + setEntityThread([]); } }, [tab]); diff --git a/openmetadata-ui/src/main/resources/ui/src/pages/database-details/index.tsx b/openmetadata-ui/src/main/resources/ui/src/pages/database-details/index.tsx index c4ff4198961..bafb6c26531 100644 --- a/openmetadata-ui/src/main/resources/ui/src/pages/database-details/index.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/pages/database-details/index.tsx @@ -597,6 +597,8 @@ const DatabaseDetails: FunctionComponent = () => { useEffect(() => { if (TabSpecificField.ACTIVITY_FEED === tab) { fetchActivityFeed(); + } else { + setEntityThread([]); } }, [tab]); @@ -786,7 +788,7 @@ const DatabaseDetails: FunctionComponent = () => { )} {activeTab === 2 && (