yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-09-02 13:43:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update formatting for duration in application configuration (#20987)

Browse Source 
* update formatting for duration in application configuration

* fix unit test case

* address pr comment
This commit is contained in:
Shrushti Polekar 2025-04-29 10:55:59 +05:30 committed by GitHub
parent d33e068692
commit 6e9c4a827d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
openmetadata-ui/src/main/resources/ui/src/components/Settings/Applications/AppRunsHistory/AppRunsHistory.component.tsx
View File

@ -45,7 +45,7 @@ import { getApplicationRuns } from '../../../../rest/applicationAPI';
import { getStatusTypeForApplication } from '../../../../utils/ApplicationUtils'; import { getStatusTypeForApplication } from '../../../../utils/ApplicationUtils';
import { import {
formatDateTime, formatDateTime,
formatDuration, formatDurationToHHMMSS,
getEpochMillisForPastDays, getEpochMillisForPastDays,
getIntervalInMilliseconds, getIntervalInMilliseconds,
} from '../../../../utils/date-time/DateTimeUtils'; } from '../../../../utils/date-time/DateTimeUtils';
@ -220,14 +220,14 @@ const AppRunsHistory = forwardRef(
key: 'executionTime', key: 'executionTime',
render: (_, record: AppRunRecordWithId) => { render: (_, record: AppRunRecordWithId) => {
if (isExternalApp && record.executionTime) { if (isExternalApp && record.executionTime) {
return formatDuration(record.executionTime); return formatDurationToHHMMSS(record.executionTime);
} }
if (record.startTime) { if (record.startTime) {
const endTime = record.endTime || Date.now(); // Use current time in epoch milliseconds if endTime is not present const endTime = record.endTime || Date.now(); // Use current time in epoch milliseconds if endTime is not present
const ms = getIntervalInMilliseconds(record.startTime, endTime); const ms = getIntervalInMilliseconds(record.startTime, endTime);
return formatDuration(ms); return formatDurationToHHMMSS(ms);
} else { } else {
return NO_DATA_PLACEHOLDER; return NO_DATA_PLACEHOLDER;
} }

4
openmetadata-ui/src/main/resources/ui/src/components/Settings/Applications/AppRunsHistory/AppRunsHistory.test.tsx
View File

@ -107,6 +107,10 @@ jest.mock('../../../../utils/date-time/DateTimeUtils', () => ({
getEpochMillisForPastDays: jest.fn().mockReturnValue('startDay'), getEpochMillisForPastDays: jest.fn().mockReturnValue('startDay'),
getIntervalInMilliseconds: jest.fn().mockReturnValue('interval'), getIntervalInMilliseconds: jest.fn().mockReturnValue('interval'),
formatDuration: jest.fn().mockReturnValue('formatDuration'), formatDuration: jest.fn().mockReturnValue('formatDuration'),
formatDurationToHHMMSS: jest.fn().mockImplementation((_ms) => {
// Return a consistent formatted duration for all cases
return '02:30:15';
}),
})); }));
jest.mock('../../../common/ErrorWithPlaceholder/ErrorPlaceHolder', () => jest.mock('../../../common/ErrorWithPlaceholder/ErrorPlaceHolder', () =>

3
openmetadata-ui/src/main/resources/ui/src/utils/date-time/DateTimeUtils.ts
View File

@ -309,6 +309,9 @@ export const formatDuration = (ms: number) => {
return pluralize(hours, 'hour'); return pluralize(hours, 'hour');
} }
}; };
export const formatDurationToHHMMSS = (ms: number) => {
return Duration.fromMillis(ms).toFormat('hh:mm:ss');
};
export const getStartOfDayInMillis = (timestamp: number) => export const getStartOfDayInMillis = (timestamp: number) =>
DateTime.fromMillis(timestamp).toUTC().startOf('day').toMillis(); DateTime.fromMillis(timestamp).toUTC().startOf('day').toMillis();