yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-09-19 05:52:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

MINOR: Redshift - better log for view with no schema binding (#20005)

Browse Source
This commit is contained in:
Mayur Singal 2025-03-04 15:26:20 +05:30 committed by GitHub
parent 2af5e30f4c
commit 6f0dbd01eb
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 32 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
ingestion/src/metadata/ingestion/source/database/redshift/metadata.py
View File

@ -84,6 +84,7 @@ from metadata.ingestion.source.database.redshift.utils import (
_get_pg_column_info, _get_pg_column_info,
_get_schema_column_info, _get_schema_column_info,
get_columns, get_columns,
get_redshift_columns,
get_table_comment, get_table_comment,
get_view_definition, get_view_definition,
) )
@ -109,18 +110,15 @@ STANDARD_TABLE_TYPES = {
"v": TableType.View, "v": TableType.View,
} }
# pylint: disable=protected-access
RedshiftDialectMixin._get_column_info = ( # pylint: disable=protected-access RedshiftDialectMixin._get_column_info = _get_column_info
_get_column_info RedshiftDialectMixin._get_schema_column_info = _get_schema_column_info
)
RedshiftDialectMixin._get_schema_column_info = ( # pylint: disable=protected-access
_get_schema_column_info
)
RedshiftDialectMixin.get_columns = get_columns RedshiftDialectMixin.get_columns = get_columns
PGDialect._get_column_info = _get_pg_column_info # pylint: disable=protected-access PGDialect._get_column_info = _get_pg_column_info
RedshiftDialect.get_all_table_comments = get_all_table_comments RedshiftDialect.get_all_table_comments = get_all_table_comments
RedshiftDialect.get_table_comment = get_table_comment RedshiftDialect.get_table_comment = get_table_comment
RedshiftDialect.get_view_definition = get_view_definition RedshiftDialect.get_view_definition = get_view_definition
RedshiftDialect._get_redshift_columns = get_redshift_columns
RedshiftDialect._get_all_relation_info = ( # pylint: disable=protected-access RedshiftDialect._get_all_relation_info = ( # pylint: disable=protected-access
_get_all_relation_info _get_all_relation_info
) )

26
ingestion/src/metadata/ingestion/source/database/redshift/utils.py
View File

@ -34,6 +34,7 @@ from metadata.ingestion.source.database.redshift.queries import (
REDSHIFT_TABLE_COMMENTS, REDSHIFT_TABLE_COMMENTS,
) )
from metadata.utils.execution_time_tracker import calculate_execution_time from metadata.utils.execution_time_tracker import calculate_execution_time
from metadata.utils.logger import ingestion_logger
from metadata.utils.sqlalchemy_utils import get_table_comment_wrapper from metadata.utils.sqlalchemy_utils import get_table_comment_wrapper
sa_version = Version(sa.__version__) sa_version = Version(sa.__version__)
@ -45,6 +46,9 @@ ischema_names.update({"binary varying": sqltypes.VARBINARY})
ischema_names.update(REDSHIFT_ISCHEMA_NAMES) ischema_names.update(REDSHIFT_ISCHEMA_NAMES)
logger = ingestion_logger()
# pylint: disable=protected-access # pylint: disable=protected-access
@calculate_execution_time() @calculate_execution_time()
@reflection.cache @reflection.cache
@ -414,3 +418,25 @@ def get_view_definition(self, connection, view_name, schema=None, **kw):
f"CREATE VIEW {view.schema}.{view.relname} AS {view_definition}" f"CREATE VIEW {view.schema}.{view.relname} AS {view_definition}"
) )
return view_definition return view_definition
def get_redshift_columns(self, connection, table_name, schema=None, **kw):
try:
info_cache = kw.get("info_cache")
all_schema_columns = self._get_schema_column_info(
connection,
schema,
info_cache=info_cache,
)
key = RelationKey(table_name, schema, connection)
if key not in all_schema_columns.keys():
key = key.unquoted()
return all_schema_columns[key]
except KeyError:
schema_name = schema or "public"
logger.error(
f"Fetching columns for table {schema_name}.{table_name} failed,"
" if this is a view with no schema binding, please make sure user has"
f' USAGE privilege on schema "{schema_name}"'
)
return []