yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-11-12 08:52:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed UI: Lineage exit full screen is not working for pipeline entity #8831 (#8832)

Browse Source
This commit is contained in:
Shailesh Parmar 2022-11-17 14:33:26 +05:30 committed by GitHub
parent 03d4011a17
commit 722d7ef473
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 8 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
openmetadata-ui/src/main/resources/ui/src/components/PipelineDetails/PipelineDetails.component.tsx
View File

@ -679,7 +679,7 @@ const PipelineDetails = ({
useEffect(() => { useEffect(() => {
switch (tab) { switch (tab) {
case PIPELINE_DETAILS_TABS.EntityLineage: case PIPELINE_DETAILS_TABS.Lineage:
!deleted && isEmpty(entityLineage) && getLineageData(); !deleted && isEmpty(entityLineage) && getLineageData();
break; break;
@ -955,10 +955,8 @@ const PipelineDetails = ({
</Tabs.TabPane> </Tabs.TabPane>
<Tabs.TabPane <Tabs.TabPane
key={PIPELINE_DETAILS_TABS.EntityLineage} key={PIPELINE_DETAILS_TABS.Lineage}
tab={ tab={<span data-testid="Lineage">{t('label.lineage')}</span>}>
<span data-testid="Lineage">{t('label.entity-lineage')}</span>
}>
<div className="h-full bg-white"> <div className="h-full bg-white">
<EntityLineageComponent <EntityLineageComponent
addLineageHandler={addLineageHandler} addLineageHandler={addLineageHandler}

4
openmetadata-ui/src/main/resources/ui/src/components/PipelineDetails/PipelineDetails.test.tsx
View File

@ -225,7 +225,7 @@ describe('Test PipelineDetails component', () => {
container, container,
'label.activity-feed-and-task-plural' 'label.activity-feed-and-task-plural'
); );
const lineageTab = await findByText(container, 'label.entity-lineage'); const lineageTab = await findByText(container, 'label.lineage');
const executionsTab = await findByText(container, 'label.executions'); const executionsTab = await findByText(container, 'label.executions');
const customPropertiesTab = await findByText( const customPropertiesTab = await findByText(
container, container,
@ -311,7 +311,7 @@ describe('Test PipelineDetails component', () => {
wrapper: MemoryRouter, wrapper: MemoryRouter,
} }
); );
const activityFeedTab = await findByText(container, 'label.entity-lineage'); const activityFeedTab = await findByText(container, 'label.lineage');
await act(async () => { await act(async () => {
fireEvent.click(activityFeedTab); fireEvent.click(activityFeedTab);

2
openmetadata-ui/src/main/resources/ui/src/constants/pipeline.constants.ts
View File

@ -15,6 +15,6 @@ export enum PIPELINE_DETAILS_TABS {
Tasks = 'tasks', Tasks = 'tasks',
ActivityFeedsAndTasks = 'activity-feeds-tasks', ActivityFeedsAndTasks = 'activity-feeds-tasks',
Executions = 'executions', Executions = 'executions',
EntityLineage = 'entity-lineage', Lineage = 'lineage',
CustomProperties = 'custom-properties', CustomProperties = 'custom-properties',
} }

2
openmetadata-ui/src/main/resources/ui/src/locale/languages/en-us.json
View File

@ -232,7 +232,7 @@
"tasks": "Tasks", "tasks": "Tasks",
"activity-feed-and-task-plural": "Activity Feeds & tasks", "activity-feed-and-task-plural": "Activity Feeds & tasks",
"executions": "Executions", "executions": "Executions",
"entity-lineage": "Entity Lineage", "lineage": "Lineage",
"custom-properties": "Custom Properties", "custom-properties": "Custom Properties",
"dag-view": "DAG view", "dag-view": "DAG view",
"read-more": "read more", "read-more": "read more",

5
openmetadata-ui/src/main/resources/ui/src/pages/LineagePage/LineagePage.tsx
View File

@ -203,10 +203,7 @@ const LineagePage = () => {
const pipelineRes = await getPipelineByFqn(entityFQN, ''); const pipelineRes = await getPipelineByFqn(entityFQN, '');
updateBreadcrumb( updateBreadcrumb(
pipelineRes, pipelineRes,
getPipelineDetailsPath( getPipelineDetailsPath(entityFQN, PIPELINE_DETAILS_TABS.Lineage)
entityFQN,
PIPELINE_DETAILS_TABS.EntityLineage
)
); );
} }