yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-10-27 00:31:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

#23774 : fix the bulk import column name contains dot in it (#23791)

Browse Source 
* fix the bulk import column name contains dot in it

* fix for name field

* fix the failing test

* fix the test failure
This commit is contained in:
Ashish Gupta 2025-10-13 17:43:21 +05:30 committed by GitHub
parent 8c02775b3b
commit 73b4f77e2e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/BulkImport.spec.ts
View File

@ -30,6 +30,7 @@ import {
} from '../../utils/common';
import {
createColumnRowDetails,
createColumnRowDetailsWithEncloseDot,
createCustomPropertiesForEntity,
createDatabaseRowDetails,
createDatabaseSchemaRowDetails,
@ -104,7 +105,7 @@ const columnDetails1 = {
};
const columnDetails2 = {
...createColumnRowDetails(),
...createColumnRowDetailsWithEncloseDot(),
glossary: glossaryDetails,
};
@ -712,7 +713,7 @@ test.describe('Bulk Import Export', () => {
await fillRecursiveColumnDetails(
{
...columnDetails2,
fullyQualifiedName: `${dbSchemaEntity.entityResponseData.fullyQualifiedName}.${tableDetails2.name}.${columnDetails2.name}`,
fullyQualifiedName: `${dbSchemaEntity.entityResponseData.fullyQualifiedName}.${tableDetails2.name}."${columnDetails2.name}"`,
},
page
);
@ -841,7 +842,6 @@ test.describe('Bulk Import Export', () => {
}
);
await tableEntity.delete(apiContext);
await afterAction();
});

7
openmetadata-ui/src/main/resources/ui/playwright/utils/importUtils.ts
View File

@ -505,6 +505,13 @@ export const createColumnRowDetails = () => {
};
};
export const createColumnRowDetailsWithEncloseDot = () => {
return {
...createColumnRowDetails(),
name: `"playwright.column ${uuid()}"`,
};
};
export const createStoredProcedureRowDetails = () => {
return {
name: `playwright,storedprocedure,${uuid()}`,

2
openmetadata-ui/src/main/resources/ui/src/utils/CSV/CSVUtilsClassBase.tsx
View File

@ -55,6 +55,8 @@ class CSVUtilsClassBase {
'column.tags',
'column.glossaryTerms',
'storedProcedure.code',
'column.name*',
'name*',
];
}