From 74e5404fe00ecb512c9dc7f25d01ad13fa057b1c Mon Sep 17 00:00:00 2001
From: Onkar Ravgan <onkar.10r@gmail.com>
Date: Mon, 16 May 2022 15:56:57 +0530
Subject: [PATCH] removed username field from bigquery (#4967)

Co-authored-by: Onkar Ravgan <onkarravgan@Onkars-MacBook-Pro.local>
---
 .../services/connections/database/bigQueryConnection.json    | 5 -----
 .../resources/services/DatabaseServiceResourceTest.java      | 1 -
 .../test/java/org/openmetadata/catalog/util/TestUtils.java   | 3 +--
 3 files changed, 1 insertion(+), 8 deletions(-)

diff --git a/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/bigQueryConnection.json b/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/bigQueryConnection.json
index b8706112bcb..8c8fcc6695a 100644
--- a/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/bigQueryConnection.json
+++ b/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/bigQueryConnection.json
@@ -38,11 +38,6 @@
       "type": "string",
       "default": "bigquery.googleapis.com"
     },
-    "username": {
-      "title": "Username",
-      "description": "Username to connect to Bigquery. This user should have privileges to read all the metadata in Bigquery.",
-      "type": "string"
-    },
     "projectId": {
       "title": "Project ID",
       "description": "BigQuery project ID. Only required if using credentials path instead of values.",
diff --git a/catalog-rest-service/src/test/java/org/openmetadata/catalog/resources/services/DatabaseServiceResourceTest.java b/catalog-rest-service/src/test/java/org/openmetadata/catalog/resources/services/DatabaseServiceResourceTest.java
index 518bbf3d935..eaecd135e3c 100644
--- a/catalog-rest-service/src/test/java/org/openmetadata/catalog/resources/services/DatabaseServiceResourceTest.java
+++ b/catalog-rest-service/src/test/java/org/openmetadata/catalog/resources/services/DatabaseServiceResourceTest.java
@@ -376,7 +376,6 @@ public class DatabaseServiceResourceTest extends EntityResourceTest<DatabaseServ
       BigQueryConnection expectedBigQueryConnection, BigQueryConnection actualBigQueryConnection) {
     assertEquals(expectedBigQueryConnection.getHostPort(), actualBigQueryConnection.getHostPort());
     assertEquals(expectedBigQueryConnection.getCredentials(), actualBigQueryConnection.getCredentials());
-    assertEquals(expectedBigQueryConnection.getUsername(), actualBigQueryConnection.getUsername());
     assertEquals(expectedBigQueryConnection.getScheme(), actualBigQueryConnection.getScheme());
     assertEquals(expectedBigQueryConnection.getDatabase(), actualBigQueryConnection.getDatabase());
     assertEquals(
diff --git a/catalog-rest-service/src/test/java/org/openmetadata/catalog/util/TestUtils.java b/catalog-rest-service/src/test/java/org/openmetadata/catalog/util/TestUtils.java
index b7a51a95f34..4e6537cfe0a 100644
--- a/catalog-rest-service/src/test/java/org/openmetadata/catalog/util/TestUtils.java
+++ b/catalog-rest-service/src/test/java/org/openmetadata/catalog/util/TestUtils.java
@@ -104,8 +104,7 @@ public final class TestUtils {
             .withConfig(
                 new RedshiftConnection().withHostPort("localhost:5002").withUsername("test").withPassword("test"));
     BIGQUERY_DATABASE_CONNECTION =
-        new DatabaseConnection()
-            .withConfig(new BigQueryConnection().withHostPort("localhost:1000").withUsername("bigquery"));
+        new DatabaseConnection().withConfig(new BigQueryConnection().withHostPort("localhost:1000"));
     SNOWFLAKE_DATABASE_CONNECTION =
         new DatabaseConnection()
             .withConfig(new SnowflakeConnection().withUsername("snowflake").withPassword("snowflake"));