yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-09-26 09:22:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

removed username field from bigquery (#4967)

Browse Source 
Co-authored-by: Onkar Ravgan <onkarravgan@Onkars-MacBook-Pro.local>
This commit is contained in:
Onkar Ravgan 2022-05-16 15:56:57 +05:30 committed by GitHub
parent f3c8a67e6b
commit 74e5404fe0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 1 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/bigQueryConnection.json
View File

@ -38,11 +38,6 @@
"type": "string", "type": "string",
"default": "bigquery.googleapis.com" "default": "bigquery.googleapis.com"
}, },
"username": {
"title": "Username",
"description": "Username to connect to Bigquery. This user should have privileges to read all the metadata in Bigquery.",
"type": "string"
},
"projectId": { "projectId": {
"title": "Project ID", "title": "Project ID",
"description": "BigQuery project ID. Only required if using credentials path instead of values.", "description": "BigQuery project ID. Only required if using credentials path instead of values.",

1
catalog-rest-service/src/test/java/org/openmetadata/catalog/resources/services/DatabaseServiceResourceTest.java
View File

@ -376,7 +376,6 @@ public class DatabaseServiceResourceTest extends EntityResourceTest<DatabaseServ
BigQueryConnection expectedBigQueryConnection, BigQueryConnection actualBigQueryConnection) { BigQueryConnection expectedBigQueryConnection, BigQueryConnection actualBigQueryConnection) {
assertEquals(expectedBigQueryConnection.getHostPort(), actualBigQueryConnection.getHostPort()); assertEquals(expectedBigQueryConnection.getHostPort(), actualBigQueryConnection.getHostPort());
assertEquals(expectedBigQueryConnection.getCredentials(), actualBigQueryConnection.getCredentials()); assertEquals(expectedBigQueryConnection.getCredentials(), actualBigQueryConnection.getCredentials());
assertEquals(expectedBigQueryConnection.getUsername(), actualBigQueryConnection.getUsername());
assertEquals(expectedBigQueryConnection.getScheme(), actualBigQueryConnection.getScheme()); assertEquals(expectedBigQueryConnection.getScheme(), actualBigQueryConnection.getScheme());
assertEquals(expectedBigQueryConnection.getDatabase(), actualBigQueryConnection.getDatabase()); assertEquals(expectedBigQueryConnection.getDatabase(), actualBigQueryConnection.getDatabase());
assertEquals( assertEquals(

3
catalog-rest-service/src/test/java/org/openmetadata/catalog/util/TestUtils.java
View File

@ -104,8 +104,7 @@ public final class TestUtils {
.withConfig( .withConfig(
new RedshiftConnection().withHostPort("localhost:5002").withUsername("test").withPassword("test")); new RedshiftConnection().withHostPort("localhost:5002").withUsername("test").withPassword("test"));
BIGQUERY_DATABASE_CONNECTION = BIGQUERY_DATABASE_CONNECTION =
new DatabaseConnection() new DatabaseConnection().withConfig(new BigQueryConnection().withHostPort("localhost:1000"));
.withConfig(new BigQueryConnection().withHostPort("localhost:1000").withUsername("bigquery"));
SNOWFLAKE_DATABASE_CONNECTION = SNOWFLAKE_DATABASE_CONNECTION =
new DatabaseConnection() new DatabaseConnection()
.withConfig(new SnowflakeConnection().withUsername("snowflake").withPassword("snowflake")); .withConfig(new SnowflakeConnection().withUsername("snowflake").withPassword("snowflake"));