yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-10-31 18:48:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Minor: Remove trailing slash from FivetranClient base URL (#17528)

Browse Source 
* fix: Remove trailing slash from FivetranClient base URL

* chore: use a method created for removing trailing slash
This commit is contained in:
Ayush Shah 2024-08-21 18:32:16 +05:30 committed by GitHub
parent c08b83f41d
commit 7ada44a315
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ingestion/src/metadata/ingestion/source/dashboard/metabase/client.py
View File

@ -33,6 +33,7 @@ from metadata.ingestion.source.dashboard.metabase.models import (
MetabaseUser, MetabaseUser,
) )
from metadata.utils.constants import AUTHORIZATION_HEADER, NO_ACCESS_TOKEN from metadata.utils.constants import AUTHORIZATION_HEADER, NO_ACCESS_TOKEN
from metadata.utils.helpers import clean_uri
from metadata.utils.logger import ingestion_logger from metadata.utils.logger import ingestion_logger
logger = ingestion_logger() logger = ingestion_logger()
@ -78,7 +79,7 @@ class MetabaseClient:
self.config = config self.config = config
session_token = self._get_metabase_session() session_token = self._get_metabase_session()
client_config: ClientConfig = ClientConfig( client_config: ClientConfig = ClientConfig(
base_url=str(self.config.hostPort)[:-1], # remove trailing slash base_url=clean_uri(str(self.config.hostPort)),
api_version=API_VERSION, api_version=API_VERSION,
auth_header=AUTHORIZATION_HEADER, auth_header=AUTHORIZATION_HEADER,
auth_token=lambda: (NO_ACCESS_TOKEN, 0), auth_token=lambda: (NO_ACCESS_TOKEN, 0),

3
ingestion/src/metadata/ingestion/source/pipeline/fivetran/client.py
View File

@ -20,6 +20,7 @@ from metadata.generated.schema.entity.services.connections.pipeline.fivetranConn
FivetranConnection, FivetranConnection,
) )
from metadata.ingestion.ometa.client import REST, ClientConfig from metadata.ingestion.ometa.client import REST, ClientConfig
from metadata.utils.helpers import clean_uri
class FivetranClient: class FivetranClient:
@ -36,7 +37,7 @@ class FivetranClient:
) )
client_config: ClientConfig = ClientConfig( client_config: ClientConfig = ClientConfig(
base_url=str(self.config.hostPort), base_url=clean_uri(str(self.config.hostPort)),
api_version="v1", api_version="v1",
auth_header="Authorization", auth_header="Authorization",
auth_token=lambda: (api_token[2:-1], 0), auth_token=lambda: (api_token[2:-1], 0),