From 7caac4616f0d0076db588a856c743f104f40d403 Mon Sep 17 00:00:00 2001 From: Mayur Singal <39544459+ulixius9@users.noreply.github.com> Date: Wed, 31 Aug 2022 10:22:37 +0530 Subject: [PATCH] Fix #6645: Remove required fields from mssql (#7065) --- .../entity/services/connections/database/mssqlConnection.json | 3 +-- ingestion/src/metadata/utils/source_connections.py | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/mssqlConnection.json b/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/mssqlConnection.json index a004bc8b0b3..bdcd12fc6c0 100644 --- a/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/mssqlConnection.json +++ b/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/mssqlConnection.json @@ -82,6 +82,5 @@ "$ref": "../connectionBasicType.json#/definitions/supportsUsageExtraction" } }, - "additionalProperties": false, - "required": ["hostPort", "username"] + "additionalProperties": false } diff --git a/ingestion/src/metadata/utils/source_connections.py b/ingestion/src/metadata/utils/source_connections.py index 471f8a154a5..19ded2c77ed 100644 --- a/ingestion/src/metadata/utils/source_connections.py +++ b/ingestion/src/metadata/utils/source_connections.py @@ -147,7 +147,7 @@ def _(connection): @get_connection_url.register def _(connection: MssqlConnection): - if connection.scheme.value == connection.scheme.mssql_pyodbc: + if connection.scheme.value == connection.scheme.mssql_pyodbc.value: return f"{connection.scheme.value}://{connection.uriString}" return get_connection_url_common(connection)