yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-11-02 19:48:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixes: ISSUE-23316: change remove default persona icon (#23348)

Browse Source 
* ISSUE-23316: icon used now CloseCircleOutlined

* ISSUE-23316: Using svg from projects assets

* fix the comments

* revert the unwanted changes

---------

Co-authored-by: Ashish Gupta <ashish@getcollate.io>
This commit is contained in:
Uwais 2025-10-09 07:09:09 +01:00 committed by GitHub
parent 6cf4d94285
commit 7f5bda7d1a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
openmetadata-ui/src/main/resources/ui/src/pages/Persona/PersonaDetailsPage/PersonaDetailsPage.tsx
View File

@ -10,7 +10,6 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
import { CheckCircleOutlined, XOutlined } from '@ant-design/icons';
import Icon from '@ant-design/icons/lib/components/Icon';
import { Button, Col, Modal, Row, Tabs, Typography } from 'antd';
import { ItemType } from 'antd/lib/menu/hooks/useItems';
@ -20,6 +19,8 @@ import { isUndefined } from 'lodash';
import { useCallback, useEffect, useMemo, useState } from 'react';
import { useTranslation } from 'react-i18next';
import { useNavigate } from 'react-router-dom';
import { ReactComponent as CheckCircleOutlined } from '../../../assets/svg/complete.svg';
import { ReactComponent as CloseCircleOutlined } from '../../../assets/svg/ic-close-circle.svg';
import { ReactComponent as IconPersona } from '../../../assets/svg/ic-personas.svg';
import DescriptionV1 from '../../../components/common/EntityDescription/DescriptionV1';
import ManageButton from '../../../components/common/EntityPageInfos/ManageButton/ManageButton';
@ -277,7 +278,7 @@ export const PersonaDetailsPage = () => {
? t('message.remove-default-persona-description')
: t('message.set-default-persona-menu-description')
}
icon={(isDefault ? XOutlined : CheckCircleOutlined) as SvgComponent}
icon={isDefault ? CloseCircleOutlined : CheckCircleOutlined}
id={isDefault ? 'remove-default-button' : 'set-as-default-button'}
name={
isDefault ? t('label.remove-default') : t('label.set-as-default')
@ -287,7 +288,7 @@ export const PersonaDetailsPage = () => {
onClick: handleDefaultActionClick,
},
] as ItemType[];
}, [personaDetails?.default, handleDefaultActionClick, t]);
}, [personaDetails?.default, handleDefaultActionClick]);
if (isLoading) {
return <Loader />;