From 7f5bda7d1a3fc4b5af6959cf8deb733b180422fe Mon Sep 17 00:00:00 2001
From: Uwais <64285005+ukush@users.noreply.github.com>
Date: Thu, 9 Oct 2025 07:09:09 +0100
Subject: [PATCH] Fixes: ISSUE-23316: change remove default persona icon
 (#23348)

* ISSUE-23316: icon used now CloseCircleOutlined

* ISSUE-23316: Using svg from projects assets

* fix the comments

* revert the unwanted changes

---------

Co-authored-by: Ashish Gupta <ashish@getcollate.io>
---
 .../Persona/PersonaDetailsPage/PersonaDetailsPage.tsx      | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/openmetadata-ui/src/main/resources/ui/src/pages/Persona/PersonaDetailsPage/PersonaDetailsPage.tsx b/openmetadata-ui/src/main/resources/ui/src/pages/Persona/PersonaDetailsPage/PersonaDetailsPage.tsx
index 14079849306..43230fb24db 100644
--- a/openmetadata-ui/src/main/resources/ui/src/pages/Persona/PersonaDetailsPage/PersonaDetailsPage.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/pages/Persona/PersonaDetailsPage/PersonaDetailsPage.tsx
@@ -10,7 +10,6 @@
  *  See the License for the specific language governing permissions and
  *  limitations under the License.
  */
-import { CheckCircleOutlined, XOutlined } from '@ant-design/icons';
 import Icon from '@ant-design/icons/lib/components/Icon';
 import { Button, Col, Modal, Row, Tabs, Typography } from 'antd';
 import { ItemType } from 'antd/lib/menu/hooks/useItems';
@@ -20,6 +19,8 @@ import { isUndefined } from 'lodash';
 import { useCallback, useEffect, useMemo, useState } from 'react';
 import { useTranslation } from 'react-i18next';
 import { useNavigate } from 'react-router-dom';
+import { ReactComponent as CheckCircleOutlined } from '../../../assets/svg/complete.svg';
+import { ReactComponent as CloseCircleOutlined } from '../../../assets/svg/ic-close-circle.svg';
 import { ReactComponent as IconPersona } from '../../../assets/svg/ic-personas.svg';
 import DescriptionV1 from '../../../components/common/EntityDescription/DescriptionV1';
 import ManageButton from '../../../components/common/EntityPageInfos/ManageButton/ManageButton';
@@ -277,7 +278,7 @@ export const PersonaDetailsPage = () => {
                 ? t('message.remove-default-persona-description')
                 : t('message.set-default-persona-menu-description')
             }
-            icon={(isDefault ? XOutlined : CheckCircleOutlined) as SvgComponent}
+            icon={isDefault ? CloseCircleOutlined : CheckCircleOutlined}
             id={isDefault ? 'remove-default-button' : 'set-as-default-button'}
             name={
               isDefault ? t('label.remove-default') : t('label.set-as-default')
@@ -287,7 +288,7 @@ export const PersonaDetailsPage = () => {
         onClick: handleDefaultActionClick,
       },
     ] as ItemType[];
-  }, [personaDetails?.default, handleDefaultActionClick, t]);
+  }, [personaDetails?.default, handleDefaultActionClick]);
 
   if (isLoading) {
     return <Loader />;