diff --git a/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/TaskFeedCard/TaskFeedCardNew.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/TaskFeedCard/TaskFeedCardNew.component.tsx index 4b866725f00..6aae8280d66 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/TaskFeedCard/TaskFeedCardNew.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/TaskFeedCard/TaskFeedCardNew.component.tsx @@ -18,7 +18,6 @@ import { isEmpty, isEqual, isUndefined, lowerCase } from 'lodash'; import React, { useCallback, useMemo } from 'react'; import { useTranslation } from 'react-i18next'; import { useHistory } from 'react-router-dom'; -import { ReactComponent as AssigneesIcon } from '../../../assets/svg/ic-assignees.svg'; import { ReactComponent as TaskCloseIcon } from '../../../assets/svg/ic-close-task.svg'; import { ReactComponent as TaskOpenIcon } from '../../../assets/svg/ic-open-task.svg'; import { ReactComponent as ReplyIcon } from '../../../assets/svg/ic-reply-2.svg'; @@ -359,8 +358,8 @@ const TaskFeedCard = ({ ? 'task-card-assignee' : '' }`}> - (false); const [recentComment, setRecentComment] = useState(''); + const shouldEditAssignee = + (isCreator || hasEditAccess) && !isTaskClosed && owners.length === 0; const onSave = () => { postFeed(comment, taskThread?.id ?? '') .catch(() => { @@ -838,6 +839,12 @@ export const TaskTabNew = ({ ); setUsersList(filterData); } catch (error) { + showErrorToast( + error as AxiosError, + t('server.entity-fetch-error', { + entity: t('label.assignee'), + }) + ); setUsersList([]); } }, []); @@ -858,6 +865,10 @@ export const TaskTabNew = ({ setTaskAction(latestAction); }, [latestAction]); + const handleEditClick = () => { + setIsEditAssignee(true); + }; + const taskHeader = isTaskTestCaseResult ? ( ) : ( @@ -937,13 +948,13 @@ export const TaskTabNew = ({ ) : ( <> - + {t('label.assignee-plural')} - + {taskThread?.task?.assignees?.length === 1 ? (
) : ( )} - {(isCreator || hasEditAccess) && - !isTaskClosed && - owners.length === 0 ? ( -
+ + + ); + }, [ + showMultipleTypeTeam, + showMultipleTypeVisibleUser, + showMultipleTypeRemainingUser, + avatarSize, + className, + isCompactView, + ownerDisplayName, + hasPermission, + onEditClick, + isDropdownOpen, + owners, + setIsDropdownOpen, + setShowAllOwners, + showAllOwners, + ]); const ownerElements = useMemo(() => { const hasOwners = owners && owners.length > 0; - // Show all owners when "more" is clicked, regardless of view mode const visibleOwners = showAllOwners ? owners @@ -118,19 +204,23 @@ export const OwnerLabel = ({ ); } + if (isAssignee) { + return renderMultipleType; + } + return (
{ownerElementsNonCompactView} -
+
void; } diff --git a/openmetadata-ui/src/main/resources/ui/src/components/common/OwnerLabel/owner-label.less b/openmetadata-ui/src/main/resources/ui/src/components/common/OwnerLabel/owner-label.less index a69ad0a467f..c0dd8f423ba 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/common/OwnerLabel/owner-label.less +++ b/openmetadata-ui/src/main/resources/ui/src/components/common/OwnerLabel/owner-label.less @@ -127,7 +127,3 @@ } } } - -.owner-label-container { - max-width: 148px; -}