yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-11-11 08:23:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Webhooks test fix (#4528)

Browse Source 
* Webhooks fix

* Selenium failure fix & chromedriver version update

* downgrading chromedriver

* webhooks addDuplicateWebhook test fix

* webhooks test fix for addduplicatewebhook
This commit is contained in:
kshinde2512 2022-04-28 13:19:32 +05:30 committed by GitHub
parent 7d9aaed74a
commit 80ec53e1d1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 34 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/objectRepository/Common.java
View File

@ -112,6 +112,10 @@ public class Common {
return By.xpath("//*[text()[contains(.,'" + matchingText + "')]] "); return By.xpath("//*[text()[contains(.,'" + matchingText + "')]] ");
} }
public By textEquals(String matchingText) {
return By.xpath("//*[text()='" + matchingText + "']");
}
public By serviceType(String serviceType) { public By serviceType(String serviceType) {
return By.cssSelector("[data-testid='" + serviceType + "']"); return By.cssSelector("[data-testid='" + serviceType + "']");
} }

41
openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/Webhooks/WebhooksPageTest.java
View File

@ -13,6 +13,7 @@ import org.openmetadata.catalog.selenium.events.Events;
import org.openmetadata.catalog.selenium.objectRepository.Common; import org.openmetadata.catalog.selenium.objectRepository.Common;
import org.openmetadata.catalog.selenium.objectRepository.Webhooks; import org.openmetadata.catalog.selenium.objectRepository.Webhooks;
import org.openmetadata.catalog.selenium.properties.Property; import org.openmetadata.catalog.selenium.properties.Property;
import org.openqa.selenium.JavascriptExecutor;
import org.openqa.selenium.WebDriver; import org.openqa.selenium.WebDriver;
import org.openqa.selenium.WebElement; import org.openqa.selenium.WebElement;
import org.openqa.selenium.chrome.ChromeDriver; import org.openqa.selenium.chrome.ChromeDriver;
@ -31,6 +32,7 @@ class WebhooksPageTest {
static Webhooks webhooks; static Webhooks webhooks;
static String url = Property.getInstance().getURL(); static String url = Property.getInstance().getURL();
static Faker faker = new Faker(); static Faker faker = new Faker();
static String name = faker.name().firstName();
static Actions actions; static Actions actions;
static WebDriverWait wait; static WebDriverWait wait;
Integer waitTime = Property.getInstance().getSleepTime(); Integer waitTime = Property.getInstance().getSleepTime();
@ -64,7 +66,6 @@ class WebhooksPageTest {
@Test @Test
@Order(2) @Order(2)
void addWebHook() throws InterruptedException { void addWebHook() throws InterruptedException {
String name = faker.name().name();
openWebHookPage(); openWebHookPage();
Thread.sleep(waitTime); Thread.sleep(waitTime);
Events.click(webDriver, webhooks.addWebhook()); Events.click(webDriver, webhooks.addWebhook());
@ -72,6 +73,8 @@ class WebhooksPageTest {
Events.click(webDriver, webhooks.descriptionBox()); Events.click(webDriver, webhooks.descriptionBox());
Events.sendKeys(webDriver, webhooks.focusedDescriptionBox(), faker.address().toString()); Events.sendKeys(webDriver, webhooks.focusedDescriptionBox(), faker.address().toString());
Events.sendKeys(webDriver, webhooks.endpoint(), "https://www.example.com"); Events.sendKeys(webDriver, webhooks.endpoint(), "https://www.example.com");
((JavascriptExecutor) webDriver)
.executeScript("arguments[0].scrollIntoView(true);", webDriver.findElement(common.saveWebhook()));
Events.click(webDriver, webhooks.checkbox()); Events.click(webDriver, webhooks.checkbox());
Events.click(webDriver, webhooks.entityCreatedMenu()); Events.click(webDriver, webhooks.entityCreatedMenu());
Events.click(webDriver, webhooks.allEntities()); Events.click(webDriver, webhooks.allEntities());
@ -87,22 +90,20 @@ class WebhooksPageTest {
@Test @Test
@Order(3) @Order(3)
void checkDuplicateWebhookName() throws InterruptedException { void checkDuplicateWebhookName() throws InterruptedException {
String name = faker.name().name();
webDriver.manage().timeouts().implicitlyWait(Duration.ofSeconds(10));
openWebHookPage(); openWebHookPage();
for (int i = 0; i < 2; i++) { Events.click(webDriver, webhooks.addWebhook());
Events.click(webDriver, webhooks.addWebhook()); Events.sendKeys(webDriver, webhooks.name(), name);
Events.sendKeys(webDriver, webhooks.name(), name); Events.click(webDriver, webhooks.descriptionBox());
Events.click(webDriver, webhooks.descriptionBox()); Events.sendKeys(webDriver, webhooks.focusedDescriptionBox(), "test");
Events.sendKeys(webDriver, webhooks.focusedDescriptionBox(), "test"); Events.sendKeys(webDriver, webhooks.endpoint(), "https://www.example.com");
Events.sendKeys(webDriver, webhooks.endpoint(), "https://www.example.com"); ((JavascriptExecutor) webDriver)
Events.click(webDriver, webhooks.checkbox()); .executeScript("arguments[0].scrollIntoView(true);", webDriver.findElement(common.saveWebhook()));
Events.click(webDriver, webhooks.entityCreatedMenu()); Events.click(webDriver, webhooks.checkbox());
Events.click(webDriver, webhooks.allEntities()); Events.click(webDriver, webhooks.entityCreatedMenu());
Events.click(webDriver, webhooks.clickToCloseDropdown()); Events.click(webDriver, webhooks.allEntities());
Events.click(webDriver, common.saveWebhook()); Events.click(webDriver, webhooks.clickToCloseDropdown());
Thread.sleep(waitTime); Events.click(webDriver, common.saveWebhook());
} Thread.sleep(waitTime);
WebElement errorMessage = webDriver.findElement(webhooks.toast()); WebElement errorMessage = webDriver.findElement(webhooks.toast());
Assert.assertTrue(errorMessage.isDisplayed()); Assert.assertTrue(errorMessage.isDisplayed());
Assert.assertEquals(errorMessage.getText(), "Entity already exists"); Assert.assertEquals(errorMessage.getText(), "Entity already exists");
@ -117,7 +118,9 @@ class WebhooksPageTest {
Events.sendKeys(webDriver, webhooks.name(), ""); Events.sendKeys(webDriver, webhooks.name(), "");
Events.click(webDriver, webhooks.descriptionBox()); Events.click(webDriver, webhooks.descriptionBox());
Events.sendKeys(webDriver, webhooks.focusedDescriptionBox(), "test"); Events.sendKeys(webDriver, webhooks.focusedDescriptionBox(), "test");
Events.sendKeys(webDriver, webhooks.endpoint(), "test.com"); Events.sendKeys(webDriver, webhooks.endpoint(), "http://www.test.com");
((JavascriptExecutor) webDriver)
.executeScript("arguments[0].scrollIntoView(true);", webDriver.findElement(common.saveWebhook()));
Events.click(webDriver, webhooks.checkbox()); Events.click(webDriver, webhooks.checkbox());
Thread.sleep(waitTime); Thread.sleep(waitTime);
Events.click(webDriver, webhooks.entityCreatedMenu()); Events.click(webDriver, webhooks.entityCreatedMenu());
@ -139,6 +142,8 @@ class WebhooksPageTest {
Events.click(webDriver, webhooks.descriptionBox()); Events.click(webDriver, webhooks.descriptionBox());
Events.sendKeys(webDriver, webhooks.focusedDescriptionBox(), "test"); Events.sendKeys(webDriver, webhooks.focusedDescriptionBox(), "test");
Events.sendKeys(webDriver, webhooks.endpoint(), ""); Events.sendKeys(webDriver, webhooks.endpoint(), "");
((JavascriptExecutor) webDriver)
.executeScript("arguments[0].scrollIntoView(true);", webDriver.findElement(common.saveWebhook()));
Events.click(webDriver, webhooks.checkbox()); Events.click(webDriver, webhooks.checkbox());
Events.click(webDriver, webhooks.entityCreatedMenu()); Events.click(webDriver, webhooks.entityCreatedMenu());
Events.click(webDriver, webhooks.allEntities()); Events.click(webDriver, webhooks.allEntities());
@ -159,6 +164,8 @@ class WebhooksPageTest {
Events.click(webDriver, webhooks.descriptionBox()); Events.click(webDriver, webhooks.descriptionBox());
Events.sendKeys(webDriver, webhooks.focusedDescriptionBox(), "test"); Events.sendKeys(webDriver, webhooks.focusedDescriptionBox(), "test");
Events.sendKeys(webDriver, webhooks.endpoint(), "https://www.test.com"); Events.sendKeys(webDriver, webhooks.endpoint(), "https://www.test.com");
((JavascriptExecutor) webDriver)
.executeScript("arguments[0].scrollIntoView(true);", webDriver.findElement(common.saveWebhook()));
Events.click(webDriver, common.saveWebhook()); Events.click(webDriver, common.saveWebhook());
WebElement errorMessage = webDriver.findElement(common.errorMessage()); WebElement errorMessage = webDriver.findElement(common.errorMessage());
Assert.assertTrue(errorMessage.isDisplayed()); Assert.assertTrue(errorMessage.isDisplayed());

15
openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/tags/TagsPageTest.java
View File

@ -27,10 +27,7 @@ import org.openmetadata.catalog.selenium.events.Events;
import org.openmetadata.catalog.selenium.objectRepository.Common; import org.openmetadata.catalog.selenium.objectRepository.Common;
import org.openmetadata.catalog.selenium.objectRepository.TagsPage; import org.openmetadata.catalog.selenium.objectRepository.TagsPage;
import org.openmetadata.catalog.selenium.properties.Property; import org.openmetadata.catalog.selenium.properties.Property;
import org.openqa.selenium.NoSuchElementException; import org.openqa.selenium.*;
import org.openqa.selenium.TimeoutException;
import org.openqa.selenium.WebDriver;
import org.openqa.selenium.WebElement;
import org.openqa.selenium.chrome.ChromeDriver; import org.openqa.selenium.chrome.ChromeDriver;
import org.openqa.selenium.chrome.ChromeOptions; import org.openqa.selenium.chrome.ChromeOptions;
import org.openqa.selenium.interactions.Actions; import org.openqa.selenium.interactions.Actions;
@ -99,7 +96,7 @@ class TagsPageTest {
@Order(3) @Order(3)
void editTagCategoryDescription() throws InterruptedException { void editTagCategoryDescription() throws InterruptedException {
openTagsPage(); openTagsPage();
Events.click(webDriver, common.containsText(tagCategoryDisplayName)); Events.click(webDriver, common.textEquals(tagCategoryDisplayName));
Events.click(webDriver, common.editTagCategoryDescription()); Events.click(webDriver, common.editTagCategoryDescription());
Events.click(webDriver, common.focusedDescriptionBox()); Events.click(webDriver, common.focusedDescriptionBox());
Events.click(webDriver, common.editDescriptionSaveButton()); Events.click(webDriver, common.editDescriptionSaveButton());
@ -109,7 +106,7 @@ class TagsPageTest {
@Order(4) @Order(4)
void addTag() throws InterruptedException { void addTag() throws InterruptedException {
openTagsPage(); openTagsPage();
Events.click(webDriver, common.containsText(tagCategoryDisplayName)); Events.click(webDriver, common.textEquals(tagCategoryDisplayName));
Events.click(webDriver, common.addTagButton()); Events.click(webDriver, common.addTagButton());
Events.sendKeys(webDriver, common.displayName(), tagDisplayName); Events.sendKeys(webDriver, common.displayName(), tagDisplayName);
Events.click(webDriver, common.descriptionBoldButton()); Events.click(webDriver, common.descriptionBoldButton());
@ -126,7 +123,7 @@ class TagsPageTest {
@Order(5) @Order(5)
void changeTagDescription() throws InterruptedException { void changeTagDescription() throws InterruptedException {
openTagsPage(); openTagsPage();
Events.click(webDriver, common.containsText(tagCategoryDisplayName)); Events.click(webDriver, common.textEquals(tagCategoryDisplayName));
Thread.sleep(waitTime); Thread.sleep(waitTime);
actions.moveToElement(webDriver.findElement(tagsPage.editTagDescription())).perform(); actions.moveToElement(webDriver.findElement(tagsPage.editTagDescription())).perform();
Events.click(webDriver, tagsPage.editTagDescription()); Events.click(webDriver, tagsPage.editTagDescription());
@ -180,7 +177,7 @@ class TagsPageTest {
@Order(10) @Order(10)
void removeTagFromTableColumn() throws InterruptedException { void removeTagFromTableColumn() throws InterruptedException {
openTagsPage(); openTagsPage();
Events.click(webDriver, common.containsText(tagCategoryDisplayName)); Events.click(webDriver, common.textEquals(tagCategoryDisplayName));
Events.click(webDriver, tagsPage.tagUsageCount()); Events.click(webDriver, tagsPage.tagUsageCount());
try { try {
Events.click(webDriver, tagsPage.tableLink()); Events.click(webDriver, tagsPage.tableLink());
@ -230,7 +227,7 @@ class TagsPageTest {
Events.click(webDriver, common.saveAssociatedTag()); Events.click(webDriver, common.saveAssociatedTag());
Events.click(webDriver, common.headerSettings()); Events.click(webDriver, common.headerSettings());
Events.click(webDriver, tagsPage.headerSettingsTags()); Events.click(webDriver, tagsPage.headerSettingsTags());
Events.click(webDriver, common.containsText("PersonalData")); Events.click(webDriver, common.textEquals("PersonalData"));
Events.click(webDriver, tagsPage.usageCountElementIndex(1)); Events.click(webDriver, tagsPage.usageCountElementIndex(1));
Thread.sleep(2000); Thread.sleep(2000);
String beforeFilterCount = webDriver.findElement(tagsPage.tagFilterCount(1)).getAttribute("innerHTML"); String beforeFilterCount = webDriver.findElement(tagsPage.tagFilterCount(1)).getAttribute("innerHTML");