yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-09-27 01:45:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix #6086 [UI] Ui sends @mention as <#E::undefined::undefined|[@mohit](/users/mohit)> hi (#6087)

Browse Source
This commit is contained in:
Sachin Chaurasiya 2022-07-14 18:22:46 +05:30 committed by GitHub
parent 0793e69752
commit 81b8710c2a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 18 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
openmetadata-ui/src/main/resources/ui/src/utils/FeedUtils.tsx
View File

@ -150,6 +150,10 @@ export const getThreadValue = (
return threadValue; return threadValue;
}; };
export const buildMentionLink = (entityType: string, entityFqn: string) => {
return `${document.location.protocol}//${document.location.host}/${entityType}/${entityFqn}`;
};
export async function suggestions(searchTerm: string, mentionChar: string) { export async function suggestions(searchTerm: string, mentionChar: string) {
if (mentionChar === '@') { if (mentionChar === '@') {
let atValues = []; let atValues = [];
@ -166,9 +170,10 @@ export async function suggestions(searchTerm: string, mentionChar: string) {
`@${hit._source.name ?? hit._source.display_name}`, `@${hit._source.name ?? hit._source.display_name}`,
hit._source.deleted hit._source.deleted
), ),
link: `/${entityUrlMap[entityType as keyof typeof entityUrlMap]}/${ link: buildMentionLink(
entityUrlMap[entityType as keyof typeof entityUrlMap],
hit._source.name hit._source.name
}`, ),
}; };
}); });
} else { } else {
@ -184,9 +189,10 @@ export async function suggestions(searchTerm: string, mentionChar: string) {
`@${hit._source.name ?? hit._source.display_name}`, `@${hit._source.name ?? hit._source.display_name}`,
hit._source.deleted hit._source.deleted
), ),
link: `/${entityUrlMap[entityType as keyof typeof entityUrlMap]}/${ link: buildMentionLink(
entityUrlMap[entityType as keyof typeof entityUrlMap],
hit._source.name hit._source.name
}`, ),
}; };
}); });
} }
@ -204,7 +210,10 @@ export async function suggestions(searchTerm: string, mentionChar: string) {
return { return {
id: hit._id, id: hit._id,
value: `#${entityType}/${hit._source.name}`, value: `#${entityType}/${hit._source.name}`,
link: `/${entityType}/${getEncodedFqn(hit._source.fqdn)}`, link: buildMentionLink(
entityType,
getEncodedFqn(hit._source.fullyQualifiedName)
),
}; };
}); });
} else { } else {
@ -217,7 +226,10 @@ export async function suggestions(searchTerm: string, mentionChar: string) {
return { return {
id: hit._id, id: hit._id,
value: `#${entityType}/${hit._source.name}`, value: `#${entityType}/${hit._source.name}`,
link: `/${entityType}/${getEncodedFqn(hit._source.fqdn)}`, link: buildMentionLink(
entityType,
getEncodedFqn(hit._source.fullyQualifiedName)
),
}; };
}); });
} }