From 83a185843476adda74c3f3ad63d31f1bccfd0763 Mon Sep 17 00:00:00 2001 From: NiharDoshi99 <51595473+NiharDoshi99@users.noreply.github.com> Date: Tue, 14 Mar 2023 14:47:00 +0530 Subject: [PATCH] fix druid ingestion (#10553) * fix druid ingestion * changes as per comment * changes as per comment --- .../metadata/ingestion/source/database/common_db_source.py | 1 + .../services/connections/database/druidConnection.json | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/ingestion/src/metadata/ingestion/source/database/common_db_source.py b/ingestion/src/metadata/ingestion/source/database/common_db_source.py index e3d39851b6f..d638b9a24c5 100644 --- a/ingestion/src/metadata/ingestion/source/database/common_db_source.py +++ b/ingestion/src/metadata/ingestion/source/database/common_db_source.py @@ -134,6 +134,7 @@ class CommonDbSourceService( database_name = self.service_connection.__dict__.get( "database", custom_database_name or "default" ) + # By default, set the inspector on the created engine self.inspector = inspect(self.engine) yield database_name diff --git a/openmetadata-spec/src/main/resources/json/schema/entity/services/connections/database/druidConnection.json b/openmetadata-spec/src/main/resources/json/schema/entity/services/connections/database/druidConnection.json index fecc2455fde..0826700767f 100644 --- a/openmetadata-spec/src/main/resources/json/schema/entity/services/connections/database/druidConnection.json +++ b/openmetadata-spec/src/main/resources/json/schema/entity/services/connections/database/druidConnection.json @@ -48,9 +48,9 @@ "description": "Host and port of the Druid service.", "type": "string" }, - "database": { - "title": "Database", - "description": "Database of the data source. This is optional parameter, if you would like to restrict the metadata reading to a single database. When left blank, OpenMetadata Ingestion attempts to scan all the databases.", + "databaseName": { + "title": "Database Name", + "description": "Optional name to give to the database in OpenMetadata. If left blank, we will use default as the database name.", "type": "string" }, "connectionOptions": {