From 83cae05f067edfb79381e08cb7556c8175073a32 Mon Sep 17 00:00:00 2001 From: Aniket Katkar <51777795+aniketkatkar97@users.noreply.github.com> Date: Thu, 18 Aug 2022 12:42:55 +0530 Subject: [PATCH] Improvements #6701 : Styling improvements and minor bug fixes. (#6765) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Improvements #6701 : Changes made : - Moved “Teams, User and Admins” to new category "Members" - Reduced table column height - Update edit icon - Resolved the issue with search bar shrinking. - Changed order of links on navbar - Switch button styling changed as per mocks * Used variable to store color values in less file * Search bar width made responsive to avoid overlapping with settings button --- .../resources/ui/src/assets/svg/ic-edit.svg | 8 ++-- .../EntityTable/EntityTable.component.tsx | 2 +- .../components/TeamDetails/TeamHierarchy.tsx | 2 +- .../ui/src/components/TeamDetails/Teams.tsx | 6 +-- .../ui/src/components/UserList/UserListV1.tsx | 2 +- .../src/components/Users/Users.component.tsx | 13 ++++-- .../ui/src/components/Webhooks/webhookV1.less | 2 +- .../EntitySummaryDetails.tsx | 15 ++++--- .../common/description/Description.tsx | 2 +- .../ui/src/components/nav-bar/NavBar.tsx | 21 +++++----- .../constants/globalSettings.constants.tsx | 11 ++++- .../pages/BotsPageV1/BotsPageV1.component.tsx | 4 +- .../ui/src/router/GlobalSettingRouter.tsx | 8 ++-- .../resources/ui/src/styles/antd-master.less | 1 + .../src/styles/components/toggle-switch.less | 41 +++++++++++++++++++ .../main/resources/ui/src/styles/x-master.css | 28 +++---------- .../resources/ui/src/utils/RouterUtils.ts | 2 +- 17 files changed, 102 insertions(+), 66 deletions(-) create mode 100644 openmetadata-ui/src/main/resources/ui/src/styles/components/toggle-switch.less diff --git a/openmetadata-ui/src/main/resources/ui/src/assets/svg/ic-edit.svg b/openmetadata-ui/src/main/resources/ui/src/assets/svg/ic-edit.svg index 74890e78208..872f66d8db6 100644 --- a/openmetadata-ui/src/main/resources/ui/src/assets/svg/ic-edit.svg +++ b/openmetadata-ui/src/main/resources/ui/src/assets/svg/ic-edit.svg @@ -1,4 +1,4 @@ - - - - + + + + \ No newline at end of file diff --git a/openmetadata-ui/src/main/resources/ui/src/components/EntityTable/EntityTable.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/EntityTable/EntityTable.component.tsx index aef4ce6aeb9..71a16a156a8 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/EntityTable/EntityTable.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/EntityTable/EntityTable.component.tsx @@ -733,7 +733,7 @@ const EntityTable = ({ )} -
+
{!isReadOnly ? ( {checkPermission() && ( diff --git a/openmetadata-ui/src/main/resources/ui/src/components/TeamDetails/TeamHierarchy.tsx b/openmetadata-ui/src/main/resources/ui/src/components/TeamDetails/TeamHierarchy.tsx index 545ccf51ad2..675e3441668 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/TeamDetails/TeamHierarchy.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/TeamDetails/TeamHierarchy.tsx @@ -70,7 +70,7 @@ const TeamHierarchy: FC = ({ data }) => { columns={columns} dataSource={data} pagination={false} - size="middle" + size="small" /> ); }; diff --git a/openmetadata-ui/src/main/resources/ui/src/components/TeamDetails/Teams.tsx b/openmetadata-ui/src/main/resources/ui/src/components/TeamDetails/Teams.tsx index e7f21532c86..49a8d938bbc 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/TeamDetails/Teams.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/TeamDetails/Teams.tsx @@ -58,14 +58,14 @@ const Teams: FC = ({ - + - Deleted Teams - + Deleted Teams + diff --git a/openmetadata-ui/src/main/resources/ui/src/components/UserList/UserListV1.tsx b/openmetadata-ui/src/main/resources/ui/src/components/UserList/UserListV1.tsx index d44416dbd42..3b48117796d 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/UserList/UserListV1.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/UserList/UserListV1.tsx @@ -215,7 +215,7 @@ const UserListV1: FC = ({ indicator: , }} pagination={false} - size="middle" + size="small" /> diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Users/Users.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/Users/Users.component.tsx index 6d23fc7c2f1..15cd67d6d62 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/Users/Users.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/Users/Users.component.tsx @@ -698,10 +698,15 @@ const Users = ({ )}
{isTaskType ? ( -
- - Closed Tasks -
+ + + + Closed Tasks + + ) : null}
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Webhooks/webhookV1.less b/openmetadata-ui/src/main/resources/ui/src/components/Webhooks/webhookV1.less index edfee92f7e9..80bf1716f57 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/Webhooks/webhookV1.less +++ b/openmetadata-ui/src/main/resources/ui/src/components/Webhooks/webhookV1.less @@ -11,7 +11,7 @@ * limitations under the License. */ -@import '../../styles/antd-master.less'; +@primary-color: #7147e8; .webhook-right-panel { max-width: 290px; diff --git a/openmetadata-ui/src/main/resources/ui/src/components/common/EntitySummaryDetails/EntitySummaryDetails.tsx b/openmetadata-ui/src/main/resources/ui/src/components/common/EntitySummaryDetails/EntitySummaryDetails.tsx index d8f4f6d5883..435996ad5ef 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/common/EntitySummaryDetails/EntitySummaryDetails.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/common/EntitySummaryDetails/EntitySummaryDetails.tsx @@ -55,6 +55,7 @@ const EntitySummaryDetails = ({ {updateOwner ? ( } trigger={['click']}> - + {updateTier ? ( setshow(true)}> setshow(true)}> {updateOwner ? ( } trigger={['click']}> - + {updateTier ? ( = ({ const DescriptionActions = () => { return !isReadOnly ? ( -
+
{checkPermission() && (
, }, + ], + }, + { + category: 'Access', + isProtected: false, + items: [ { label: 'Roles', isProtected: true, @@ -151,6 +157,7 @@ export const customAttributesPath = { }; export enum GlobalSettingsMenuCategory { + MEMBERS = 'members', ACCESS = 'access', SERVICES = 'services', CUSTOM_ATTRIBUTES = 'customAttributes', diff --git a/openmetadata-ui/src/main/resources/ui/src/pages/BotsPageV1/BotsPageV1.component.tsx b/openmetadata-ui/src/main/resources/ui/src/pages/BotsPageV1/BotsPageV1.component.tsx index 067a2f0ba88..457327a77ba 100644 --- a/openmetadata-ui/src/main/resources/ui/src/pages/BotsPageV1/BotsPageV1.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/pages/BotsPageV1/BotsPageV1.component.tsx @@ -33,8 +33,8 @@ export const BotsPageV1 = () => { - - + + { @@ -83,7 +83,7 @@ const GlobalSettingRouter = () => { exact component={TeamsPage} path={getSettingPath( - GlobalSettingsMenuCategory.ACCESS, + GlobalSettingsMenuCategory.MEMBERS, GlobalSettingOptions.TEAMS )} /> @@ -91,7 +91,7 @@ const GlobalSettingRouter = () => { exact component={TeamsPage} path={getSettingPath( - GlobalSettingsMenuCategory.ACCESS, + GlobalSettingsMenuCategory.MEMBERS, GlobalSettingOptions.TEAMS, true )} @@ -145,7 +145,7 @@ const GlobalSettingRouter = () => { { let path = ROUTES.SETTINGS_WITH_TAB_FQN; path = path - .replace(PLACEHOLDER_SETTING_CATEGORY, GlobalSettingsMenuCategory.ACCESS) + .replace(PLACEHOLDER_SETTING_CATEGORY, GlobalSettingsMenuCategory.MEMBERS) .replace(PLACEHOLDER_ROUTE_TAB, GlobalSettingOptions.TEAMS) .replace(PLACEHOLDER_ROUTE_FQN, fqn);