yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-09-02 13:43:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

minor: added entity type support in dq dashboard API (#18977)

Browse Source
This commit is contained in:
Shailesh Parmar 2024-12-09 22:32:27 +05:30 committed by GitHub
parent 5263858067
commit 83f094e286
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 88 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
openmetadata-ui/src/main/resources/ui/src/pages/DataQuality/DataQualityPage.interface.ts
View File

@ -1,5 +1,3 @@
import { TestSummary } from '../../generated/tests/testCase';
/*
* Copyright 2023 Collate.
* Licensed under the Apache License, Version 2.0 (the "License");
@ -12,6 +10,10 @@ import { TestSummary } from '../../generated/tests/testCase';
* See the License for the specific language governing permissions and
* limitations under the License.
*/
import { EntityType } from '../../enums/entity.enum';
import { TestSummary } from '../../generated/tests/testCase';
export enum DataQualityPageTabs {
TEST_SUITES = 'test-suites',
TABLES = 'tables',
@ -32,4 +34,5 @@ export type DataQualityDashboardChartFilters = {
startTs?: number;
endTs?: number;
entityFQN?: string;
entityType?: EntityType;
};

80
openmetadata-ui/src/main/resources/ui/src/rest/dataQualityDashboardAPI.test.ts
View File

@ -12,6 +12,7 @@
*/
/* eslint-disable max-len */
import { IncidentTimeMetricsType } from '../components/DataQuality/DataQuality.interface';
import { EntityType } from '../enums/entity.enum';
import { TestCaseStatus } from '../generated/tests/testCase';
import { TestCaseResolutionStatusTypes } from '../generated/tests/testCaseResolutionStatus';
import {
@ -1209,5 +1210,84 @@ describe('dataQualityDashboardAPI', () => {
'bucketName=byDay:aggType=date_histogram:field=timestamp&calendar_interval=day,bucketName=newIncidents:aggType=cardinality:field=testCase.fullyQualifiedName',
});
});
it('should call getDataQualityReport with provided entityType', async () => {
const status = TestCaseStatus.Success;
const filters = {
entityType: EntityType.TABLE,
entityFQN: 'entityFQN',
startTs: 1729073964962,
endTs: 1729678764965,
};
await fetchTestCaseStatusMetricsByDays(status, filters);
expect(getDataQualityReport).toHaveBeenCalledWith({
q: JSON.stringify({
query: {
bool: {
must: [
{ term: { testCaseStatus: status } },
{
range: {
timestamp: {
lte: filters.endTs,
gte: filters.startTs,
},
},
},
{
term: {
'table.fullyQualifiedName.keyword': 'entityFQN',
},
},
],
},
},
}),
index: 'testCaseResult',
aggregationQuery:
'bucketName=byDay:aggType=date_histogram:field=timestamp&calendar_interval=day,bucketName=newIncidents:aggType=cardinality:field=testCase.fullyQualifiedName',
});
});
it('should call getDataQualityReport with normal entity fqn if entityType not provided', async () => {
const status = TestCaseStatus.Success;
const filters = {
entityFQN: 'entityFQN',
startTs: 1729073964962,
endTs: 1729678764965,
};
await fetchTestCaseStatusMetricsByDays(status, filters);
expect(getDataQualityReport).toHaveBeenCalledWith({
q: JSON.stringify({
query: {
bool: {
must: [
{ term: { testCaseStatus: status } },
{
range: {
timestamp: {
lte: filters.endTs,
gte: filters.startTs,
},
},
},
{
term: {
'testCase.entityFQN': 'entityFQN',
},
},
],
},
},
}),
index: 'testCaseResult',
aggregationQuery:
'bucketName=byDay:aggType=date_histogram:field=timestamp&calendar_interval=day,bucketName=newIncidents:aggType=cardinality:field=testCase.fullyQualifiedName',
});
});
});
});

4
openmetadata-ui/src/main/resources/ui/src/rest/dataQualityDashboardAPI.ts
View File

@ -317,7 +317,9 @@ export const fetchTestCaseStatusMetricsByDays = (
if (filters?.entityFQN) {
mustFilter.push({
term: {
'testCase.entityFQN': filters.entityFQN,
[filters.entityType
? `${filters.entityType}.fullyQualifiedName.keyword`
: 'testCase.entityFQN']: filters.entityFQN,
},
});
}