yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-12-25 06:28:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Profiler & Data Quality UI feedback & improvement #7090 part 5 (#7158)

Browse Source
This commit is contained in:
Shailesh Parmar 2022-09-02 15:51:47 +05:30 committed by GitHub
parent 26da781709
commit 8462d4389d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 21 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
openmetadata-ui/src/main/resources/ui/src/components/AddDataQualityTest/AddDataQualityTestV1.tsx
View File

@ -37,7 +37,6 @@ import { TestSuite } from '../../generated/tests/testSuite';
import {
getCurrentUserId,
getEntityName,
getNameFromFQN,
getPartialNameFromTableFQN,
} from '../../utils/CommonUtils';
import { getTestSuitePath } from '../../utils/RouterUtils';
@ -104,7 +103,9 @@ const AddDataQualityTestV1: React.FC<AddDataQualityTestProps> = ({ table }) => {
if (isColumnFqn) {
const colVal = [
{
name: getNameFromFQN(entityTypeFQN),
name: getPartialNameFromTableFQN(entityTypeFQN, [
FqnPart.NestedColumn,
]),
url: getTableTabPath(entityTypeFQN, 'profiler'),
},
{

4
openmetadata-ui/src/main/resources/ui/src/components/ProfilerDashboard/ProfilerDashboard.tsx
View File

@ -145,7 +145,9 @@ const ProfilerDashboard: React.FC<ProfilerDashboardProps> = ({
const breadcrumb = useMemo(() => {
const serviceName = getEntityName(table.service);
const fqn = table.fullyQualifiedName || '';
const columnName = getNameFromFQN(entityTypeFQN);
const columnName = getPartialNameFromTableFQN(entityTypeFQN, [
FqnPart.NestedColumn,
]);
const data: TitleBreadcrumbProps['titleLinks'] = [
{

2
openmetadata-ui/src/main/resources/ui/src/components/ProfilerDashboard/component/ProfilerTab.tsx
View File

@ -233,7 +233,7 @@ const ProfilerTab: React.FC<ProfilerTabProps> = ({
<Col span={8}>
<Statistic
title="Data type"
value={activeColumnDetails.dataTypeDisplay || ''}
value={activeColumnDetails.dataType || ''}
valueStyle={{
color: '#1890FF',
fontSize: '24px',

14
openmetadata-ui/src/main/resources/ui/src/utils/CommonUtils.tsx
View File

@ -98,12 +98,6 @@ export const isEven = (value: number): boolean => {
return value % 2 === 0;
};
export const getTableFQNFromColumnFQN = (columnFQN: string): string => {
const arrColFQN = columnFQN.split(FQN_SEPARATOR_CHAR);
return arrColFQN.slice(0, arrColFQN.length - 1).join(FQN_SEPARATOR_CHAR);
};
export const getPartialNameFromFQN = (
fqn: string,
arrTypes: Array<'service' | 'database' | 'table' | 'column'> = [],
@ -164,6 +158,14 @@ export const getPartialNameFromTableFQN = (
return arrPartialName.join(joinSeparator);
};
export const getTableFQNFromColumnFQN = (columnFQN: string): string => {
return getPartialNameFromTableFQN(
columnFQN,
[FqnPart.Service, FqnPart.Database, FqnPart.Schema, FqnPart.Table],
'.'
);
};
export const getCurrentUserId = (): string => {
const currentUser = AppState.getCurrentUserDetails();

9
openmetadata-ui/src/main/resources/ui/src/utils/TableUtils.tsx
View File

@ -30,14 +30,17 @@ import {
getTableDetailsPath,
getTopicDetailsPath,
} from '../constants/constants';
import { EntityType } from '../enums/entity.enum';
import { EntityType, FqnPart } from '../enums/entity.enum';
import { SearchIndex } from '../enums/search.enum';
import { ConstraintTypes, PrimaryTableDataTypes } from '../enums/table.enum';
import { Column, DataType } from '../generated/entity/data/table';
import { TableTest, TestCaseStatus } from '../generated/tests/tableTest';
import { TagLabel } from '../generated/type/tagLabel';
import { ModifiedTableColumn } from '../interface/dataQuality.interface';
import { getNameFromFQN, getTableFQNFromColumnFQN } from './CommonUtils';
import {
getPartialNameFromTableFQN,
getTableFQNFromColumnFQN,
} from './CommonUtils';
import { getGlossaryPath } from './RouterUtils';
import { ordinalize } from './StringsUtils';
import SVGIcons, { Icons } from './SvgUtils';
@ -313,7 +316,7 @@ export const generateEntityLink = (fqn: string, includeColumn = false) => {
if (includeColumn) {
const tableFqn = getTableFQNFromColumnFQN(fqn);
const columnName = getNameFromFQN(fqn);
const columnName = getPartialNameFromTableFQN(fqn, [FqnPart.NestedColumn]);
return columnLink
.replace('ENTITY_FQN', tableFqn)