revert(ui): count badge was limit to 999 (#5910)

* revert(ui): count badge was limit to 999
minor text change for Activity feed & Tasks

* support 6 digit max for count tag

* fix tests
This commit is contained in:
Chirag Madlani 2022-07-07 15:38:46 +05:30 committed by GitHub
parent 373f35a133
commit 8521c45dee
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
14 changed files with 14 additions and 14 deletions

View File

@ -170,7 +170,7 @@ const DashboardDetails = ({
position: 1,
},
{
name: 'Activity Feed & Task',
name: 'Activity Feed & Tasks',
icon: {
alt: 'activity_feed',
name: 'activity_feed',

View File

@ -285,7 +285,7 @@ describe('Test DashboardDetails component', () => {
const description = await findByText(container, /Description Component/i);
const tabs = await findByTestId(container, 'tabs');
const detailsTab = await findByTestId(tabs, 'Details');
const activityFeedTab = await findByTestId(tabs, 'Activity Feed & Task');
const activityFeedTab = await findByTestId(tabs, 'Activity Feed & Tasks');
const lineageTab = await findByTestId(tabs, 'Lineage');
const manageTab = await findByTestId(tabs, 'Manage');

View File

@ -215,7 +215,7 @@ const DatasetDetails: React.FC<DatasetDetailsProps> = ({
position: 1,
},
{
name: 'Activity Feed & Task',
name: 'Activity Feed & Tasks',
icon: {
alt: 'activity_feed',
name: 'activity_feed',

View File

@ -233,7 +233,7 @@ describe('Test MyDataDetailsPage page', () => {
const description = await findByText(container, /Description/i);
const tabs = await findByTestId(container, 'tabs');
const schemaTab = await findByTestId(tabs, 'Schema');
const activityFeedTab = await findByTestId(tabs, 'Activity Feed & Task');
const activityFeedTab = await findByTestId(tabs, 'Activity Feed & Tasks');
const sampleDataTab = await findByTestId(tabs, 'Sample Data');
const queriesTab = await findByTestId(tabs, 'Queries');
const profilerTab = await findByTestId(tabs, 'Profiler');

View File

@ -163,7 +163,7 @@ const PipelineDetails = ({
position: 1,
},
{
name: 'Activity Feed & Task',
name: 'Activity Feed & Tasks',
icon: {
alt: 'activity_feed',
name: 'activity_feed',

View File

@ -186,7 +186,7 @@ describe('Test PipelineDetails component', () => {
const description = await findByText(container, /Description Component/i);
const tabs = await findByTestId(container, 'tabs');
const detailsTab = await findByTestId(tabs, 'Details');
const activityFeedTab = await findByTestId(tabs, 'Activity Feed & Task');
const activityFeedTab = await findByTestId(tabs, 'Activity Feed & Tasks');
const lineageTab = await findByTestId(tabs, 'Lineage');
const manageTab = await findByTestId(tabs, 'Manage');

View File

@ -177,7 +177,7 @@ const TopicDetails: React.FC<TopicDetailsProps> = ({
position: 1,
},
{
name: 'Activity Feed & Task',
name: 'Activity Feed & Tasks',
icon: {
alt: 'activity_feed',
name: 'activity_feed',

View File

@ -174,7 +174,7 @@ describe('Test TopicDetails component', () => {
const description = await findByText(container, /Description Component/i);
const tabs = await findByTestId(container, 'tabs');
const schemaTab = await findByTestId(tabs, 'Schema');
const activityFeedTab = await findByTestId(tabs, 'Activity Feed & Task');
const activityFeedTab = await findByTestId(tabs, 'Activity Feed & Tasks');
const configTab = await findByTestId(tabs, 'Config');
const manageTab = await findByTestId(tabs, 'Manage');

View File

@ -58,7 +58,7 @@ const FilterContainer: FunctionComponent<FilterContainerProp> = ({
/>
<div
className={classNames(
'filters-title tw-w-36 tw-truncate custom-checkbox-label',
'filters-title tw-w-32 tw-truncate custom-checkbox-label',
{ 'tw-text-grey-muted': isDisabled }
)}
data-testid="checkbox-label">

View File

@ -204,7 +204,7 @@ export const getCountBadge = (
className
)}>
<span data-testid="filter-count" title={count.toString()}>
{count > 999 ? `999+` : count}
{count}
</span>
</span>
);

View File

@ -22,7 +22,7 @@ export const dashboardDetailsTabs = [
path: 'details',
},
{
name: 'Activity Feed & Task',
name: 'Activity Feed & Tasks',
path: 'activity_feed',
field: TabSpecificField.ACTIVITY_FEED,
},

View File

@ -23,7 +23,7 @@ export const datasetTableTabs = [
path: 'schema',
},
{
name: 'Activity Feed & Task',
name: 'Activity Feed & Tasks',
path: 'activity_feed',
field: TabSpecificField.ACTIVITY_FEED,
},

View File

@ -28,7 +28,7 @@ export const pipelineDetailsTabs = [
path: 'details',
},
{
name: 'Activity Feed & Task',
name: 'Activity Feed & Tasks',
path: 'activity_feed',
field: TabSpecificField.ACTIVITY_FEED,
},

View File

@ -19,7 +19,7 @@ export const topicDetailsTabs = [
path: 'schema',
},
{
name: 'Activity Feed & Task',
name: 'Activity Feed & Tasks',
path: 'activity_feed',
field: TabSpecificField.ACTIVITY_FEED,
},