yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-10-19 21:02:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

revert(ui): count badge was limit to 999 (#5910)

Browse Source 
* revert(ui): count badge was limit to 999
minor text change for Activity feed & Tasks

* support 6 digit max for count tag

* fix tests
This commit is contained in:
Chirag Madlani 2022-07-07 15:38:46 +05:30 committed by GitHub
parent 373f35a133
commit 8521c45dee
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
14 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
openmetadata-ui/src/main/resources/ui/src/components/DashboardDetails/DashboardDetails.component.tsx
View File

@ -170,7 +170,7 @@ const DashboardDetails = ({
position: 1, position: 1,
}, },
{ {
name: 'Activity Feed & Task', name: 'Activity Feed & Tasks',
icon: { icon: {
alt: 'activity_feed', alt: 'activity_feed',
name: 'activity_feed', name: 'activity_feed',

2
openmetadata-ui/src/main/resources/ui/src/components/DashboardDetails/DashboardDetails.test.tsx
View File

@ -285,7 +285,7 @@ describe('Test DashboardDetails component', () => {
const description = await findByText(container, /Description Component/i); const description = await findByText(container, /Description Component/i);
const tabs = await findByTestId(container, 'tabs'); const tabs = await findByTestId(container, 'tabs');
const detailsTab = await findByTestId(tabs, 'Details'); const detailsTab = await findByTestId(tabs, 'Details');
const activityFeedTab = await findByTestId(tabs, 'Activity Feed & Task'); const activityFeedTab = await findByTestId(tabs, 'Activity Feed & Tasks');
const lineageTab = await findByTestId(tabs, 'Lineage'); const lineageTab = await findByTestId(tabs, 'Lineage');
const manageTab = await findByTestId(tabs, 'Manage'); const manageTab = await findByTestId(tabs, 'Manage');

2
openmetadata-ui/src/main/resources/ui/src/components/DatasetDetails/DatasetDetails.component.tsx
View File

@ -215,7 +215,7 @@ const DatasetDetails: React.FC<DatasetDetailsProps> = ({
position: 1, position: 1,
}, },
{ {
name: 'Activity Feed & Task', name: 'Activity Feed & Tasks',
icon: { icon: {
alt: 'activity_feed', alt: 'activity_feed',
name: 'activity_feed', name: 'activity_feed',

2
openmetadata-ui/src/main/resources/ui/src/components/DatasetDetails/DatasetDetails.test.tsx
View File

@ -233,7 +233,7 @@ describe('Test MyDataDetailsPage page', () => {
const description = await findByText(container, /Description/i); const description = await findByText(container, /Description/i);
const tabs = await findByTestId(container, 'tabs'); const tabs = await findByTestId(container, 'tabs');
const schemaTab = await findByTestId(tabs, 'Schema'); const schemaTab = await findByTestId(tabs, 'Schema');
const activityFeedTab = await findByTestId(tabs, 'Activity Feed & Task'); const activityFeedTab = await findByTestId(tabs, 'Activity Feed & Tasks');
const sampleDataTab = await findByTestId(tabs, 'Sample Data'); const sampleDataTab = await findByTestId(tabs, 'Sample Data');
const queriesTab = await findByTestId(tabs, 'Queries'); const queriesTab = await findByTestId(tabs, 'Queries');
const profilerTab = await findByTestId(tabs, 'Profiler'); const profilerTab = await findByTestId(tabs, 'Profiler');

2
openmetadata-ui/src/main/resources/ui/src/components/PipelineDetails/PipelineDetails.component.tsx
View File

@ -163,7 +163,7 @@ const PipelineDetails = ({
position: 1, position: 1,
}, },
{ {
name: 'Activity Feed & Task', name: 'Activity Feed & Tasks',
icon: { icon: {
alt: 'activity_feed', alt: 'activity_feed',
name: 'activity_feed', name: 'activity_feed',

2
openmetadata-ui/src/main/resources/ui/src/components/PipelineDetails/PipelineDetails.test.tsx
View File

@ -186,7 +186,7 @@ describe('Test PipelineDetails component', () => {
const description = await findByText(container, /Description Component/i); const description = await findByText(container, /Description Component/i);
const tabs = await findByTestId(container, 'tabs'); const tabs = await findByTestId(container, 'tabs');
const detailsTab = await findByTestId(tabs, 'Details'); const detailsTab = await findByTestId(tabs, 'Details');
const activityFeedTab = await findByTestId(tabs, 'Activity Feed & Task'); const activityFeedTab = await findByTestId(tabs, 'Activity Feed & Tasks');
const lineageTab = await findByTestId(tabs, 'Lineage'); const lineageTab = await findByTestId(tabs, 'Lineage');
const manageTab = await findByTestId(tabs, 'Manage'); const manageTab = await findByTestId(tabs, 'Manage');

2
openmetadata-ui/src/main/resources/ui/src/components/TopicDetails/TopicDetails.component.tsx
View File

@ -177,7 +177,7 @@ const TopicDetails: React.FC<TopicDetailsProps> = ({
position: 1, position: 1,
}, },
{ {
name: 'Activity Feed & Task', name: 'Activity Feed & Tasks',
icon: { icon: {
alt: 'activity_feed', alt: 'activity_feed',
name: 'activity_feed', name: 'activity_feed',

2
openmetadata-ui/src/main/resources/ui/src/components/TopicDetails/TopicDetails.test.tsx
View File

@ -174,7 +174,7 @@ describe('Test TopicDetails component', () => {
const description = await findByText(container, /Description Component/i); const description = await findByText(container, /Description Component/i);
const tabs = await findByTestId(container, 'tabs'); const tabs = await findByTestId(container, 'tabs');
const schemaTab = await findByTestId(tabs, 'Schema'); const schemaTab = await findByTestId(tabs, 'Schema');
const activityFeedTab = await findByTestId(tabs, 'Activity Feed & Task'); const activityFeedTab = await findByTestId(tabs, 'Activity Feed & Tasks');
const configTab = await findByTestId(tabs, 'Config'); const configTab = await findByTestId(tabs, 'Config');
const manageTab = await findByTestId(tabs, 'Manage'); const manageTab = await findByTestId(tabs, 'Manage');

2
openmetadata-ui/src/main/resources/ui/src/components/common/facetfilter/FilterContainer.tsx
View File

@ -58,7 +58,7 @@ const FilterContainer: FunctionComponent<FilterContainerProp> = ({
/> />
<div <div
className={classNames( className={classNames(
'filters-title tw-w-36 tw-truncate custom-checkbox-label', 'filters-title tw-w-32 tw-truncate custom-checkbox-label',
{ 'tw-text-grey-muted': isDisabled } { 'tw-text-grey-muted': isDisabled }
)} )}
data-testid="checkbox-label"> data-testid="checkbox-label">

2
openmetadata-ui/src/main/resources/ui/src/utils/CommonUtils.tsx
View File

@ -204,7 +204,7 @@ export const getCountBadge = (
className className
)}> )}>
<span data-testid="filter-count" title={count.toString()}> <span data-testid="filter-count" title={count.toString()}>
{count > 999 ? `999+` : count} {count}
</span> </span>
</span> </span>
); );

2
openmetadata-ui/src/main/resources/ui/src/utils/DashboardDetailsUtils.ts
View File

@ -22,7 +22,7 @@ export const dashboardDetailsTabs = [
path: 'details', path: 'details',
}, },
{ {
name: 'Activity Feed & Task', name: 'Activity Feed & Tasks',
path: 'activity_feed', path: 'activity_feed',
field: TabSpecificField.ACTIVITY_FEED, field: TabSpecificField.ACTIVITY_FEED,
}, },

2
openmetadata-ui/src/main/resources/ui/src/utils/DatasetDetailsUtils.ts
View File

@ -23,7 +23,7 @@ export const datasetTableTabs = [
path: 'schema', path: 'schema',
}, },
{ {
name: 'Activity Feed & Task', name: 'Activity Feed & Tasks',
path: 'activity_feed', path: 'activity_feed',
field: TabSpecificField.ACTIVITY_FEED, field: TabSpecificField.ACTIVITY_FEED,
}, },

2
openmetadata-ui/src/main/resources/ui/src/utils/PipelineDetailsUtils.ts
View File

@ -28,7 +28,7 @@ export const pipelineDetailsTabs = [
path: 'details', path: 'details',
}, },
{ {
name: 'Activity Feed & Task', name: 'Activity Feed & Tasks',
path: 'activity_feed', path: 'activity_feed',
field: TabSpecificField.ACTIVITY_FEED, field: TabSpecificField.ACTIVITY_FEED,
}, },

2
openmetadata-ui/src/main/resources/ui/src/utils/TopicDetailsUtils.ts
View File

@ -19,7 +19,7 @@ export const topicDetailsTabs = [
path: 'schema', path: 'schema',
}, },
{ {
name: 'Activity Feed & Task', name: 'Activity Feed & Tasks',
path: 'activity_feed', path: 'activity_feed',
field: TabSpecificField.ACTIVITY_FEED, field: TabSpecificField.ACTIVITY_FEED,
}, },