From 857685d91f4706529c9e98f96e9d60fe2176bf54 Mon Sep 17 00:00:00 2001
From: Ayush Shah <ayush@getcollate.io>
Date: Mon, 24 Nov 2025 18:58:33 +0530
Subject: [PATCH] Fix NPE in IngestionPipelineRepository update methods for
 null fields (#24479)

---
 .../service/jdbi3/IngestionPipelineRepository.java  | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/IngestionPipelineRepository.java b/openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/IngestionPipelineRepository.java
index 1bf96f9d598..8278d52b3b8 100644
--- a/openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/IngestionPipelineRepository.java
+++ b/openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/IngestionPipelineRepository.java
@@ -23,6 +23,7 @@ import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
+import java.util.Objects;
 import java.util.Optional;
 import java.util.UUID;
 import lombok.Getter;
@@ -545,13 +546,13 @@ public class IngestionPipelineRepository extends EntityRepository<IngestionPipel
 
     private void updateAirflowConfig(
         AirflowConfig origAirflowConfig, AirflowConfig updatedAirflowConfig) {
-      if (!origAirflowConfig.equals(updatedAirflowConfig)) {
+      if (!Objects.equals(origAirflowConfig, updatedAirflowConfig)) {
         recordChange("airflowConfig", origAirflowConfig, updatedAirflowConfig);
       }
     }
 
     private void updateLogLevel(LogLevels origLevel, LogLevels updatedLevel) {
-      if (updatedLevel != null && !origLevel.equals(updatedLevel)) {
+      if (updatedLevel != null && !Objects.equals(origLevel, updatedLevel)) {
         recordChange("loggerLevel", origLevel, updatedLevel);
       }
     }
@@ -559,25 +560,25 @@ public class IngestionPipelineRepository extends EntityRepository<IngestionPipel
     private void updateEnableStreamableLogs(
         Boolean origEnableStreamableLogs, Boolean updatedEnableStreamableLogs) {
       if (updatedEnableStreamableLogs != null
-          && !origEnableStreamableLogs.equals(updatedEnableStreamableLogs)) {
+          && !Objects.equals(origEnableStreamableLogs, updatedEnableStreamableLogs)) {
         recordChange("enableStreamableLogs", origEnableStreamableLogs, updatedEnableStreamableLogs);
       }
     }
 
     private void updateDeployed(Boolean origDeployed, Boolean updatedDeployed) {
-      if (updatedDeployed != null && !origDeployed.equals(updatedDeployed)) {
+      if (updatedDeployed != null && !Objects.equals(origDeployed, updatedDeployed)) {
         recordChange("deployed", origDeployed, updatedDeployed);
       }
     }
 
     private void updateRaiseOnError(Boolean origRaiseOnError, Boolean updatedRaiseOnError) {
-      if (updatedRaiseOnError != null && !origRaiseOnError.equals(updatedRaiseOnError)) {
+      if (updatedRaiseOnError != null && !Objects.equals(origRaiseOnError, updatedRaiseOnError)) {
         recordChange("raiseOnError", origRaiseOnError, updatedRaiseOnError);
       }
     }
 
     private void updateEnabled(Boolean origEnabled, Boolean updatedEnabled) {
-      if (updatedEnabled != null && !origEnabled.equals(updatedEnabled)) {
+      if (updatedEnabled != null && !Objects.equals(origEnabled, updatedEnabled)) {
         recordChange("enabled", origEnabled, updatedEnabled);
       }
     }