Fix NPE in IngestionPipelineRepository update methods for null fields (#24479)

This commit is contained in:
Ayush Shah 2025-11-24 18:58:33 +05:30 committed by GitHub
parent a5c6e4b1ea
commit 857685d91f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -23,6 +23,7 @@ import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.Objects;
import java.util.Optional;
import java.util.UUID;
import lombok.Getter;
@ -545,13 +546,13 @@ public class IngestionPipelineRepository extends EntityRepository<IngestionPipel
private void updateAirflowConfig(
AirflowConfig origAirflowConfig, AirflowConfig updatedAirflowConfig) {
if (!origAirflowConfig.equals(updatedAirflowConfig)) {
if (!Objects.equals(origAirflowConfig, updatedAirflowConfig)) {
recordChange("airflowConfig", origAirflowConfig, updatedAirflowConfig);
}
}
private void updateLogLevel(LogLevels origLevel, LogLevels updatedLevel) {
if (updatedLevel != null && !origLevel.equals(updatedLevel)) {
if (updatedLevel != null && !Objects.equals(origLevel, updatedLevel)) {
recordChange("loggerLevel", origLevel, updatedLevel);
}
}
@ -559,25 +560,25 @@ public class IngestionPipelineRepository extends EntityRepository<IngestionPipel
private void updateEnableStreamableLogs(
Boolean origEnableStreamableLogs, Boolean updatedEnableStreamableLogs) {
if (updatedEnableStreamableLogs != null
&& !origEnableStreamableLogs.equals(updatedEnableStreamableLogs)) {
&& !Objects.equals(origEnableStreamableLogs, updatedEnableStreamableLogs)) {
recordChange("enableStreamableLogs", origEnableStreamableLogs, updatedEnableStreamableLogs);
}
}
private void updateDeployed(Boolean origDeployed, Boolean updatedDeployed) {
if (updatedDeployed != null && !origDeployed.equals(updatedDeployed)) {
if (updatedDeployed != null && !Objects.equals(origDeployed, updatedDeployed)) {
recordChange("deployed", origDeployed, updatedDeployed);
}
}
private void updateRaiseOnError(Boolean origRaiseOnError, Boolean updatedRaiseOnError) {
if (updatedRaiseOnError != null && !origRaiseOnError.equals(updatedRaiseOnError)) {
if (updatedRaiseOnError != null && !Objects.equals(origRaiseOnError, updatedRaiseOnError)) {
recordChange("raiseOnError", origRaiseOnError, updatedRaiseOnError);
}
}
private void updateEnabled(Boolean origEnabled, Boolean updatedEnabled) {
if (updatedEnabled != null && !origEnabled.equals(updatedEnabled)) {
if (updatedEnabled != null && !Objects.equals(origEnabled, updatedEnabled)) {
recordChange("enabled", origEnabled, updatedEnabled);
}
}