yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-09-27 09:55:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

Check for required fields before update (#13308)

Browse Source
This commit is contained in:
Pere Miquel Brull 2023-09-22 15:27:17 +02:00 committed by GitHub
parent a7dd7012ea
commit 880907f8c8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 22 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/MlModelRepository.java
View File

@ -335,9 +335,12 @@ public class MlModelRepository extends EntityRepository<MlModel> {
private void updateAlgorithm(MlModel origModel, MlModel updatedModel) { private void updateAlgorithm(MlModel origModel, MlModel updatedModel) {
// Updating an algorithm should be flagged for an ML Model // Updating an algorithm should be flagged for an ML Model
if (recordChange("algorithm", origModel.getAlgorithm(), updatedModel.getAlgorithm())) { // Algorithm is a required field. Cannot be null.
// Mark the EntityUpdater version change to major if (updated.getAlgorithm() != null) {
majorVersionChange = true; if (recordChange("algorithm", origModel.getAlgorithm(), updatedModel.getAlgorithm())) {
// Mark the EntityUpdater version change to major
majorVersionChange = true;
}
} }
} }

13
openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/QueryRepository.java
View File

@ -235,11 +235,14 @@ public class QueryRepository extends EntityRepository<Query> {
// Store Query Used in Relation // Store Query Used in Relation
recordChange("usedBy", original.getUsedBy(), updated.getUsedBy(), true); recordChange("usedBy", original.getUsedBy(), updated.getUsedBy(), true);
storeQueryUsedIn(updated.getId(), added, deleted); storeQueryUsedIn(updated.getId(), added, deleted);
String originalChecksum = EntityUtil.hash(original.getQuery()); // Query is a required field. Cannot be removed.
String updatedChecksum = EntityUtil.hash(updated.getQuery()); if (updated.getQuery() != null) {
if (!originalChecksum.equals(updatedChecksum)) { String originalChecksum = EntityUtil.hash(original.getQuery());
recordChange("query", original.getQuery(), updated.getQuery()); String updatedChecksum = EntityUtil.hash(updated.getQuery());
recordChange("checkSum", original.getChecksum(), updatedChecksum); if (!originalChecksum.equals(updatedChecksum)) {
recordChange("query", original.getQuery(), updated.getQuery());
recordChange("checkSum", original.getChecksum(), updatedChecksum);
}
} }
} }
} }

5
openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/StoredProcedureRepository.java
View File

@ -112,7 +112,10 @@ public class StoredProcedureRepository extends EntityRepository<StoredProcedure>
@Override @Override
public void entitySpecificUpdate() { public void entitySpecificUpdate() {
recordChange("storedProcedureCode", original.getStoredProcedureCode(), updated.getStoredProcedureCode()); // storedProcedureCode is a required field. Cannot be null.
if (updated.getStoredProcedureCode() != null) {
recordChange("storedProcedureCode", original.getStoredProcedureCode(), updated.getStoredProcedureCode());
}
recordChange("sourceUrl", original.getSourceUrl(), updated.getSourceUrl()); recordChange("sourceUrl", original.getSourceUrl(), updated.getSourceUrl());
} }
} }

5
openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/TopicRepository.java
View File

@ -383,7 +383,10 @@ public class TopicRepository extends EntityRepository<Topic> {
public void entitySpecificUpdate() { public void entitySpecificUpdate() {
recordChange("maximumMessageSize", original.getMaximumMessageSize(), updated.getMaximumMessageSize()); recordChange("maximumMessageSize", original.getMaximumMessageSize(), updated.getMaximumMessageSize());
recordChange("minimumInSyncReplicas", original.getMinimumInSyncReplicas(), updated.getMinimumInSyncReplicas()); recordChange("minimumInSyncReplicas", original.getMinimumInSyncReplicas(), updated.getMinimumInSyncReplicas());
recordChange("partitions", original.getPartitions(), updated.getPartitions()); // Partitions is a required field. Cannot be null.
if (updated.getPartitions() != null) {
recordChange("partitions", original.getPartitions(), updated.getPartitions());
}
recordChange("replicationFactor", original.getReplicationFactor(), updated.getReplicationFactor()); recordChange("replicationFactor", original.getReplicationFactor(), updated.getReplicationFactor());
recordChange("retentionTime", original.getRetentionTime(), updated.getRetentionTime()); recordChange("retentionTime", original.getRetentionTime(), updated.getRetentionTime());
recordChange("retentionSize", original.getRetentionSize(), updated.getRetentionSize()); recordChange("retentionSize", original.getRetentionSize(), updated.getRetentionSize());