yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-11-02 11:39:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove Old Deployments of Periodic Batch Entity Trigger and use hiphen to trigger to avoid accidental triggering

Browse Source
This commit is contained in:
Ram Narayan Balaji 2025-09-24 10:46:28 +05:30
parent ee66ebdb5f
commit 882891a935
1 changed files with 36 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
openmetadata-service/src/main/java/org/openmetadata/service/governance/workflows/WorkflowHandler.java
View File

@ -271,6 +271,41 @@ public class WorkflowHandler {
triggerWorkflowKey,
e.getMessage());
}
// Step 3: Delete old deployments to prevent confusion with old process definitions
// This is critical for periodicBatchEntity triggers that may have changed format
try {
// Delete old trigger deployments without entity type suffix
List<ProcessDefinition> oldTriggerDefinitions =
repositoryService
.createProcessDefinitionQuery()
.processDefinitionKey(triggerWorkflowKey)
.list();
for (ProcessDefinition pd : oldTriggerDefinitions) {
LOG.info(
"Removing old trigger deployment: {} (version: {})", pd.getKey(), pd.getVersion());
repositoryService.deleteDeployment(pd.getDeploymentId(), true);
}
// Delete old main workflow deployments
List<ProcessDefinition> oldMainDefinitions =
repositoryService
.createProcessDefinitionQuery()
.processDefinitionKey(workflowName)
.list();
for (ProcessDefinition pd : oldMainDefinitions) {
LOG.info(
"Removing old main workflow deployment: {} (version: {})",
pd.getKey(),
pd.getVersion());
repositoryService.deleteDeployment(pd.getDeploymentId(), true);
}
} catch (Exception e) {
LOG.warn(
"Error removing old deployments for workflow {}: {}", workflowName, e.getMessage());
}
}
// Deploy Main Workflow
@ -1035,7 +1070,7 @@ public class WorkflowHandler {
List<ProcessDefinition> processDefinitions =
repositoryService
.createProcessDefinitionQuery()
.processDefinitionKeyLike(baseProcessKey + "%")
.processDefinitionKeyLike(baseProcessKey + "-%")
.latestVersion()
.list();