yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-08-19 06:28:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

MINOR: Added display name and description in Testcase Alert emails (#20980)

Browse Source
This commit is contained in:
Ajith Prasad 2025-04-28 14:07:19 +05:30 committed by GitHub
parent db2027b8e7
commit 89afc86a59
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 27 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
openmetadata-service/src/main/java/org/openmetadata/service/formatter/field/TestCaseResultFormatter.java
View File

@ -1,5 +1,7 @@
package org.openmetadata.service.formatter.field; package org.openmetadata.service.formatter.field;
import java.util.Optional;
import org.openmetadata.common.utils.CommonUtil;
import org.openmetadata.schema.entity.feed.FeedInfo; import org.openmetadata.schema.entity.feed.FeedInfo;
import org.openmetadata.schema.entity.feed.TestCaseResultFeedInfo; import org.openmetadata.schema.entity.feed.TestCaseResultFeedInfo;
import org.openmetadata.schema.entity.feed.Thread; import org.openmetadata.schema.entity.feed.Thread;
@ -10,6 +12,7 @@ import org.openmetadata.schema.tests.type.TestCaseStatus;
import org.openmetadata.schema.type.FieldChange; import org.openmetadata.schema.type.FieldChange;
import org.openmetadata.schema.type.Include; import org.openmetadata.schema.type.Include;
import org.openmetadata.service.Entity; import org.openmetadata.service.Entity;
import org.openmetadata.service.formatter.decorators.EmailMessageDecorator;
import org.openmetadata.service.formatter.decorators.FeedMessageDecorator; import org.openmetadata.service.formatter.decorators.FeedMessageDecorator;
import org.openmetadata.service.formatter.decorators.MessageDecorator; import org.openmetadata.service.formatter.decorators.MessageDecorator;
import org.openmetadata.service.jdbi3.TestCaseRepository; import org.openmetadata.service.jdbi3.TestCaseRepository;
@ -90,17 +93,36 @@ public class TestCaseResultFormatter extends DefaultFieldFormatter {
TestCase testCaseEntity = TestCase testCaseEntity =
Entity.getEntity( Entity.getEntity(
thread.getEntityRef().getType(), thread.getEntityRef().getId(), "id", Include.ALL); thread.getEntityRef().getType(), thread.getEntityRef().getId(), "id", Include.ALL);
String testCaseName = testCaseEntity.getName(); String testCaseName =
CommonUtil.nullOrEmpty(testCaseEntity.getDisplayName())
? testCaseEntity.getName()
: testCaseEntity.getDisplayName();
String testCaseDescription = Optional.ofNullable(testCaseEntity.getDescription()).orElse("");
boolean hasDescription =
(messageFormatter instanceof EmailMessageDecorator)
&& !CommonUtil.nullOrEmpty(testCaseDescription);
TestCaseResult result = JsonUtils.convertValue(fieldChange.getNewValue(), TestCaseResult.class); TestCaseResult result = JsonUtils.convertValue(fieldChange.getNewValue(), TestCaseResult.class);
if (result != null) { if (result != null) {
String format = String format =
String.format( String.format(
"Test Case %s is %s in %s", "Test Case %s is %s in %s %s%s",
messageFormatter.getBold(), messageFormatter.getBold(),
messageFormatter.getBold(), messageFormatter.getBold(),
MessageParser.EntityLink.parse(testCaseEntity.getEntityLink()).getEntityFQN()); MessageParser.EntityLink.parse(testCaseEntity.getEntityLink()).getEntityFQN(),
return String.format( hasDescription
format, testCaseName, getStatusMessage(messageFormatter, result.getTestCaseStatus())); ? messageFormatter.getLineBreak() + messageFormatter.getLineBreak()
: "",
hasDescription ? "Test Case Description: %s" : "");
return hasDescription
? String.format(
format,
testCaseName,
getStatusMessage(messageFormatter, result.getTestCaseStatus()),
testCaseDescription)
: String.format(
format, testCaseName, getStatusMessage(messageFormatter, result.getTestCaseStatus()));
} }
String format = String format =
String.format( String.format(