yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-10-27 08:44:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

#10502 Show dbt node fields in the UI (#16411)

Browse Source
This commit is contained in:
Shailesh Parmar 2024-05-24 20:28:17 +05:30 committed by GitHub
parent fe2db2d63c
commit 89b1b090c7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 53 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

49
openmetadata-ui/src/main/resources/ui/src/pages/TableDetailsPageV1/TableDetailsPageV1.test.tsx
View File

@ -305,6 +305,54 @@ describe('TestDetailsPageV1 component', () => {
expect(screen.queryByText('label.view-definition')).not.toBeInTheDocument();
});
it('TableDetailsPageV1 should dbt tab for rawSql, when sql is empty', async () => {
(usePermissionProvider as jest.Mock).mockImplementationOnce(() => ({
getEntityPermissionByFqn: jest.fn().mockImplementationOnce(() => ({
ViewBasic: true,
})),
}));
(getTableDetailsByFQN as jest.Mock).mockImplementationOnce(() =>
Promise.resolve({
name: 'test',
id: '123',
tableFqn: 'fqn',
dataModel: { sql: '', rawSql: 'rawSql' },
})
);
await act(async () => {
render(<TableDetailsPageV1 />);
});
expect(await screen.findByText('label.dbt-lowercase')).toBeInTheDocument();
expect(screen.queryByText('label.view-definition')).not.toBeInTheDocument();
});
it('TableDetailsPageV1 should dbt tab for rawSql, when there is no sql available', async () => {
(usePermissionProvider as jest.Mock).mockImplementationOnce(() => ({
getEntityPermissionByFqn: jest.fn().mockImplementationOnce(() => ({
ViewBasic: true,
})),
}));
(getTableDetailsByFQN as jest.Mock).mockImplementationOnce(() =>
Promise.resolve({
name: 'test',
id: '123',
tableFqn: 'fqn',
dataModel: { rawSql: 'rawSql' },
})
);
await act(async () => {
render(<TableDetailsPageV1 />);
});
expect(await screen.findByText('label.dbt-lowercase')).toBeInTheDocument();
expect(screen.queryByText('label.view-definition')).not.toBeInTheDocument();
});
it('TableDetailsPageV1 should render schema definition tab table type is not view', async () => {
(usePermissionProvider as jest.Mock).mockImplementationOnce(() => ({
getEntityPermissionByFqn: jest.fn().mockImplementationOnce(() => ({
@ -325,6 +373,7 @@ describe('TestDetailsPageV1 component', () => {
});
expect(screen.getByText('label.schema-definition')).toBeInTheDocument();
expect(screen.queryByText('label.dbt-lowercase')).not.toBeInTheDocument();
});
it('TableDetailsPageV1 should render view definition tab if table type is view', async () => {

9
openmetadata-ui/src/main/resources/ui/src/pages/TableDetailsPageV1/TableDetailsPageV1.tsx
View File

@ -14,7 +14,7 @@ import { Col, Row, Space, Tabs, Typography } from 'antd';
import { AxiosError } from 'axios';
import classNames from 'classnames';
import { compare } from 'fast-json-patch';
import { isEmpty, isEqual, isUndefined } from 'lodash';
import { get, isEmpty, isEqual, isUndefined } from 'lodash';
import { EntityTags } from 'Models';
import React, { useCallback, useEffect, useMemo, useState } from 'react';
import { useTranslation } from 'react-i18next';
@ -733,15 +733,14 @@ const TableDetailsPageV1: React.FC = () => {
<TabsLabel id={EntityTabs.DBT} name={t('label.dbt-lowercase')} />
),
isHidden: !(
tableDetails?.dataModel?.sql ?? tableDetails?.dataModel?.rawSql
tableDetails?.dataModel?.sql || tableDetails?.dataModel?.rawSql
),
key: EntityTabs.DBT,
children: (
<QueryViewer
sqlQuery={
tableDetails?.dataModel?.sql ??
tableDetails?.dataModel?.rawSql ??
''
get(tableDetails, 'dataModel.sql', '') ||
get(tableDetails, 'dataModel.rawSql', '')
}
title={
<Space className="p-y-xss">