From 8acf6d3e94ea48faf878a83b0866a61476d50ab8 Mon Sep 17 00:00:00 2001 From: Mayur Singal <39544459+ulixius9@users.noreply.github.com> Date: Mon, 19 Aug 2024 17:37:18 +0530 Subject: [PATCH] MINOR: Make Include ddl disabled by default (#17450) * MINOR: Make Include ddl disabled by default * make schema def failure warning debug * Add missing condition --------- Co-authored-by: Pere Miquel Brull Co-authored-by: Pablo Takara --- .../metadata/ingestion/source/database/common_db_source.py | 6 +++--- .../metadataIngestion/databaseServiceMetadataPipeline.json | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/ingestion/src/metadata/ingestion/source/database/common_db_source.py b/ingestion/src/metadata/ingestion/source/database/common_db_source.py index 238168dcff8..f0589adb829 100644 --- a/ingestion/src/metadata/ingestion/source/database/common_db_source.py +++ b/ingestion/src/metadata/ingestion/source/database/common_db_source.py @@ -408,7 +408,7 @@ class CommonDbSourceService( schema_definition = inspector.get_view_definition( table_name, schema_name ) - elif hasattr(inspector, "get_table_ddl"): + elif hasattr(inspector, "get_table_ddl") and self.source_config.includeDDL: schema_definition = inspector.get_table_ddl( self.connection, table_name, schema_name ) @@ -420,11 +420,11 @@ class CommonDbSourceService( return schema_definition except NotImplementedError: - logger.warning("Schema definition not implemented") + logger.debug("Schema definition not implemented") except Exception as exc: logger.debug(traceback.format_exc()) - logger.warning(f"Failed to fetch schema definition for {table_name}: {exc}") + logger.debug(f"Failed to fetch schema definition for {table_name}: {exc}") return None def is_partition( # pylint: disable=unused-argument diff --git a/openmetadata-spec/src/main/resources/json/schema/metadataIngestion/databaseServiceMetadataPipeline.json b/openmetadata-spec/src/main/resources/json/schema/metadataIngestion/databaseServiceMetadataPipeline.json index 23363fd65c9..7a6a39f54bf 100644 --- a/openmetadata-spec/src/main/resources/json/schema/metadataIngestion/databaseServiceMetadataPipeline.json +++ b/openmetadata-spec/src/main/resources/json/schema/metadataIngestion/databaseServiceMetadataPipeline.json @@ -93,7 +93,7 @@ "includeDDL": { "description": "Optional configuration to toggle the DDL Statements ingestion.", "type": "boolean", - "default": true, + "default": false, "title": "Include DDL Statements" }, "overrideMetadata":{