yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-09-26 17:34:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

MINOR: Make Include ddl disabled by default (#17450)

Browse Source 
* MINOR: Make Include ddl disabled by default

* make schema def failure warning debug

* Add missing condition

---------

Co-authored-by: Pere Miquel Brull <peremiquelbrull@gmail.com>
Co-authored-by: Pablo Takara <pjt1991@gmail.com>
This commit is contained in:
Mayur Singal 2024-08-19 17:37:18 +05:30 committed by GitHub
parent 2b915a53e9
commit 8acf6d3e94
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ingestion/src/metadata/ingestion/source/database/common_db_source.py
View File

@ -408,7 +408,7 @@ class CommonDbSourceService(
schema_definition = inspector.get_view_definition( schema_definition = inspector.get_view_definition(
table_name, schema_name table_name, schema_name
) )
elif hasattr(inspector, "get_table_ddl"): elif hasattr(inspector, "get_table_ddl") and self.source_config.includeDDL:
schema_definition = inspector.get_table_ddl( schema_definition = inspector.get_table_ddl(
self.connection, table_name, schema_name self.connection, table_name, schema_name
) )
@ -420,11 +420,11 @@ class CommonDbSourceService(
return schema_definition return schema_definition
except NotImplementedError: except NotImplementedError:
logger.warning("Schema definition not implemented") logger.debug("Schema definition not implemented")
except Exception as exc: except Exception as exc:
logger.debug(traceback.format_exc()) logger.debug(traceback.format_exc())
logger.warning(f"Failed to fetch schema definition for {table_name}: {exc}") logger.debug(f"Failed to fetch schema definition for {table_name}: {exc}")
return None return None
def is_partition( # pylint: disable=unused-argument def is_partition( # pylint: disable=unused-argument

2
openmetadata-spec/src/main/resources/json/schema/metadataIngestion/databaseServiceMetadataPipeline.json
View File

@ -93,7 +93,7 @@
"includeDDL": { "includeDDL": {
"description": "Optional configuration to toggle the DDL Statements ingestion.", "description": "Optional configuration to toggle the DDL Statements ingestion.",
"type": "boolean", "type": "boolean",
"default": true, "default": false,
"title": "Include DDL Statements" "title": "Include DDL Statements"
}, },
"overrideMetadata":{ "overrideMetadata":{