yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-11-01 11:09:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ui): tour with permission errors on multiple steps (#12511)

Browse Source
This commit is contained in:
Chirag Madlani 2023-07-20 10:33:49 +05:30 committed by GitHub
parent 8e0fc86b4e
commit 8bac9b6ba8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 29 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

53
openmetadata-ui/src/main/resources/ui/src/pages/TableDetailsPageV1/TableDetailsPageV1.tsx
View File

@ -567,16 +567,16 @@ const TableDetailsPageV1 = () => {
),
key: EntityTabs.SAMPLE_DATA,
children: !(
tablePermissions.ViewAll || tablePermissions.ViewSampleData
) ? (
<ErrorPlaceHolder type={ERROR_PLACEHOLDER_TYPE.PERMISSION} />
) : (
<SampleDataTableComponent
isTableDeleted={tableDetails?.deleted}
tableId={tableDetails?.id ?? ''}
/>
),
children:
!isTourOpen &&
!(tablePermissions.ViewAll || tablePermissions.ViewSampleData) ? (
<ErrorPlaceHolder type={ERROR_PLACEHOLDER_TYPE.PERMISSION} />
) : (
<SampleDataTableComponent
isTableDeleted={tableDetails?.deleted}
tableId={tableDetails?.id ?? ''}
/>
),
},
{
label: (
@ -607,19 +607,21 @@ const TableDetailsPageV1 = () => {
/>
),
key: EntityTabs.PROFILER,
children: !(
tablePermissions.ViewAll ||
tablePermissions.ViewDataProfile ||
tablePermissions.ViewTests
) ? (
<ErrorPlaceHolder type={ERROR_PLACEHOLDER_TYPE.PERMISSION} />
) : (
<TableProfilerV1
isTableDeleted={tableDetails?.deleted}
permissions={tablePermissions}
testSuite={tableDetails?.testSuite}
/>
),
children:
!isTourOpen &&
!(
tablePermissions.ViewAll ||
tablePermissions.ViewDataProfile ||
tablePermissions.ViewTests
) ? (
<ErrorPlaceHolder type={ERROR_PLACEHOLDER_TYPE.PERMISSION} />
) : (
<TableProfilerV1
isTableDeleted={tableDetails?.deleted}
permissions={tablePermissions}
testSuite={tableDetails?.testSuite}
/>
),
},
{
label: <TabsLabel id={EntityTabs.LINEAGE} name={t('label.lineage')} />,
@ -860,7 +862,10 @@ const TableDetailsPageV1 = () => {
return <Loader />;
}
if (!(tablePermissions.ViewAll || tablePermissions.ViewBasic)) {
if (
!(isTourOpen || isTourPage) &&
!(tablePermissions.ViewAll || tablePermissions.ViewBasic)
) {
return (
<ErrorPlaceHolder
className="m-0"