yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-11-30 09:36:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ui): tour with permission errors on multiple steps (#12511)

Browse Source
This commit is contained in:
Chirag Madlani 2023-07-20 10:33:49 +05:30 committed by GitHub
parent 8e0fc86b4e
commit 8bac9b6ba8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 29 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

53
openmetadata-ui/src/main/resources/ui/src/pages/TableDetailsPageV1/TableDetailsPageV1.tsx
View File

@ -567,16 +567,16 @@ const TableDetailsPageV1 = () => {
), ),
key: EntityTabs.SAMPLE_DATA, key: EntityTabs.SAMPLE_DATA,
children: !( children:
tablePermissions.ViewAll || tablePermissions.ViewSampleData !isTourOpen &&
) ? ( !(tablePermissions.ViewAll || tablePermissions.ViewSampleData) ? (
<ErrorPlaceHolder type={ERROR_PLACEHOLDER_TYPE.PERMISSION} /> <ErrorPlaceHolder type={ERROR_PLACEHOLDER_TYPE.PERMISSION} />
) : ( ) : (
<SampleDataTableComponent <SampleDataTableComponent
isTableDeleted={tableDetails?.deleted} isTableDeleted={tableDetails?.deleted}
tableId={tableDetails?.id ?? ''} tableId={tableDetails?.id ?? ''}
/> />
), ),
}, },
{ {
label: ( label: (
@ -607,19 +607,21 @@ const TableDetailsPageV1 = () => {
/> />
), ),
key: EntityTabs.PROFILER, key: EntityTabs.PROFILER,
children: !( children:
tablePermissions.ViewAll || !isTourOpen &&
tablePermissions.ViewDataProfile || !(
tablePermissions.ViewTests tablePermissions.ViewAll ||
) ? ( tablePermissions.ViewDataProfile ||
<ErrorPlaceHolder type={ERROR_PLACEHOLDER_TYPE.PERMISSION} /> tablePermissions.ViewTests
) : ( ) ? (
<TableProfilerV1 <ErrorPlaceHolder type={ERROR_PLACEHOLDER_TYPE.PERMISSION} />
isTableDeleted={tableDetails?.deleted} ) : (
permissions={tablePermissions} <TableProfilerV1
testSuite={tableDetails?.testSuite} isTableDeleted={tableDetails?.deleted}
/> permissions={tablePermissions}
), testSuite={tableDetails?.testSuite}
/>
),
}, },
{ {
label: <TabsLabel id={EntityTabs.LINEAGE} name={t('label.lineage')} />, label: <TabsLabel id={EntityTabs.LINEAGE} name={t('label.lineage')} />,
@ -860,7 +862,10 @@ const TableDetailsPageV1 = () => {
return <Loader />; return <Loader />;
} }
if (!(tablePermissions.ViewAll || tablePermissions.ViewBasic)) { if (
!(isTourOpen || isTourPage) &&
!(tablePermissions.ViewAll || tablePermissions.ViewBasic)
) {
return ( return (
<ErrorPlaceHolder <ErrorPlaceHolder
className="m-0" className="m-0"