yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-11-09 15:32:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix Superset Owners & Descriptions (#10007)

Browse Source
This commit is contained in:
Mayur Singal 2023-01-30 20:10:52 +05:30 committed by GitHub
parent c7c3d62bae
commit 8c7c21bd54
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 19 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ingestion/src/metadata/ingestion/source/dashboard/superset/api_source.py
View File

@ -143,7 +143,7 @@ class SupersetAPISource(SupersetSourceMixin):
chart = CreateChartRequest( chart = CreateChartRequest(
name=chart_json["id"], name=chart_json["id"],
displayName=chart_json.get("slice_name"), displayName=chart_json.get("slice_name"),
description="", description=chart_json.get("description"),
chartType=get_standard_chart_type( chartType=get_standard_chart_type(
chart_json.get("viz_type", ChartType.Other.value) chart_json.get("viz_type", ChartType.Other.value)
), ),

2
ingestion/src/metadata/ingestion/source/dashboard/superset/db_source.py
View File

@ -147,7 +147,7 @@ class SupersetDBSource(SupersetSourceMixin):
chart = CreateChartRequest( chart = CreateChartRequest(
name=chart_json["id"], name=chart_json["id"],
displayName=chart_json.get("slice_name"), displayName=chart_json.get("slice_name"),
description="", description=chart_json.get("description"),
chartType=get_standard_chart_type( chartType=get_standard_chart_type(
chart_json.get("viz_type", ChartType.Other.value) chart_json.get("viz_type", ChartType.Other.value)
), ),

19
ingestion/src/metadata/ingestion/source/dashboard/superset/mixin.py
View File

@ -69,11 +69,24 @@ class SupersetSourceMixin(DashboardServiceSource):
""" """
return dashboard return dashboard
def get_owner_details(self, dashboard_details: dict) -> EntityReference: def _get_user_by_email(self, email: str) -> EntityReference:
if dashboard_details.get("email"):
user = self.metadata.get_user_by_email(dashboard_details["email"]) if email:
user = self.metadata.get_user_by_email(email)
if user: if user:
return EntityReference(id=user.id.__root__, type="user") return EntityReference(id=user.id.__root__, type="user")
return None
def get_owner_details(self, dashboard_details: dict) -> EntityReference:
for owner in dashboard_details.get("owners", []):
user = self._get_user_by_email(owner["email"])
if user:
return user
if dashboard_details.get("email"):
user = self._get_user_by_email(dashboard_details["email"])
if user:
return user
return None return None
def _get_charts_of_dashboard(self, dashboard_details: dict) -> List[str]: def _get_charts_of_dashboard(self, dashboard_details: dict) -> List[str]:

1
ingestion/src/metadata/ingestion/source/dashboard/superset/queries.py
View File

@ -16,6 +16,7 @@ FETCH_ALL_CHARTS = """
select select
s.id, s.id,
s.slice_name, s.slice_name,
s.description,
t.table_name, t.table_name,
t.schema, t.schema,
db.database_name, db.database_name,