From 9012c738e01685d9a577d52d6ea4196b6ba1688d Mon Sep 17 00:00:00 2001
From: harshsoni2024 <64592571+harshsoni2024@users.noreply.github.com>
Date: Mon, 8 Jul 2024 18:45:37 +0530
Subject: [PATCH] MINOR: Redshift view lineage error (#16947)

* fix create view query in view lineage

* fix view_defs for normal view and late binding view
---
 .../source/database/redshift/queries.py       | 28 +++++++++++++++++--
 1 file changed, 26 insertions(+), 2 deletions(-)

diff --git a/ingestion/src/metadata/ingestion/source/database/redshift/queries.py b/ingestion/src/metadata/ingestion/source/database/redshift/queries.py
index 23edf4b89f7..2ae5cf40dc3 100644
--- a/ingestion/src/metadata/ingestion/source/database/redshift/queries.py
+++ b/ingestion/src/metadata/ingestion/source/database/redshift/queries.py
@@ -237,6 +237,30 @@ REDSHIFT_TEST_PARTITION_DETAILS = "select * from SVV_TABLE_INFO limit 1"
 # hence we are appending "create view <schema>.<table> as " to select query
 # to generate the column level lineage
 REDSHIFT_GET_ALL_RELATIONS = """
+  WITH view_defs AS (
+      SELECT
+          c.oid,
+          pg_catalog.pg_get_viewdef(c.oid, true) AS view_definition,
+          n.nspname,
+          c.relname
+      FROM
+          pg_catalog.pg_class c
+          LEFT JOIN pg_catalog.pg_namespace n ON n.oid = c.relnamespace
+      WHERE
+          c.relkind = 'v'
+    ),
+    adjusted_view_defs AS (
+        SELECT
+            oid,
+            CASE
+                WHEN view_definition LIKE '%WITH NO SCHEMA BINDING%' THEN
+                  REGEXP_REPLACE(view_definition, 'create view [^ ]+ as (.*WITH NO SCHEMA BINDING;?)', '\\1')
+                ELSE
+                  'CREATE VIEW ' || nspname || '.' || relname || ' AS ' || view_definition
+            END AS view_definition
+        FROM
+            view_defs
+    )
     SELECT
         c.relkind,
         n.oid as "schema_oid",
@@ -248,13 +272,13 @@ REDSHIFT_GET_ALL_RELATIONS = """
         AS "diststyle",
         c.relowner AS "owner_id",
         u.usename AS "owner_name",
-        TRIM(TRAILING ';' FROM
-        'create view ' || n.nspname || '.' || c.relname || ' as ' ||pg_catalog.pg_get_viewdef(c.oid, true))
+        avd.view_definition 
         AS "view_definition",
         pg_catalog.array_to_string(c.relacl, '\n') AS "privileges"
     FROM pg_catalog.pg_class c
             LEFT JOIN pg_catalog.pg_namespace n ON n.oid = c.relnamespace
             JOIN pg_catalog.pg_user u ON u.usesysid = c.relowner
+            LEFT JOIN adjusted_view_defs avd ON avd.oid = c.oid
     WHERE c.relkind IN ('r', 'v', 'm', 'S', 'f')
         AND n.nspname !~ '^pg_' {schema_clause} {table_clause}
     UNION