From 924a100ab42a5c63115245cf08cfef233d28dfdf Mon Sep 17 00:00:00 2001 From: Teddy Date: Tue, 16 Jul 2024 08:12:39 +0200 Subject: [PATCH] [GEN-876] Implement DQ dimension filter for test cases (#17032) * fix: typo in key for data dimension * fix: table test key typo in data dimension * fix: typo in migration util * fix: add filter test cases by dimensions in search API * style: ran java linting --- .../service/jdbi3/EntityRepository.java | 7 ++++++- .../migration/utils/v150/MigrationUtil.java | 2 +- .../resources/dqtests/TestCaseResource.java | 9 ++++++++- .../service/search/SearchListFilter.java | 6 ++++++ .../service/search/indexes/TestCaseIndex.java | 14 +++++--------- .../elasticsearch/en/test_case_index_mapping.json | 3 +++ .../elasticsearch/jp/test_case_index_mapping.json | 3 +++ .../elasticsearch/zh/test_case_index_mapping.json | 3 +++ .../json/data/tests/columnValueMaxToBeBetween.json | 2 +- .../data/tests/columnValueMeanToBeBetween.json | 2 +- .../data/tests/columnValueMedianToBeBetween.json | 2 +- .../json/data/tests/columnValueMinToBeBetween.json | 2 +- .../data/tests/columnValueStdDevToBeBetween.json | 2 +- .../data/tests/columnValuesLengthsToBeBetween.json | 2 +- .../tests/columnValuesMissingCountToBeEqual.json | 2 +- .../data/tests/columnValuesSumToBeBetween.json | 2 +- .../json/data/tests/columnValuesToBeBetween.json | 2 +- .../json/data/tests/columnValuesToBeInSet.json | 2 +- .../json/data/tests/columnValuesToBeNotInSet.json | 2 +- .../json/data/tests/columnValuesToBeNotNull.json | 2 +- .../json/data/tests/columnValuesToBeUnique.json | 2 +- .../json/data/tests/columnValuesToMatchRegex.json | 2 +- .../data/tests/columnValuesToNotMatchRegex.json | 2 +- .../data/tests/tableColumnCountToBeBetween.json | 2 +- .../json/data/tests/tableColumnCountToEqual.json | 2 +- .../json/data/tests/tableColumnNameToExist.json | 2 +- .../json/data/tests/tableColumnToMatchSet.json | 2 +- .../json/data/tests/tableCustomSQLQuery.json | 2 +- .../main/resources/json/data/tests/tableDiff.json | 2 +- .../json/data/tests/tableRowCountToBeBetween.json | 2 +- .../json/data/tests/tableRowCountToEqual.json | 2 +- .../tests/tableRowInsertedCountToBeBetween.json | 2 +- .../resources/dqtests/TestCaseResourceTest.java | 6 ++++++ .../json/schema/tests/testDefinition.json | 2 +- 34 files changed, 66 insertions(+), 37 deletions(-) diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/EntityRepository.java b/openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/EntityRepository.java index 005785b82a9..acdc4e2773c 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/EntityRepository.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/EntityRepository.java @@ -1068,8 +1068,13 @@ public abstract class EntityRepository { entityList.add(withHref(uriInfo, entity)); } return new ResultList<>(entityList, offset, limit, total.intValue()); + } else { + SearchClient.SearchResultListMapper results = + searchRepository.listWithOffset( + searchListFilter, limit, offset, entityType, searchSortFilter, q); + total = results.getTotal(); + return new ResultList<>(entityList, null, limit, total.intValue()); } - throw new IllegalArgumentException("Limit should be greater than 0"); } @Transaction diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/migration/utils/v150/MigrationUtil.java b/openmetadata-service/src/main/java/org/openmetadata/service/migration/utils/v150/MigrationUtil.java index 451c1c94038..88eec61f866 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/migration/utils/v150/MigrationUtil.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/migration/utils/v150/MigrationUtil.java @@ -64,7 +64,7 @@ public class MigrationUtil { testCaseDefinition.getFullyQualifiedName()); return; } - testCaseDefinition.setDatatQualityDimension(dimension); + testCaseDefinition.setDataQualityDimension(dimension); collectionDAO.testDefinitionDAO().update(testCaseDefinition); } catch (Exception e) { LOG.warn("Error migrating test case dimension", e); diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/resources/dqtests/TestCaseResource.java b/openmetadata-service/src/main/java/org/openmetadata/service/resources/dqtests/TestCaseResource.java index 186d13d2ed5..f930efe4c0d 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/resources/dqtests/TestCaseResource.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/resources/dqtests/TestCaseResource.java @@ -91,7 +91,7 @@ public class TestCaseResource extends EntityResource { String tags = getQueryParam("tags"); String tier = getQueryParam("tier"); String serviceName = getQueryParam("serviceName"); + String dataQualityDimension = getQueryParam("dataQualityDimension"); if (tags != null) { String tagsList = @@ -209,6 +210,11 @@ public class SearchListFilter extends Filter { getTimestampFilter("testCaseResult.timestamp", "lte", Long.parseLong(endTimestamp))); } + if (dataQualityDimension != null) { + conditions.add( + String.format("{\"term\": {\"dataQualityDimension\": \"%s\"}}", dataQualityDimension)); + } + return addCondition(conditions); } diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/search/indexes/TestCaseIndex.java b/openmetadata-service/src/main/java/org/openmetadata/service/search/indexes/TestCaseIndex.java index a4754a2f288..29a16d2f599 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/search/indexes/TestCaseIndex.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/search/indexes/TestCaseIndex.java @@ -4,11 +4,9 @@ import java.util.ArrayList; import java.util.List; import java.util.Map; import java.util.Set; -import java.util.UUID; import lombok.SneakyThrows; import org.openmetadata.schema.tests.TestCase; import org.openmetadata.schema.tests.TestDefinition; -import org.openmetadata.schema.tests.TestPlatform; import org.openmetadata.schema.tests.TestSuite; import org.openmetadata.schema.type.EntityReference; import org.openmetadata.schema.type.Include; @@ -33,6 +31,9 @@ public record TestCaseIndex(TestCase testCase) implements SearchIndex { public Map buildSearchIndexDocInternal(Map doc) { // Build Index Doc List suggest = new ArrayList<>(); + TestDefinition testDefinition = + Entity.getEntity( + Entity.TEST_DEFINITION, testCase.getTestDefinition().getId(), "", Include.ALL); suggest.add(SearchSuggest.builder().input(testCase.getFullyQualifiedName()).weight(5).build()); suggest.add(SearchSuggest.builder().input(testCase.getName()).weight(10).build()); doc.put( @@ -44,18 +45,13 @@ public record TestCaseIndex(TestCase testCase) implements SearchIndex { doc.put("entityType", Entity.TEST_CASE); doc.put("owner", getEntityWithDisplayName(testCase.getOwner())); doc.put("tags", testCase.getTags()); - doc.put("testPlatforms", getTestDefinitionPlatforms(testCase.getTestDefinition().getId())); + doc.put("testPlatforms", testDefinition.getTestPlatforms()); + doc.put("dataQualityDimension", testDefinition.getDataQualityDimension()); doc.put("followers", SearchIndexUtils.parseFollowers(testCase.getFollowers())); setParentRelationships(doc, testCase); return doc; } - private List getTestDefinitionPlatforms(UUID testDefinitionId) { - TestDefinition testDefinition = - Entity.getEntity(Entity.TEST_DEFINITION, testDefinitionId, "", Include.ALL); - return testDefinition.getTestPlatforms(); - } - private void setParentRelationships(Map doc, TestCase testCase) { // denormalize the parent relationships for search EntityReference testSuiteEntityReference = testCase.getTestSuite(); diff --git a/openmetadata-service/src/main/resources/elasticsearch/en/test_case_index_mapping.json b/openmetadata-service/src/main/resources/elasticsearch/en/test_case_index_mapping.json index f2c822d5f16..a67086f5e7b 100644 --- a/openmetadata-service/src/main/resources/elasticsearch/en/test_case_index_mapping.json +++ b/openmetadata-service/src/main/resources/elasticsearch/en/test_case_index_mapping.json @@ -169,6 +169,9 @@ "entityType": { "type": "keyword" }, + "dataQualityDimension": { + "type": "keyword" + }, "suggest": { "type": "completion", "contexts": [ diff --git a/openmetadata-service/src/main/resources/elasticsearch/jp/test_case_index_mapping.json b/openmetadata-service/src/main/resources/elasticsearch/jp/test_case_index_mapping.json index 521b7167be1..8ee7acfc215 100644 --- a/openmetadata-service/src/main/resources/elasticsearch/jp/test_case_index_mapping.json +++ b/openmetadata-service/src/main/resources/elasticsearch/jp/test_case_index_mapping.json @@ -192,6 +192,9 @@ "entityType": { "type": "keyword" }, + "dataQualityDimension": { + "type": "keyword" + }, "suggest": { "type": "completion", "contexts": [ diff --git a/openmetadata-service/src/main/resources/elasticsearch/zh/test_case_index_mapping.json b/openmetadata-service/src/main/resources/elasticsearch/zh/test_case_index_mapping.json index d83db090bdd..097d105b569 100644 --- a/openmetadata-service/src/main/resources/elasticsearch/zh/test_case_index_mapping.json +++ b/openmetadata-service/src/main/resources/elasticsearch/zh/test_case_index_mapping.json @@ -215,6 +215,9 @@ "entityType": { "type": "keyword" }, + "dataQualityDimension": { + "type": "keyword" + }, "suggest": { "type": "completion", "contexts": [ diff --git a/openmetadata-service/src/main/resources/json/data/tests/columnValueMaxToBeBetween.json b/openmetadata-service/src/main/resources/json/data/tests/columnValueMaxToBeBetween.json index d3bceabf41f..7a249401f31 100644 --- a/openmetadata-service/src/main/resources/json/data/tests/columnValueMaxToBeBetween.json +++ b/openmetadata-service/src/main/resources/json/data/tests/columnValueMaxToBeBetween.json @@ -30,6 +30,6 @@ ], "supportsDynamicAssertion": true, "provider": "system", - "datatQualityDimension": "Accuracy" + "dataQualityDimension": "Accuracy" } diff --git a/openmetadata-service/src/main/resources/json/data/tests/columnValueMeanToBeBetween.json b/openmetadata-service/src/main/resources/json/data/tests/columnValueMeanToBeBetween.json index b328ea03ffb..f35498444d4 100644 --- a/openmetadata-service/src/main/resources/json/data/tests/columnValueMeanToBeBetween.json +++ b/openmetadata-service/src/main/resources/json/data/tests/columnValueMeanToBeBetween.json @@ -30,6 +30,6 @@ ], "supportsDynamicAssertion": true, "provider": "system", - "datatQualityDimension": "Accuracy" + "dataQualityDimension": "Accuracy" } \ No newline at end of file diff --git a/openmetadata-service/src/main/resources/json/data/tests/columnValueMedianToBeBetween.json b/openmetadata-service/src/main/resources/json/data/tests/columnValueMedianToBeBetween.json index 6e3812c4330..f439aebcb3f 100644 --- a/openmetadata-service/src/main/resources/json/data/tests/columnValueMedianToBeBetween.json +++ b/openmetadata-service/src/main/resources/json/data/tests/columnValueMedianToBeBetween.json @@ -30,6 +30,6 @@ ], "supportsDynamicAssertion": true, "provider": "system", - "datatQualityDimension": "Accuracy" + "dataQualityDimension": "Accuracy" } \ No newline at end of file diff --git a/openmetadata-service/src/main/resources/json/data/tests/columnValueMinToBeBetween.json b/openmetadata-service/src/main/resources/json/data/tests/columnValueMinToBeBetween.json index 533ccdd3d75..e7abf583220 100644 --- a/openmetadata-service/src/main/resources/json/data/tests/columnValueMinToBeBetween.json +++ b/openmetadata-service/src/main/resources/json/data/tests/columnValueMinToBeBetween.json @@ -30,6 +30,6 @@ ], "supportsDynamicAssertion": true, "provider": "system", - "datatQualityDimension": "Accuracy" + "dataQualityDimension": "Accuracy" } \ No newline at end of file diff --git a/openmetadata-service/src/main/resources/json/data/tests/columnValueStdDevToBeBetween.json b/openmetadata-service/src/main/resources/json/data/tests/columnValueStdDevToBeBetween.json index c1e70c8f35b..ce2ada6653c 100644 --- a/openmetadata-service/src/main/resources/json/data/tests/columnValueStdDevToBeBetween.json +++ b/openmetadata-service/src/main/resources/json/data/tests/columnValueStdDevToBeBetween.json @@ -30,6 +30,6 @@ ], "supportsDynamicAssertion": true, "provider": "system", - "datatQualityDimension": "Accuracy" + "dataQualityDimension": "Accuracy" } \ No newline at end of file diff --git a/openmetadata-service/src/main/resources/json/data/tests/columnValuesLengthsToBeBetween.json b/openmetadata-service/src/main/resources/json/data/tests/columnValuesLengthsToBeBetween.json index 59cbfb91f9c..ff860e33f6c 100644 --- a/openmetadata-service/src/main/resources/json/data/tests/columnValuesLengthsToBeBetween.json +++ b/openmetadata-service/src/main/resources/json/data/tests/columnValuesLengthsToBeBetween.json @@ -31,5 +31,5 @@ "supportsRowLevelPassedFailed": true, "supportsDynamicAssertion": true, "provider": "system", - "datatQualityDimension": "Accuracy" + "dataQualityDimension": "Accuracy" } diff --git a/openmetadata-service/src/main/resources/json/data/tests/columnValuesMissingCountToBeEqual.json b/openmetadata-service/src/main/resources/json/data/tests/columnValuesMissingCountToBeEqual.json index 4ad21cf50a1..8d38b22eee4 100644 --- a/openmetadata-service/src/main/resources/json/data/tests/columnValuesMissingCountToBeEqual.json +++ b/openmetadata-service/src/main/resources/json/data/tests/columnValuesMissingCountToBeEqual.json @@ -22,5 +22,5 @@ } ], "provider": "system", - "datatQualityDimension": "Completeness" + "dataQualityDimension": "Completeness" } diff --git a/openmetadata-service/src/main/resources/json/data/tests/columnValuesSumToBeBetween.json b/openmetadata-service/src/main/resources/json/data/tests/columnValuesSumToBeBetween.json index 605171a15a3..0ffec350725 100644 --- a/openmetadata-service/src/main/resources/json/data/tests/columnValuesSumToBeBetween.json +++ b/openmetadata-service/src/main/resources/json/data/tests/columnValuesSumToBeBetween.json @@ -30,6 +30,6 @@ ], "supportsDynamicAssertion": true, "provider": "system", - "datatQualityDimension": "Accuracy" + "dataQualityDimension": "Accuracy" } \ No newline at end of file diff --git a/openmetadata-service/src/main/resources/json/data/tests/columnValuesToBeBetween.json b/openmetadata-service/src/main/resources/json/data/tests/columnValuesToBeBetween.json index 57734bb62c5..0aec8128c36 100644 --- a/openmetadata-service/src/main/resources/json/data/tests/columnValuesToBeBetween.json +++ b/openmetadata-service/src/main/resources/json/data/tests/columnValuesToBeBetween.json @@ -31,5 +31,5 @@ "supportsRowLevelPassedFailed": true, "supportsDynamicAssertion": true, "provider": "system", - "datatQualityDimension": "Accuracy" + "dataQualityDimension": "Accuracy" } diff --git a/openmetadata-service/src/main/resources/json/data/tests/columnValuesToBeInSet.json b/openmetadata-service/src/main/resources/json/data/tests/columnValuesToBeInSet.json index 6144a34487e..869ef35a22a 100644 --- a/openmetadata-service/src/main/resources/json/data/tests/columnValuesToBeInSet.json +++ b/openmetadata-service/src/main/resources/json/data/tests/columnValuesToBeInSet.json @@ -24,5 +24,5 @@ ], "supportsRowLevelPassedFailed": true, "provider": "system", - "datatQualityDimension": "Validity" + "dataQualityDimension": "Validity" } diff --git a/openmetadata-service/src/main/resources/json/data/tests/columnValuesToBeNotInSet.json b/openmetadata-service/src/main/resources/json/data/tests/columnValuesToBeNotInSet.json index ecf61032dda..bc9d2e24b09 100644 --- a/openmetadata-service/src/main/resources/json/data/tests/columnValuesToBeNotInSet.json +++ b/openmetadata-service/src/main/resources/json/data/tests/columnValuesToBeNotInSet.json @@ -17,5 +17,5 @@ ], "supportsRowLevelPassedFailed": true, "provider": "system", - "datatQualityDimension": "Validity" + "dataQualityDimension": "Validity" } diff --git a/openmetadata-service/src/main/resources/json/data/tests/columnValuesToBeNotNull.json b/openmetadata-service/src/main/resources/json/data/tests/columnValuesToBeNotNull.json index 62b0f0eef84..c845cc5062b 100644 --- a/openmetadata-service/src/main/resources/json/data/tests/columnValuesToBeNotNull.json +++ b/openmetadata-service/src/main/resources/json/data/tests/columnValuesToBeNotNull.json @@ -8,5 +8,5 @@ "supportedDataTypes": ["NUMBER","TINYINT","SMALLINT","INT","BIGINT","BYTEINT","BYTES","FLOAT","DOUBLE","DECIMAL","NUMERIC","TIMESTAMP","TIMESTAMPZ","TIME","DATE","DATETIME","INTERVAL","STRING","MEDIUMTEXT","TEXT","CHAR","VARCHAR","BOOLEAN","BINARY","VARBINARY","ARRAY","BLOB","LONGBLOB","MEDIUMBLOB","MAP","STRUCT","UNION","SET","GEOGRAPHY","ENUM","JSON","UUID","VARIANT","GEOMETRY","POINT","POLYGON"], "supportsRowLevelPassedFailed": true, "provider": "system", - "datatQualityDimension": "Completeness" + "dataQualityDimension": "Completeness" } diff --git a/openmetadata-service/src/main/resources/json/data/tests/columnValuesToBeUnique.json b/openmetadata-service/src/main/resources/json/data/tests/columnValuesToBeUnique.json index 89dc8dec002..390cd93aa3e 100644 --- a/openmetadata-service/src/main/resources/json/data/tests/columnValuesToBeUnique.json +++ b/openmetadata-service/src/main/resources/json/data/tests/columnValuesToBeUnique.json @@ -8,5 +8,5 @@ "supportedDataTypes": ["NUMBER","TINYINT","SMALLINT","INT","BIGINT","BYTEINT","BYTES","FLOAT","DOUBLE","DECIMAL","NUMERIC","TIMESTAMP","TIMESTAMPZ","TIME","DATE","DATETIME","INTERVAL","STRING","MEDIUMTEXT","TEXT","CHAR","VARCHAR","BOOLEAN","BINARY","VARBINARY","ARRAY","BLOB","LONGBLOB","MEDIUMBLOB","MAP","STRUCT","UNION","SET","GEOGRAPHY","ENUM","JSON","UUID","VARIANT","GEOMETRY","POINT","POLYGON"], "supportsRowLevelPassedFailed": true, "provider": "system", - "datatQualityDimension": "Uniqueness" + "dataQualityDimension": "Uniqueness" } diff --git a/openmetadata-service/src/main/resources/json/data/tests/columnValuesToMatchRegex.json b/openmetadata-service/src/main/resources/json/data/tests/columnValuesToMatchRegex.json index 842c93435af..7e224b5cd9c 100644 --- a/openmetadata-service/src/main/resources/json/data/tests/columnValuesToMatchRegex.json +++ b/openmetadata-service/src/main/resources/json/data/tests/columnValuesToMatchRegex.json @@ -17,5 +17,5 @@ ], "supportsRowLevelPassedFailed": true, "provider": "system", - "datatQualityDimension": "Validity" + "dataQualityDimension": "Validity" } diff --git a/openmetadata-service/src/main/resources/json/data/tests/columnValuesToNotMatchRegex.json b/openmetadata-service/src/main/resources/json/data/tests/columnValuesToNotMatchRegex.json index 8e99d86b44d..58611ce8ed5 100644 --- a/openmetadata-service/src/main/resources/json/data/tests/columnValuesToNotMatchRegex.json +++ b/openmetadata-service/src/main/resources/json/data/tests/columnValuesToNotMatchRegex.json @@ -17,5 +17,5 @@ ], "supportsRowLevelPassedFailed": true, "provider": "system", - "datatQualityDimension": "Validity" + "dataQualityDimension": "Validity" } diff --git a/openmetadata-service/src/main/resources/json/data/tests/tableColumnCountToBeBetween.json b/openmetadata-service/src/main/resources/json/data/tests/tableColumnCountToBeBetween.json index 1327803214c..e0ebddb1001 100644 --- a/openmetadata-service/src/main/resources/json/data/tests/tableColumnCountToBeBetween.json +++ b/openmetadata-service/src/main/resources/json/data/tests/tableColumnCountToBeBetween.json @@ -28,5 +28,5 @@ } ], "provider": "system", - "datatQualityDimension": "Integrity" + "dataQualityDimension": "Integrity" } \ No newline at end of file diff --git a/openmetadata-service/src/main/resources/json/data/tests/tableColumnCountToEqual.json b/openmetadata-service/src/main/resources/json/data/tests/tableColumnCountToEqual.json index 875a09302ae..77f1f563b58 100644 --- a/openmetadata-service/src/main/resources/json/data/tests/tableColumnCountToEqual.json +++ b/openmetadata-service/src/main/resources/json/data/tests/tableColumnCountToEqual.json @@ -15,5 +15,5 @@ } ], "provider": "system", - "datatQualityDimension": "Integrity" + "dataQualityDimension": "Integrity" } \ No newline at end of file diff --git a/openmetadata-service/src/main/resources/json/data/tests/tableColumnNameToExist.json b/openmetadata-service/src/main/resources/json/data/tests/tableColumnNameToExist.json index e55d67a6de0..00b2bbf31c9 100644 --- a/openmetadata-service/src/main/resources/json/data/tests/tableColumnNameToExist.json +++ b/openmetadata-service/src/main/resources/json/data/tests/tableColumnNameToExist.json @@ -15,6 +15,6 @@ } ], "provider": "system", - "datatQualityDimension": "Integrity" + "dataQualityDimension": "Integrity" } \ No newline at end of file diff --git a/openmetadata-service/src/main/resources/json/data/tests/tableColumnToMatchSet.json b/openmetadata-service/src/main/resources/json/data/tests/tableColumnToMatchSet.json index 4adab08c91b..494be43bc2b 100644 --- a/openmetadata-service/src/main/resources/json/data/tests/tableColumnToMatchSet.json +++ b/openmetadata-service/src/main/resources/json/data/tests/tableColumnToMatchSet.json @@ -21,6 +21,6 @@ } ], "provider": "system", - "datatQualityDimension": "Integrity" + "dataQualityDimension": "Integrity" } \ No newline at end of file diff --git a/openmetadata-service/src/main/resources/json/data/tests/tableCustomSQLQuery.json b/openmetadata-service/src/main/resources/json/data/tests/tableCustomSQLQuery.json index f4687ee61c8..455602169a3 100644 --- a/openmetadata-service/src/main/resources/json/data/tests/tableCustomSQLQuery.json +++ b/openmetadata-service/src/main/resources/json/data/tests/tableCustomSQLQuery.json @@ -30,6 +30,6 @@ } ], "provider": "system", - "datatQualityDimension": "SQL" + "dataQualityDimension": "SQL" } \ No newline at end of file diff --git a/openmetadata-service/src/main/resources/json/data/tests/tableDiff.json b/openmetadata-service/src/main/resources/json/data/tests/tableDiff.json index d35315ed63f..074284eef39 100644 --- a/openmetadata-service/src/main/resources/json/data/tests/tableDiff.json +++ b/openmetadata-service/src/main/resources/json/data/tests/tableDiff.json @@ -45,6 +45,6 @@ } ], "provider": "system", - "datatQualityDimension": "Consistency" + "dataQualityDimension": "Consistency" } \ No newline at end of file diff --git a/openmetadata-service/src/main/resources/json/data/tests/tableRowCountToBeBetween.json b/openmetadata-service/src/main/resources/json/data/tests/tableRowCountToBeBetween.json index 5d7de7f7133..25c06eb85e1 100644 --- a/openmetadata-service/src/main/resources/json/data/tests/tableRowCountToBeBetween.json +++ b/openmetadata-service/src/main/resources/json/data/tests/tableRowCountToBeBetween.json @@ -29,5 +29,5 @@ ], "supportsDynamicAssertion": true, "provider": "system", - "datatQualityDimension": "Integrity" + "dataQualityDimension": "Integrity" } diff --git a/openmetadata-service/src/main/resources/json/data/tests/tableRowCountToEqual.json b/openmetadata-service/src/main/resources/json/data/tests/tableRowCountToEqual.json index 8b7cf02140c..93eef74cb98 100644 --- a/openmetadata-service/src/main/resources/json/data/tests/tableRowCountToEqual.json +++ b/openmetadata-service/src/main/resources/json/data/tests/tableRowCountToEqual.json @@ -15,5 +15,5 @@ } ], "provider": "system", - "datatQualityDimension": "Integrity" + "dataQualityDimension": "Integrity" } diff --git a/openmetadata-service/src/main/resources/json/data/tests/tableRowInsertedCountToBeBetween.json b/openmetadata-service/src/main/resources/json/data/tests/tableRowInsertedCountToBeBetween.json index 582c927e2f2..589cc3da2ed 100644 --- a/openmetadata-service/src/main/resources/json/data/tests/tableRowInsertedCountToBeBetween.json +++ b/openmetadata-service/src/main/resources/json/data/tests/tableRowInsertedCountToBeBetween.json @@ -51,6 +51,6 @@ } ], "provider": "system", - "datatQualityDimension": "Integrity" + "dataQualityDimension": "Integrity" } \ No newline at end of file diff --git a/openmetadata-service/src/test/java/org/openmetadata/service/resources/dqtests/TestCaseResourceTest.java b/openmetadata-service/src/test/java/org/openmetadata/service/resources/dqtests/TestCaseResourceTest.java index 56ab512ec4b..a74422d8604 100644 --- a/openmetadata-service/src/test/java/org/openmetadata/service/resources/dqtests/TestCaseResourceTest.java +++ b/openmetadata-service/src/test/java/org/openmetadata/service/resources/dqtests/TestCaseResourceTest.java @@ -924,6 +924,12 @@ public class TestCaseResourceTest extends EntityResourceTest