From 942649f3b6dcf0d7e180ba90278dc6749ec74db3 Mon Sep 17 00:00:00 2001 From: Aniket Katkar Date: Thu, 6 Apr 2023 19:42:17 +0530 Subject: [PATCH] fixes #10755: Changed description change method for service connections from 'Put' to 'PATCH' (#10876) * Changed description change method for service connections from 'Put' to 'PATCH' * worked on comments --------- Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com> --- .../resources/ui/src/pages/service/index.tsx | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/openmetadata-ui/src/main/resources/ui/src/pages/service/index.tsx b/openmetadata-ui/src/main/resources/ui/src/pages/service/index.tsx index 5e3992ab80f..d23cf543917 100644 --- a/openmetadata-ui/src/main/resources/ui/src/pages/service/index.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/pages/service/index.tsx @@ -753,21 +753,16 @@ const ServicePage: FunctionComponent = () => { if (description !== updatedHTML && !isUndefined(serviceDetails)) { const { id } = serviceDetails; - const updatedServiceDetails = { - connection: serviceDetails?.connection, - name: serviceDetails.name, - serviceType: serviceDetails.serviceType, + const updatedData: ServicesType = { + ...serviceDetails, description: updatedHTML, - owner: serviceDetails.owner, - } as ServicesUpdateRequest; + }; + + const jsonPatch = compare(serviceDetails, updatedData); try { - const response = await updateService( - serviceName, - id, - updatedServiceDetails - ); - setDescription(updatedHTML); + const response = await updateOwnerService(serviceName, id, jsonPatch); + setDescription(response.description ?? ''); setServiceDetails(response); } catch (error) { showErrorToast(error as AxiosError);