yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-11-03 12:08:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix: issue-612 fixed sampleData breaks (#630)

Browse Source 
* Fix: issue-612 fixed sampleData breaks

* optimised conditional rendering
This commit is contained in:
Shailesh Parmar 2021-10-01 18:50:50 +05:30 committed by GitHub
parent b231e68c6e
commit 9671850c55
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 53 additions and 47 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

96
catalog-rest-service/src/main/resources/ui/src/components/my-data-details/SampleDataTable.tsx
View File

@ -24,60 +24,66 @@ import { isEven } from '../../utils/CommonUtils';
export type SampleColumns = { name: string; dataType: string };
type Props = {
sampleData: {
columns: Array<SampleColumns>;
rows: TableData['rows'];
sampleData?: {
columns?: Array<SampleColumns>;
rows?: TableData['rows'];
};
};
const SampleDataTable: FunctionComponent<Props> = ({ sampleData }: Props) => {
return (
<div className="tw-table-responsive">
<table
className="tw-min-w-max tw-w-full tw-table-auto"
data-testid="sample-data-table">
<thead>
<tr className="tableHead-row">
{sampleData.columns.map((column) => {
{sampleData?.rows && sampleData?.columns ? (
<table
className="tw-min-w-max tw-w-full tw-table-auto"
data-testid="sample-data-table">
<thead>
<tr className="tableHead-row">
{sampleData.columns.map((column) => {
return (
<th
className="tableHead-cell"
data-testid="column-name"
key={column.name}>
{column.name}
<span className="tw-py-0.5 tw-px-1 tw-ml-1 tw-rounded tw-text-grey-muted">
({lowerCase(column.dataType)})
</span>
</th>
);
})}
</tr>
</thead>
<tbody className="tw-text-gray-600 tw-text-sm">
{sampleData?.rows?.map((row, rowIndex) => {
return (
<th
className="tableHead-cell"
data-testid="column-name"
key={column.name}>
{column.name}
<span className="tw-py-0.5 tw-px-1 tw-ml-1 tw-rounded tw-text-grey-muted">
({lowerCase(column.dataType)})
</span>
</th>
<tr
className={classNames(
'tableBody-row',
!isEven(rowIndex + 1) ? 'odd-row' : null
)}
data-testid="row"
key={rowIndex}>
{row.map((data, index) => {
return (
<td
className="tableBody-cell"
data-testid="cell"
key={index}>
{data ? data.toString() : '--'}
</td>
);
})}
</tr>
);
})}
</tr>
</thead>
<tbody className="tw-text-gray-600 tw-text-sm">
{sampleData?.rows?.map((row, rowIndex) => {
return (
<tr
className={classNames(
'tableBody-row',
!isEven(rowIndex + 1) ? 'odd-row' : null
)}
data-testid="row"
key={rowIndex}>
{row.map((data, index) => {
return (
<td
className="tableBody-cell"
data-testid="cell"
key={index}>
{data ? data.toString() : '--'}
</td>
);
})}
</tr>
);
})}
</tbody>
</table>
</tbody>
</table>
) : (
<div className="tw-flex tw-justify-center tw-font-medium tw-items-center tw-border tw-border-main tw-rounded-md tw-p-8">
No sample data available
</div>
)}
</div>
);
};

4
catalog-rest-service/src/main/resources/ui/src/components/my-data-details/SchemaTab.tsx
View File

@ -81,8 +81,8 @@ const SchemaTab: FunctionComponent<Props> = ({
});
return {
columns: updatedColumns as SampleColumns[],
rows: sampleData.rows,
columns: updatedColumns as SampleColumns[] | undefined,
rows: sampleData?.rows,
};
};