From 98201724c3af61f3db744fa93c26cc6fd7059de0 Mon Sep 17 00:00:00 2001
From: Mohit Yadav <105265192+mohityadav766@users.noreply.github.com>
Date: Mon, 8 May 2023 21:25:41 +0530
Subject: [PATCH] Fix for test logging exception for metadata service + updated
 Insight Template URl (#11485)

---
 .../IngestionPipelineResource.java            | 83 ++++++++++---------
 .../emailTemplates/dataInsightReport.ftl      |  2 +-
 2 files changed, 44 insertions(+), 41 deletions(-)

diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/ingestionpipelines/IngestionPipelineResource.java b/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/ingestionpipelines/IngestionPipelineResource.java
index 0afdf7d8349..9cc0258be61 100644
--- a/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/ingestionpipelines/IngestionPipelineResource.java
+++ b/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/ingestionpipelines/IngestionPipelineResource.java
@@ -125,49 +125,52 @@ public class IngestionPipelineResource extends EntityResource<IngestionPipeline,
     this.pipelineServiceClient =
         PipelineServiceClientFactory.createPipelineServiceClient(config.getPipelineServiceClientConfiguration());
     dao.setPipelineServiceClient(pipelineServiceClient);
-    createIndexAndInsightPipeline();
+    createIndexAndInsightPipeline(config);
   }
 
-  private void createIndexAndInsightPipeline() {
-    try {
-      EntityReference metadataService =
-          this.metadataServiceRepository
-              .getByName(null, OPENMETADATA_SERVICE, dao.getFields("id"))
-              .getEntityReference();
-      // Create Data Insights Pipeline
-      CreateIngestionPipeline createPipelineRequest =
-          new CreateIngestionPipeline()
-              .withName(DEFAULT_INSIGHT_PIPELINE)
-              .withDisplayName(DEFAULT_INSIGHT_PIPELINE)
-              .withDescription("Data Insights Pipeline")
-              .withPipelineType(PipelineType.DATA_INSIGHT)
-              .withSourceConfig(
-                  new SourceConfig()
-                      .withConfig(
-                          new MetadataToElasticSearchPipeline()
-                              .withType(
-                                  MetadataToElasticSearchPipeline.MetadataToESConfigType.METADATA_TO_ELASTIC_SEARCH)))
-              .withAirflowConfig(IngestionPipelineUtils.getDefaultAirflowConfig())
-              .withService(metadataService);
-      // Get Pipeline
-      IngestionPipeline dataInsightPipeline =
-          getIngestionPipeline(createPipelineRequest, "system").withProvider(ProviderType.SYSTEM);
-      dao.setFullyQualifiedName(dataInsightPipeline);
-      dao.initializeEntity(dataInsightPipeline);
+  private void createIndexAndInsightPipeline(OpenMetadataApplicationConfig config) {
+    // Metadata Service is created only when ES config is present
+    if (config.getElasticSearchConfiguration() != null) {
+      try {
+        EntityReference metadataService =
+            this.metadataServiceRepository
+                .getByName(null, OPENMETADATA_SERVICE, dao.getFields("id"))
+                .getEntityReference();
+        // Create Data Insights Pipeline
+        CreateIngestionPipeline createPipelineRequest =
+            new CreateIngestionPipeline()
+                .withName(DEFAULT_INSIGHT_PIPELINE)
+                .withDisplayName(DEFAULT_INSIGHT_PIPELINE)
+                .withDescription("Data Insights Pipeline")
+                .withPipelineType(PipelineType.DATA_INSIGHT)
+                .withSourceConfig(
+                    new SourceConfig()
+                        .withConfig(
+                            new MetadataToElasticSearchPipeline()
+                                .withType(
+                                    MetadataToElasticSearchPipeline.MetadataToESConfigType.METADATA_TO_ELASTIC_SEARCH)))
+                .withAirflowConfig(IngestionPipelineUtils.getDefaultAirflowConfig())
+                .withService(metadataService);
+        // Get Pipeline
+        IngestionPipeline dataInsightPipeline =
+            getIngestionPipeline(createPipelineRequest, "system").withProvider(ProviderType.SYSTEM);
+        dao.setFullyQualifiedName(dataInsightPipeline);
+        dao.initializeEntity(dataInsightPipeline);
 
-      // Create Reindex Pipeline
-      createPipelineRequest
-          .withName(DEFAULT_REINDEX_PIPELINE)
-          .withDisplayName(DEFAULT_REINDEX_PIPELINE)
-          .withDescription("Elastic Search Reindexing Pipeline")
-          .withPipelineType(PipelineType.ELASTIC_SEARCH_REINDEX);
-      // Get Pipeline
-      IngestionPipeline elasticSearchPipeline =
-          getIngestionPipeline(createPipelineRequest, "system").withProvider(ProviderType.SYSTEM);
-      dao.setFullyQualifiedName(elasticSearchPipeline);
-      dao.initializeEntity(elasticSearchPipeline);
-    } catch (Exception ex) {
-      LOG.error("[IngestionPipelineResource] Failed in Creating Reindex and Insight Pipeline", ex);
+        // Create Reindex Pipeline
+        createPipelineRequest
+            .withName(DEFAULT_REINDEX_PIPELINE)
+            .withDisplayName(DEFAULT_REINDEX_PIPELINE)
+            .withDescription("Elastic Search Reindexing Pipeline")
+            .withPipelineType(PipelineType.ELASTIC_SEARCH_REINDEX);
+        // Get Pipeline
+        IngestionPipeline elasticSearchPipeline =
+            getIngestionPipeline(createPipelineRequest, "system").withProvider(ProviderType.SYSTEM);
+        dao.setFullyQualifiedName(elasticSearchPipeline);
+        dao.initializeEntity(elasticSearchPipeline);
+      } catch (Exception ex) {
+        LOG.error("[IngestionPipelineResource] Failed in Creating Reindex and Insight Pipeline", ex);
+      }
     }
   }
 
diff --git a/openmetadata-service/src/main/resources/emailTemplates/dataInsightReport.ftl b/openmetadata-service/src/main/resources/emailTemplates/dataInsightReport.ftl
index 25329482085..9ed6ac535a7 100644
--- a/openmetadata-service/src/main/resources/emailTemplates/dataInsightReport.ftl
+++ b/openmetadata-service/src/main/resources/emailTemplates/dataInsightReport.ftl
@@ -161,7 +161,7 @@
                   <td align="center" valign="top" height="759" bgcolor="#ffffff" style="padding: 10px; height: 759px;">
                     <table border="0" cellspacing="0" cellpadding="0" width="590" style="width: 590px;">
                       <div>
-                        <img src="img/i-1839955869.png" width="1000" alt="" border="0" style="display: block; max-width: 1000px; width: 100%;" class="w1000px">
+                        <img src="https://i.imgur.com/ARPP9s5.png" width="1000" alt="" border="0" style="display: block; max-width: 1000px; width: 100%;" class="w1000px">
                       </div>
                     </table>
                     <div>