yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-07-25 18:30:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix #7147 UI: Wrong task type being created for Request Description tasks (#7186)

Browse Source 
* Fix #7147 UI: Wrong task type being created for Request Description tasks

* Fix new user signup throws EntityNotFound error #7174
This commit is contained in:
Sachin Chaurasiya 2022-09-03 13:33:49 +05:30 committed by GitHub
parent 3dd9a40fa5
commit 98acad6663
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 17 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
openmetadata-ui/src/main/resources/ui/src/authentication/auth-provider/AuthProvider.tsx
View File

@ -363,7 +363,8 @@ export const AuthProvider = ({
setIsSigningIn(true); setIsSigningIn(true);
history.push(ROUTES.SIGNUP); history.push(ROUTES.SIGNUP);
} else { } else {
showErrorToast(err); // eslint-disable-next-line no-console
console.error(err);
history.push(ROUTES.SIGNIN); history.push(ROUTES.SIGNIN);
} }
}) })

6
openmetadata-ui/src/main/resources/ui/src/components/DatasetDetails/DatasetDetails.component.tsx
View File

@ -277,7 +277,11 @@ const DatasetDetails: React.FC<DatasetDetailsProps> = ({
selectedName: 'icon-profilercolor', selectedName: 'icon-profilercolor',
}, },
isProtected: false, isProtected: false,
isHidden: !(tablePermissions.ViewAll || tablePermissions.ViewDataProfile), isHidden: !(
tablePermissions.ViewAll ||
tablePermissions.ViewDataProfile ||
tablePermissions.ViewTests
),
position: 5, position: 5,
}, },
{ {

22
openmetadata-ui/src/main/resources/ui/src/components/EntityTable/EntityTable.component.tsx
View File

@ -301,8 +301,7 @@ const EntityTable = ({
return searchedValue; return searchedValue;
}; };
/* eslint-disable-next-line @typescript-eslint/no-explicit-any */ const getColumnName = (cell: ModifiedTableColumn) => {
const getColumnName = (cell: any) => {
const fqn = cell?.fullyQualifiedName || ''; const fqn = cell?.fullyQualifiedName || '';
const columnName = getPartialNameFromTableFQN(fqn, [FqnPart.NestedColumn]); const columnName = getPartialNameFromTableFQN(fqn, [FqnPart.NestedColumn]);
// wrap it in quotes if dot is present // wrap it in quotes if dot is present
@ -312,8 +311,7 @@ const EntityTable = ({
: columnName; : columnName;
}; };
/* eslint-disable-next-line @typescript-eslint/no-explicit-any */ const onRequestDescriptionHandler = (cell: ModifiedTableColumn) => {
const onRequestDescriptionHandler = (cell: any) => {
const field = EntityField.COLUMNS; const field = EntityField.COLUMNS;
const value = getColumnName(cell); const value = getColumnName(cell);
history.push( history.push(
@ -326,8 +324,7 @@ const EntityTable = ({
); );
}; };
/* eslint-disable-next-line @typescript-eslint/no-explicit-any */ const onUpdateDescriptionHandler = (cell: ModifiedTableColumn) => {
const onUpdateDescriptionHandler = (cell: any) => {
const field = EntityField.COLUMNS; const field = EntityField.COLUMNS;
const value = getColumnName(cell); const value = getColumnName(cell);
history.push( history.push(
@ -340,8 +337,7 @@ const EntityTable = ({
); );
}; };
/* eslint-disable-next-line @typescript-eslint/no-explicit-any */ const onRequestTagsHandler = (cell: ModifiedTableColumn) => {
const onRequestTagsHandler = (cell: any) => {
const field = EntityField.COLUMNS; const field = EntityField.COLUMNS;
const value = getColumnName(cell); const value = getColumnName(cell);
history.push( history.push(
@ -349,8 +345,7 @@ const EntityTable = ({
); );
}; };
/* eslint-disable-next-line @typescript-eslint/no-explicit-any */ const onUpdateTagsHandler = (cell: ModifiedTableColumn) => {
const onUpdateTagsHandler = (cell: any) => {
const field = EntityField.COLUMNS; const field = EntityField.COLUMNS;
const value = getColumnName(cell); const value = getColumnName(cell);
history.push( history.push(
@ -381,7 +376,7 @@ const EntityTable = ({
}; };
const getRequestDescriptionElement = (cell: ModifiedTableColumn) => { const getRequestDescriptionElement = (cell: ModifiedTableColumn) => {
const hasDescription = Boolean(cell.fullyQualifiedName); const hasDescription = Boolean(cell?.description ?? '');
return ( return (
<button <button
@ -412,9 +407,8 @@ const EntityTable = ({
); );
}; };
/* eslint-disable-next-line @typescript-eslint/no-explicit-any */ const getRequestTagsElement = (cell: ModifiedTableColumn) => {
const getRequestTagsElement = (cell: any) => { const hasTags = !isEmpty(cell?.tags || []);
const hasTags = !isEmpty(cell.value || []);
const text = hasTags ? 'Update request tags' : 'Request tags'; const text = hasTags ? 'Update request tags' : 'Request tags';
return ( return (

5
openmetadata-ui/src/main/resources/ui/src/components/PermissionProvider/PermissionProvider.tsx
View File

@ -11,7 +11,6 @@
* limitations under the License. * limitations under the License.
*/ */
import { AxiosError } from 'axios';
import { observer } from 'mobx-react'; import { observer } from 'mobx-react';
import React, { import React, {
createContext, createContext,
@ -32,7 +31,6 @@ import {
getOperationPermissions, getOperationPermissions,
getUIPermission, getUIPermission,
} from '../../utils/PermissionsUtils'; } from '../../utils/PermissionsUtils';
import { showErrorToast } from '../../utils/ToastUtils';
import { import {
EntityPermissionMap, EntityPermissionMap,
PermissionContextType, PermissionContextType,
@ -83,7 +81,8 @@ const PermissionProvider: FC<PermissionProviderProps> = ({ children }) => {
const response = await getLoggedInUserPermissions(); const response = await getLoggedInUserPermissions();
setPermissions(getUIPermission(response.data || [])); setPermissions(getUIPermission(response.data || []));
} catch (error) { } catch (error) {
showErrorToast(error as AxiosError); // eslint-disable-next-line no-console
console.error(error);
} }
}; };