From 99f7a0e447212418b1e85a76ef824c6c54ff30c7 Mon Sep 17 00:00:00 2001 From: Mayur Singal <39544459+ulixius9@users.noreply.github.com> Date: Sat, 22 Apr 2023 16:23:03 +0530 Subject: [PATCH] Remove Validation On Display Datatype (#11208) --- .../service/resources/databases/DatabaseUtil.java | 9 --------- .../service/resources/databases/TableResourceTest.java | 7 ------- 2 files changed, 16 deletions(-) diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/resources/databases/DatabaseUtil.java b/openmetadata-service/src/main/java/org/openmetadata/service/resources/databases/DatabaseUtil.java index 643beb5bd89..33726d2f42d 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/resources/databases/DatabaseUtil.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/resources/databases/DatabaseUtil.java @@ -144,11 +144,6 @@ public final class DatabaseUtil { if (column.getArrayDataType() == null) { throw new IllegalArgumentException("For column data type array, arrayDataType " + "must not be null"); } - - if (!column.getDataTypeDisplay().startsWith("array<")) { - throw new IllegalArgumentException( - "For column data type array, dataTypeDisplay must be of type " + "array"); - } } } @@ -160,10 +155,6 @@ public final class DatabaseUtil { } validateColumnNames(column.getChildren()); - if (!column.getDataTypeDisplay().startsWith("struct<")) { - throw new IllegalArgumentException( - "For column data type struct, dataTypeDisplay must be of type " + "struct"); - } } } diff --git a/openmetadata-service/src/test/java/org/openmetadata/service/resources/databases/TableResourceTest.java b/openmetadata-service/src/test/java/org/openmetadata/service/resources/databases/TableResourceTest.java index 339b7c4ab7e..493724548f6 100644 --- a/openmetadata-service/src/test/java/org/openmetadata/service/resources/databases/TableResourceTest.java +++ b/openmetadata-service/src/test/java/org/openmetadata/service/resources/databases/TableResourceTest.java @@ -214,13 +214,6 @@ public class TableResourceTest extends EntityResourceTest { () -> createEntity(create, ADMIN_AUTH_HEADERS), BAD_REQUEST, "For column data type array, arrayDataType must not be null"); - - // No dataTypeDisplay passed for array - columns.get(0).withArrayDataType(INT).withDataTypeDisplay(null); - assertResponse( - () -> createEntity(create, ADMIN_AUTH_HEADERS), - BAD_REQUEST, - "For column data type array, dataTypeDisplay must be of type array"); } @Test