From 9a1fedf2a044f6f71664b99a74653a951efaf09a Mon Sep 17 00:00:00 2001 From: Teddy Date: Mon, 21 Jul 2025 17:57:26 +0200 Subject: [PATCH] feat: pass GX description on test case creation (#22481) --- ingestion/src/metadata/great_expectations/action.py | 11 +++++++++++ .../metadata/ingestion/ometa/mixins/tests_mixin.py | 2 ++ 2 files changed, 13 insertions(+) diff --git a/ingestion/src/metadata/great_expectations/action.py b/ingestion/src/metadata/great_expectations/action.py index 3f737085e2e..da24c3217a5 100644 --- a/ingestion/src/metadata/great_expectations/action.py +++ b/ingestion/src/metadata/great_expectations/action.py @@ -322,6 +322,16 @@ class OpenMetadataValidationAction(ValidationAction): fqn_ = cast(str, fqn_) return fqn_ + def _get_test_case_description(self, result: dict) -> str: + """Get test case description from GE test result""" + if self.expectation_suite: + expectation = self._get_expectation_config(result) + if expectation: + meta: Optional[Dict] = expectation.get("meta") + if meta: + return meta.get("description", "") + return "" + def _get_test_case_params_value(self, result: dict) -> List[TestCaseParameterValue]: """Build test case parameter value from GE test result""" if self.expectation_suite: @@ -545,6 +555,7 @@ class OpenMetadataValidationAction(ValidationAction): ), test_definition_fqn=test_definition.fullyQualifiedName.root, test_case_parameter_values=self._get_test_case_params_value(result), + description=self._get_test_case_description(result), ) self.ometa_conn.add_test_case_results( diff --git a/ingestion/src/metadata/ingestion/ometa/mixins/tests_mixin.py b/ingestion/src/metadata/ingestion/ometa/mixins/tests_mixin.py index 414c07fa140..38c3a2b2c6a 100644 --- a/ingestion/src/metadata/ingestion/ometa/mixins/tests_mixin.py +++ b/ingestion/src/metadata/ingestion/ometa/mixins/tests_mixin.py @@ -169,6 +169,7 @@ class OMetaTestsMixin: entity_link: Optional[str] = None, test_definition_fqn: Optional[str] = None, test_case_parameter_values: Optional[List[TestCaseParameterValue]] = None, + description: Optional[str] = None, ): """Get or create a test case @@ -197,6 +198,7 @@ class OMetaTestsMixin: entityLink=entity_link, testDefinition=test_definition_fqn, parameterValues=test_case_parameter_values, + description=description, ) # type: ignore ) return test_case