yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-08-09 09:38:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: pass GX description on test case creation (#22481)

Browse Source
This commit is contained in:
Teddy 2025-07-21 17:57:26 +02:00 committed by GitHub
parent 787d86eb8a
commit 9a1fedf2a0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
ingestion/src/metadata/great_expectations/action.py
View File

@ -322,6 +322,16 @@ class OpenMetadataValidationAction(ValidationAction):
fqn_ = cast(str, fqn_) fqn_ = cast(str, fqn_)
return fqn_ return fqn_
def _get_test_case_description(self, result: dict) -> str:
"""Get test case description from GE test result"""
if self.expectation_suite:
expectation = self._get_expectation_config(result)
if expectation:
meta: Optional[Dict] = expectation.get("meta")
if meta:
return meta.get("description", "")
return ""
def _get_test_case_params_value(self, result: dict) -> List[TestCaseParameterValue]: def _get_test_case_params_value(self, result: dict) -> List[TestCaseParameterValue]:
"""Build test case parameter value from GE test result""" """Build test case parameter value from GE test result"""
if self.expectation_suite: if self.expectation_suite:
@ -545,6 +555,7 @@ class OpenMetadataValidationAction(ValidationAction):
), ),
test_definition_fqn=test_definition.fullyQualifiedName.root, test_definition_fqn=test_definition.fullyQualifiedName.root,
test_case_parameter_values=self._get_test_case_params_value(result), test_case_parameter_values=self._get_test_case_params_value(result),
description=self._get_test_case_description(result),
) )
self.ometa_conn.add_test_case_results( self.ometa_conn.add_test_case_results(

2
ingestion/src/metadata/ingestion/ometa/mixins/tests_mixin.py
View File

@ -169,6 +169,7 @@ class OMetaTestsMixin:
entity_link: Optional[str] = None, entity_link: Optional[str] = None,
test_definition_fqn: Optional[str] = None, test_definition_fqn: Optional[str] = None,
test_case_parameter_values: Optional[List[TestCaseParameterValue]] = None, test_case_parameter_values: Optional[List[TestCaseParameterValue]] = None,
description: Optional[str] = None,
): ):
"""Get or create a test case """Get or create a test case
@ -197,6 +198,7 @@ class OMetaTestsMixin:
entityLink=entity_link, entityLink=entity_link,
testDefinition=test_definition_fqn, testDefinition=test_definition_fqn,
parameterValues=test_case_parameter_values, parameterValues=test_case_parameter_values,
description=description,
) # type: ignore ) # type: ignore
) )
return test_case return test_case