yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-11-03 12:08:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

Changed the remove tier button (#11159)

Browse Source
This commit is contained in:
Aniket Katkar 2023-04-20 23:10:12 +05:30 committed by GitHub
parent 7779704bfb
commit 9acf45cd1b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 28 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
openmetadata-ui/src/main/resources/ui/src/assets/svg/ic-remove.svg
View File

@ -1 +1,10 @@
<svg xmlns="http://www.w3.org/2000/svg" viewbox="0 0 16 16" fill="none"><path fill="#37352F" d="M8 16c-4.411 0-8-3.589-8-8s3.589-8 8-8 8 3.589 8 8-3.589 8-8 8ZM8 1C4.14 1 1 4.14 1 8s3.14 7 7 7 7-3.14 7-7-3.14-7-7-7Zm4 7a.5.5 0 0 0-.5-.5h-7a.5.5 0 1 0 0 1h7A.5.5 0 0 0 12 8Z"/></svg>
<svg viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg">
<g clip-path="url(#clip0_13240_20739)">
<path d="M8 16C3.58887 16 0 12.4111 0 8C0 3.58887 3.58887 0 8 0C12.4111 0 16 3.58887 16 8C16 12.4111 12.4111 16 8 16ZM8 1C4.14013 1 1 4.14013 1 8C1 11.8599 4.14013 15 8 15C11.8599 15 15 11.8599 15 8C15 4.14013 11.8599 1 8 1ZM12 8C12 7.72363 11.7764 7.5 11.5 7.5H4.5C4.22363 7.5 4 7.72363 4 8C4 8.27637 4.22363 8.5 4.5 8.5H11.5C11.7764 8.5 12 8.27637 12 8Z" fill="currentColor"/>
</g>
<defs>
<clipPath id="clip0_13240_20739">
<rect width="16" height="16" fill="white"/>
</clipPath>
</defs>
</svg>

Side by Side Swipe Overlay

Before

Width:  |  Height:  |  Size: 282 B

After

Width:  |  Height:  |  Size: 609 B

36
openmetadata-ui/src/main/resources/ui/src/components/cardlist/CardListItem/CardWithListItem.tsx
View File

@ -11,15 +11,13 @@
* limitations under the License.
*/
import {
CheckCircleOutlined,
DownOutlined,
RightOutlined,
} from '@ant-design/icons';
import { Button, Space } from 'antd';
import { DownOutlined, RightOutlined } from '@ant-design/icons';
import Icon from '@ant-design/icons/lib/components/Icon';
import { Button } from 'antd';
import classNames from 'classnames';
import { t } from 'i18next';
import React, { FunctionComponent } from 'react';
import { ReactComponent as IconRemove } from '../../../assets/svg/ic-remove.svg';
import RichTextEditorPreviewer from '../../common/rich-text-editor/RichTextEditorPreviewer';
import Loader from '../../Loader/Loader';
import { Props } from './CardWithListItem.interface';
@ -63,7 +61,14 @@ const CardListItem: FunctionComponent<Props> = ({
);
case 'success':
return <CheckCircleOutlined className="tw-text-h4" />;
return (
<Icon
className="text-xl"
component={IconRemove}
data-testid="remove-tier"
onClick={onRemove}
/>
);
default:
return (
@ -81,17 +86,12 @@ const CardListItem: FunctionComponent<Props> = ({
const getCardIcon = (cardId: string) => {
if (isSelected || (isSelected && isActive)) {
return (
<Space align="center">
<Button
danger
data-testid="remove-tier"
size="small"
type="primary"
onClick={onRemove}>
{t('label.remove')}
</Button>
<CheckCircleOutlined className="tw-text-h4" />
</Space>
<Icon
className="text-xl"
component={IconRemove}
data-testid="remove-tier"
onClick={onRemove}
/>
);
} else if (isActive) {
return getTierSelectButton(cardId);