yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-11-03 20:19:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: snowflake frequently join table (#10157)

Browse Source
This commit is contained in:
NiharDoshi99 2023-02-09 18:05:52 +05:30 committed by GitHub
parent 5c351781f5
commit 9bb99407e5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
ingestion/src/metadata/ingestion/lineage/parser.py
View File

@ -18,7 +18,7 @@ from logging.config import DictConfigurator
from typing import Any, Dict, List, Optional, Tuple, Union
from cached_property import cached_property
from sqlparse.sql import Comparison, Identifier, Statement
from sqlparse.sql import Comparison, Identifier, Parenthesis, Statement
from metadata.generated.schema.type.tableUsageCount import TableColumn, TableColumnJoin
from metadata.ingestion.lineage.models import Dialect
@ -261,10 +261,18 @@ class LineageParser:
:param statement: Parsed sql statement to process
:return: for each table name, list all joins against other tables
"""
# Here we want to get tokens such as `tableA.col1 = tableB.col2`
comparisons = [
sub for sub in statement.get_sublists() if isinstance(sub, Comparison)
]
# Here we want to get tokens such as `(tableA.col1 = tableB.col2)`
comparisons: List[Comparison] = []
for sub in statement.get_sublists():
if isinstance(sub, Parenthesis):
sub = (
sub._groupable_tokens[0] # pylint: disable=protected-access
if len(sub._groupable_tokens) # pylint: disable=protected-access
else sub
)
if isinstance(sub, Comparison):
comparisons.append(sub)
for comparison in comparisons:
if "." not in comparison.left.value or "." not in comparison.right.value:
logger.debug(f"Ignoring comparison {comparison}")