fix: remove quotes around fqn (#14055)

This commit is contained in:
karanh37 2023-11-22 13:52:27 +05:30 committed by GitHub
parent c7e758eccc
commit 9c990fef19
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 22 additions and 8 deletions

View File

@ -62,6 +62,18 @@ const checkDisplayName = (displayName) => {
});
};
const checkDataProductsCount = (dataProductsCount) => {
cy.get('[data-testid="data_products"] [data-testid="count"]')
.scrollIntoView()
.eq(dataProductsCount);
};
const checkAssetsCount = (assetsCount) => {
cy.get('[data-testid="assets"] [data-testid="count"]')
.scrollIntoView()
.eq(assetsCount);
};
const updateOwner = (newOwner) => {
interceptURL('PATCH', `/api/v1/domains/*`, 'patchOwner');
interceptURL('GET', '/api/v1/users?limit=25&isBot=false', 'getUsers');
@ -267,6 +279,8 @@ export const createDomain = (domainObj, validate) => {
cy.url().should('include', '/domain/');
checkDisplayName(domainObj.name);
checkAssetsCount(0);
checkDataProductsCount(0);
});
};

View File

@ -429,7 +429,7 @@ export const AuthProvider = ({
// Parse and update the query parameter
const queryParams = Qs.parse(config.url.split('?')[1]);
// adding quotes for exact matching
const domainStatement = `(domain.fullyQualifiedName:"${activeDomain}")`;
const domainStatement = `(domain.fullyQualifiedName:${activeDomain})`;
queryParams.q = queryParams.q ?? '';
queryParams.q += isEmpty(queryParams.q)
? domainStatement

View File

@ -208,7 +208,7 @@ const DataProductsDetailsPage = ({
'',
1,
0,
`(dataProducts.fullyQualifiedName:"${fqn}")`,
`(dataProducts.fullyQualifiedName:${fqn})`,
'',
'',
SearchIndex.ALL

View File

@ -190,7 +190,7 @@ const DomainDetailsPage = ({
async (formData: CreateDataProduct) => {
const data = {
...formData,
domain: domain.name,
domain: domain.fullyQualifiedName,
};
try {
@ -238,7 +238,7 @@ const DomainDetailsPage = ({
'',
1,
0,
`(domain.fullyQualifiedName:"${domainFqn}")`,
`(domain.fullyQualifiedName:${domainFqn})`,
'',
'',
SearchIndex.DATA_PRODUCT
@ -258,7 +258,7 @@ const DomainDetailsPage = ({
'',
1,
0,
`(domain.fullyQualifiedName:"${fqn}")`,
`(domain.fullyQualifiedName:${fqn})`,
'',
'',
SearchIndex.ALL

View File

@ -58,7 +58,7 @@ const DataProductsTab = forwardRef(
'',
1,
PAGE_SIZE_LARGE,
`(domain.fullyQualifiedName:"${domainFqn}")`,
`(domain.fullyQualifiedName:${domainFqn})`,
'',
'',
SearchIndex.DATA_PRODUCT

View File

@ -148,10 +148,10 @@ const AssetsTabs = forwardRef(
const queryParam = useMemo(() => {
switch (type) {
case AssetsOfEntity.DOMAIN:
return `(domain.fullyQualifiedName:"${fqn}")`;
return `(domain.fullyQualifiedName:${fqn})`;
case AssetsOfEntity.DATA_PRODUCT:
return `(dataProducts.fullyQualifiedName:"${fqn}")`;
return `(dataProducts.fullyQualifiedName:${fqn})`;
case AssetsOfEntity.TEAM:
return `(owner.fullyQualifiedName:"${fqn}")`;