yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-11-14 01:40:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove quotes around fqn (#14055)

Browse Source
This commit is contained in:
karanh37 2023-11-22 13:52:27 +05:30 committed by GitHub
parent c7e758eccc
commit 9c990fef19
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 22 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
openmetadata-ui/src/main/resources/ui/cypress/common/DomainUtils.js
View File

@ -62,6 +62,18 @@ const checkDisplayName = (displayName) => {
}); });
}; };
const checkDataProductsCount = (dataProductsCount) => {
cy.get('[data-testid="data_products"] [data-testid="count"]')
.scrollIntoView()
.eq(dataProductsCount);
};
const checkAssetsCount = (assetsCount) => {
cy.get('[data-testid="assets"] [data-testid="count"]')
.scrollIntoView()
.eq(assetsCount);
};
const updateOwner = (newOwner) => { const updateOwner = (newOwner) => {
interceptURL('PATCH', `/api/v1/domains/*`, 'patchOwner'); interceptURL('PATCH', `/api/v1/domains/*`, 'patchOwner');
interceptURL('GET', '/api/v1/users?limit=25&isBot=false', 'getUsers'); interceptURL('GET', '/api/v1/users?limit=25&isBot=false', 'getUsers');
@ -267,6 +279,8 @@ export const createDomain = (domainObj, validate) => {
cy.url().should('include', '/domain/'); cy.url().should('include', '/domain/');
checkDisplayName(domainObj.name); checkDisplayName(domainObj.name);
checkAssetsCount(0);
checkDataProductsCount(0);
}); });
}; };

2
openmetadata-ui/src/main/resources/ui/src/components/Auth/AuthProviders/AuthProvider.tsx
View File

@ -429,7 +429,7 @@ export const AuthProvider = ({
// Parse and update the query parameter // Parse and update the query parameter
const queryParams = Qs.parse(config.url.split('?')[1]); const queryParams = Qs.parse(config.url.split('?')[1]);
// adding quotes for exact matching // adding quotes for exact matching
const domainStatement = `(domain.fullyQualifiedName:"${activeDomain}")`; const domainStatement = `(domain.fullyQualifiedName:${activeDomain})`;
queryParams.q = queryParams.q ?? ''; queryParams.q = queryParams.q ?? '';
queryParams.q += isEmpty(queryParams.q) queryParams.q += isEmpty(queryParams.q)
? domainStatement ? domainStatement

2
openmetadata-ui/src/main/resources/ui/src/components/DataProducts/DataProductsDetailsPage/DataProductsDetailsPage.component.tsx
View File

@ -208,7 +208,7 @@ const DataProductsDetailsPage = ({
'', '',
1, 1,
0, 0,
`(dataProducts.fullyQualifiedName:"${fqn}")`, `(dataProducts.fullyQualifiedName:${fqn})`,
'', '',
'', '',
SearchIndex.ALL SearchIndex.ALL

6
openmetadata-ui/src/main/resources/ui/src/components/Domain/DomainDetailsPage/DomainDetailsPage.component.tsx
View File

@ -190,7 +190,7 @@ const DomainDetailsPage = ({
async (formData: CreateDataProduct) => { async (formData: CreateDataProduct) => {
const data = { const data = {
...formData, ...formData,
domain: domain.name, domain: domain.fullyQualifiedName,
}; };
try { try {
@ -238,7 +238,7 @@ const DomainDetailsPage = ({
'', '',
1, 1,
0, 0,
`(domain.fullyQualifiedName:"${domainFqn}")`, `(domain.fullyQualifiedName:${domainFqn})`,
'', '',
'', '',
SearchIndex.DATA_PRODUCT SearchIndex.DATA_PRODUCT
@ -258,7 +258,7 @@ const DomainDetailsPage = ({
'', '',
1, 1,
0, 0,
`(domain.fullyQualifiedName:"${fqn}")`, `(domain.fullyQualifiedName:${fqn})`,
'', '',
'', '',
SearchIndex.ALL SearchIndex.ALL

2
openmetadata-ui/src/main/resources/ui/src/components/Domain/DomainTabs/DataProductsTab/DataProductsTab.component.tsx
View File

@ -58,7 +58,7 @@ const DataProductsTab = forwardRef(
'', '',
1, 1,
PAGE_SIZE_LARGE, PAGE_SIZE_LARGE,
`(domain.fullyQualifiedName:"${domainFqn}")`, `(domain.fullyQualifiedName:${domainFqn})`,
'', '',
'', '',
SearchIndex.DATA_PRODUCT SearchIndex.DATA_PRODUCT

4
openmetadata-ui/src/main/resources/ui/src/components/Glossary/GlossaryTerms/tabs/AssetsTabs.component.tsx
View File

@ -148,10 +148,10 @@ const AssetsTabs = forwardRef(
const queryParam = useMemo(() => { const queryParam = useMemo(() => {
switch (type) { switch (type) {
case AssetsOfEntity.DOMAIN: case AssetsOfEntity.DOMAIN:
return `(domain.fullyQualifiedName:"${fqn}")`; return `(domain.fullyQualifiedName:${fqn})`;
case AssetsOfEntity.DATA_PRODUCT: case AssetsOfEntity.DATA_PRODUCT:
return `(dataProducts.fullyQualifiedName:"${fqn}")`; return `(dataProducts.fullyQualifiedName:${fqn})`;
case AssetsOfEntity.TEAM: case AssetsOfEntity.TEAM:
return `(owner.fullyQualifiedName:"${fqn}")`; return `(owner.fullyQualifiedName:"${fqn}")`;